* [PATCH] crypto: brcm - software fallback for cryptlen zero
@ 2017-06-23 8:22 Raveendra Padasalagi
2017-06-23 8:34 ` Anup Patel
0 siblings, 1 reply; 2+ messages in thread
From: Raveendra Padasalagi @ 2017-06-23 8:22 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Rob Rice, Scott Branden, Ray Jui,
Steve Lin, linux-crypto
Cc: bcm-kernel-feedback-list, linux-kernel, Raveendra Padasalagi
Zero length payload requests are not handled in
Broadcom SPU2 engine, so this patch adds conditional
check to fallback to software implementation for AES-GCM
and AES-CCM algorithms.
Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
---
drivers/crypto/bcm/cipher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c
index cc0d5b9..6c80863 100644
--- a/drivers/crypto/bcm/cipher.c
+++ b/drivers/crypto/bcm/cipher.c
@@ -2625,7 +2625,7 @@ static int aead_need_fallback(struct aead_request *req)
*/
if (((ctx->cipher.mode == CIPHER_MODE_GCM) ||
(ctx->cipher.mode == CIPHER_MODE_CCM)) &&
- (req->assoclen == 0)) {
+ ((req->assoclen == 0) || (req->cryptlen == 0))) {
if ((rctx->is_encrypt && (req->cryptlen == 0)) ||
(!rctx->is_encrypt && (req->cryptlen == ctx->digestsize))) {
flow_log("AES GCM/CCM needs fallback for 0 len req\n");
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: brcm - software fallback for cryptlen zero
2017-06-23 8:22 [PATCH] crypto: brcm - software fallback for cryptlen zero Raveendra Padasalagi
@ 2017-06-23 8:34 ` Anup Patel
0 siblings, 0 replies; 2+ messages in thread
From: Anup Patel @ 2017-06-23 8:34 UTC (permalink / raw)
To: Raveendra Padasalagi
Cc: Herbert Xu, David S. Miller, Rob Rice, Scott Branden, Ray Jui,
Steve Lin, linux-crypto, BCM Kernel Feedback, Linux Kernel
On Fri, Jun 23, 2017 at 1:52 PM, Raveendra Padasalagi
<raveendra.padasalagi@broadcom.com> wrote:
> Zero length payload requests are not handled in
> Broadcom SPU2 engine, so this patch adds conditional
> check to fallback to software implementation for AES-GCM
> and AES-CCM algorithms.
>
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/crypto/bcm/cipher.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c
> index cc0d5b9..6c80863 100644
> --- a/drivers/crypto/bcm/cipher.c
> +++ b/drivers/crypto/bcm/cipher.c
> @@ -2625,7 +2625,7 @@ static int aead_need_fallback(struct aead_request *req)
> */
> if (((ctx->cipher.mode == CIPHER_MODE_GCM) ||
> (ctx->cipher.mode == CIPHER_MODE_CCM)) &&
> - (req->assoclen == 0)) {
> + ((req->assoclen == 0) || (req->cryptlen == 0))) {
> if ((rctx->is_encrypt && (req->cryptlen == 0)) ||
> (!rctx->is_encrypt && (req->cryptlen == ctx->digestsize))) {
> flow_log("AES GCM/CCM needs fallback for 0 len req\n");
> --
> 1.9.1
>
This should go in linux-stable too.
Please CC Linux stable and include "Fixes:".
Regards,
Anup
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-23 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 8:22 [PATCH] crypto: brcm - software fallback for cryptlen zero Raveendra Padasalagi
2017-06-23 8:34 ` Anup Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).