linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clock: Remove unneeded return statement from void
@ 2015-09-23 11:19 Guillaume Gomez
  2015-10-11 20:09 ` [tip:timers/core] clock: Remove return statement from void functions tip-bot for Guillaume Gomez
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Guillaume Gomez @ 2015-09-23 11:19 UTC (permalink / raw)
  To: John Stultz, tglx, linux-kernel

Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
---
 kernel/time/clocksource.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 841b72f..5e83c38 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -595,12 +595,12 @@ static void __clocksource_select(bool skipcur)
  */
 static void clocksource_select(void)
 {
-    return __clocksource_select(false);
+    __clocksource_select(false);
 }

 static void clocksource_select_fallback(void)
 {
-    return __clocksource_select(true);
+    __clocksource_select(true);
 }

 #else /* !CONFIG_ARCH_USES_GETTIMEOFFSET */
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [tip:timers/core] clock: Remove return statement from void functions
  2015-09-23 11:19 [PATCH] clock: Remove unneeded return statement from void Guillaume Gomez
@ 2015-10-11 20:09 ` tip-bot for Guillaume Gomez
  2015-10-11 20:14 ` [PATCH] clock: Remove unneeded return statement from void Thomas Gleixner
  2015-10-11 20:15 ` [tip:timers/core] clocksource: Remove return statement from void functions tip-bot for Guillaume Gomez
  2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Guillaume Gomez @ 2015-10-11 20:09 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: john.stultz, mingo, hpa, linux-kernel, tglx, guillaume1.gomez

Commit-ID:  784e452870c028a03e42af3bd437ec45a88dfe6d
Gitweb:     http://git.kernel.org/tip/784e452870c028a03e42af3bd437ec45a88dfe6d
Author:     Guillaume Gomez <guillaume1.gomez@gmail.com>
AuthorDate: Wed, 23 Sep 2015 13:19:19 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 11 Oct 2015 22:07:23 +0200

clock: Remove return statement from void functions

Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>
Link: http://lkml.kernel.org/r/CAAOQCfSDgmqSWDBsetau%2ByF8x0%2BDagCF_pfFw0p5xH_BKkKEog@mail.gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/time/clocksource.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 174c594..de0ad66 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -595,16 +595,15 @@ static void __clocksource_select(bool skipcur)
  */
 static void clocksource_select(void)
 {
-	return __clocksource_select(false);
+	__clocksource_select(false);
 }
 
 static void clocksource_select_fallback(void)
 {
-	return __clocksource_select(true);
+	__clocksource_select(true);
 }
 
 #else /* !CONFIG_ARCH_USES_GETTIMEOFFSET */
-
 static inline void clocksource_select(void) { }
 static inline void clocksource_select_fallback(void) { }
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] clock: Remove unneeded return statement from void
  2015-09-23 11:19 [PATCH] clock: Remove unneeded return statement from void Guillaume Gomez
  2015-10-11 20:09 ` [tip:timers/core] clock: Remove return statement from void functions tip-bot for Guillaume Gomez
@ 2015-10-11 20:14 ` Thomas Gleixner
  2015-10-11 20:15 ` [tip:timers/core] clocksource: Remove return statement from void functions tip-bot for Guillaume Gomez
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2015-10-11 20:14 UTC (permalink / raw)
  To: Guillaume Gomez; +Cc: John Stultz, linux-kernel

On Wed, 23 Sep 2015, Guillaume Gomez wrote:

FYI, the proper subsystem is clocksource not clock

> Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
> ---
>  kernel/time/clocksource.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 841b72f..5e83c38 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -595,12 +595,12 @@ static void __clocksource_select(bool skipcur)
>   */
>  static void clocksource_select(void)
>  {
> -    return __clocksource_select(false);
> +    __clocksource_select(false);

This does not apply because it's white space mangled. Please fix your
mail client. See Documentation/email-clients.txt

I fixed up everything this time and applied it, but please be more
careful next time.

Thanks,

	tglx


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip:timers/core] clocksource: Remove return statement from void functions
  2015-09-23 11:19 [PATCH] clock: Remove unneeded return statement from void Guillaume Gomez
  2015-10-11 20:09 ` [tip:timers/core] clock: Remove return statement from void functions tip-bot for Guillaume Gomez
  2015-10-11 20:14 ` [PATCH] clock: Remove unneeded return statement from void Thomas Gleixner
@ 2015-10-11 20:15 ` tip-bot for Guillaume Gomez
  2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Guillaume Gomez @ 2015-10-11 20:15 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: tglx, hpa, linux-kernel, guillaume1.gomez, john.stultz, mingo

Commit-ID:  cfed432d7f4114e16e0163bcfe65e96f0c304493
Gitweb:     http://git.kernel.org/tip/cfed432d7f4114e16e0163bcfe65e96f0c304493
Author:     Guillaume Gomez <guillaume1.gomez@gmail.com>
AuthorDate: Wed, 23 Sep 2015 13:19:19 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 11 Oct 2015 22:13:46 +0200

clocksource: Remove return statement from void functions

Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>
Link: http://lkml.kernel.org/r/CAAOQCfSDgmqSWDBsetau%2ByF8x0%2BDagCF_pfFw0p5xH_BKkKEog@mail.gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/time/clocksource.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 174c594..de0ad66 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -595,16 +595,15 @@ static void __clocksource_select(bool skipcur)
  */
 static void clocksource_select(void)
 {
-	return __clocksource_select(false);
+	__clocksource_select(false);
 }
 
 static void clocksource_select_fallback(void)
 {
-	return __clocksource_select(true);
+	__clocksource_select(true);
 }
 
 #else /* !CONFIG_ARCH_USES_GETTIMEOFFSET */
-
 static inline void clocksource_select(void) { }
 static inline void clocksource_select_fallback(void) { }
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-11 20:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-23 11:19 [PATCH] clock: Remove unneeded return statement from void Guillaume Gomez
2015-10-11 20:09 ` [tip:timers/core] clock: Remove return statement from void functions tip-bot for Guillaume Gomez
2015-10-11 20:14 ` [PATCH] clock: Remove unneeded return statement from void Thomas Gleixner
2015-10-11 20:15 ` [tip:timers/core] clocksource: Remove return statement from void functions tip-bot for Guillaume Gomez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).