* [PATCH] drm/mediatek: Drop unbalanced obj unref
@ 2023-01-19 23:12 Rob Clark
2023-01-27 3:18 ` Chun-Kuang Hu
0 siblings, 1 reply; 2+ messages in thread
From: Rob Clark @ 2023-01-19 23:12 UTC (permalink / raw)
To: dri-devel
Cc: Rob Clark, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger, CK Hu, Mao Huang, Daniel Kurtz,
Bibby Hsieh, YT Shen, moderated list:DRM DRIVERS FOR MEDIATEK,
moderated list:ARM/Mediatek SoC support, open list
From: Rob Clark <robdclark@chromium.org>
In the error path, mtk_drm_gem_object_mmap() is dropping an obj
reference that it doesn't own.
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 9b3d15d3a983..f961c7c7456b 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -169,8 +169,6 @@ static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj,
ret = dma_mmap_attrs(priv->dma_dev, vma, mtk_gem->cookie,
mtk_gem->dma_addr, obj->size, mtk_gem->dma_attrs);
- if (ret)
- drm_gem_vm_close(vma);
return ret;
}
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/mediatek: Drop unbalanced obj unref
2023-01-19 23:12 [PATCH] drm/mediatek: Drop unbalanced obj unref Rob Clark
@ 2023-01-27 3:18 ` Chun-Kuang Hu
0 siblings, 0 replies; 2+ messages in thread
From: Chun-Kuang Hu @ 2023-01-27 3:18 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, Rob Clark, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger, CK Hu, Mao Huang, Daniel Kurtz,
Bibby Hsieh, YT Shen, moderated list:DRM DRIVERS FOR MEDIATEK,
moderated list:ARM/Mediatek SoC support, open list
Hi, Rob:
Rob Clark <robdclark@gmail.com> 於 2023年1月20日 週五 上午7:12寫道：
>
> From: Rob Clark <robdclark@chromium.org>
>
> In the error path, mtk_drm_gem_object_mmap() is dropping an obj
> reference that it doesn't own.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index 9b3d15d3a983..f961c7c7456b 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -169,8 +169,6 @@ static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj,
>
> ret = dma_mmap_attrs(priv->dma_dev, vma, mtk_gem->cookie,
> mtk_gem->dma_addr, obj->size, mtk_gem->dma_attrs);
> - if (ret)
> - drm_gem_vm_close(vma);
>
> return ret;
> }
> --
> 2.38.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-27 3:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-19 23:12 [PATCH] drm/mediatek: Drop unbalanced obj unref Rob Clark
2023-01-27 3:18 ` Chun-Kuang Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).