* [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183
2022-04-11 3:58 [PATCH V2 0/3] Update MediaTek disp_aal dt-binding Rex-BC Chen
@ 2022-04-11 3:58 ` Rex-BC Chen
2022-04-13 23:02 ` Rob Herring
2022-04-11 3:58 ` [PATCH V2 2/3] arm64: dts: mt8183: Update disp_aal node compatible Rex-BC Chen
2022-04-11 3:58 ` [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195 Rex-BC Chen
2 siblings, 1 reply; 9+ messages in thread
From: Rex-BC Chen @ 2022-04-11 3:58 UTC (permalink / raw)
To: chunkuang.hu, robh+dt, krzk+dt, matthias.bgg
Cc: p.zabel, airlied, yongqiang.niu, jason-jh.lin, nancy.lin,
allen-kh.cheng, dri-devel, linux-mediatek, devicetree,
linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Rex-BC Chen
The driver data of MT8183 and MT8173 are different.
For MT8173, the gamma module is inside disp_aal. When we need to adjust
gamma value, we need to use "has_gamma" to control gamma function
inside disp_aal to adjust the gamma value.
For successors like MT8183, disp_gamma is separated from disp_aal. We
just need to control disp_gamma directly and don't need to control gamma
function inside disp_aal.
With this modification, the driver doesn't require any functional changes.
We only update the dt-binding and DTS node to make it clear.
Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
index cb4a2f39ff88..f118075e4a89 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
@@ -21,12 +21,12 @@ description: |
properties:
compatible:
oneOf:
- - items:
- - const: mediatek,mt8173-disp-aal
+ - enum:
+ - mediatek,mt8173-disp-aal
+ - mediatek,mt8183-disp-aal
- items:
- enum:
- mediatek,mt2712-disp-aal
- - mediatek,mt8183-disp-aal
- mediatek,mt8192-disp-aal
- mediatek,mt8195-disp-aal
- const: mediatek,mt8173-disp-aal
--
2.18.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183
2022-04-11 3:58 ` [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183 Rex-BC Chen
@ 2022-04-13 23:02 ` Rob Herring
2022-04-16 14:20 ` Chun-Kuang Hu
0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2022-04-13 23:02 UTC (permalink / raw)
To: Rex-BC Chen
Cc: matthias.bgg, yongqiang.niu, allen-kh.cheng, linux-kernel,
krzk+dt, airlied, devicetree, nancy.lin, robh+dt, dri-devel,
linux-arm-kernel, chunkuang.hu,
Project_Global_Chrome_Upstream_Group, p.zabel, jason-jh.lin,
linux-mediatek
On Mon, 11 Apr 2022 11:58:41 +0800, Rex-BC Chen wrote:
> The driver data of MT8183 and MT8173 are different.
>
> For MT8173, the gamma module is inside disp_aal. When we need to adjust
> gamma value, we need to use "has_gamma" to control gamma function
> inside disp_aal to adjust the gamma value.
>
> For successors like MT8183, disp_gamma is separated from disp_aal. We
> just need to control disp_gamma directly and don't need to control gamma
> function inside disp_aal.
>
> With this modification, the driver doesn't require any functional changes.
> We only update the dt-binding and DTS node to make it clear.
>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183
2022-04-13 23:02 ` Rob Herring
@ 2022-04-16 14:20 ` Chun-Kuang Hu
0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2022-04-16 14:20 UTC (permalink / raw)
To: Rob Herring
Cc: Rex-BC Chen, Matthias Brugger, Yongqiang Niu, allen-kh.cheng,
linux-kernel, krzk+dt, David Airlie, DTML, Nancy Lin,
Rob Herring, DRI Development, Linux ARM, Chun-Kuang Hu,
Project_Global_Chrome_Upstream_Group, Philipp Zabel,
Jason-JH Lin, moderated list:ARM/Mediatek SoC support
Rob Herring <robh@kernel.org> 於 2022年4月14日 週四 上午7:02寫道:
>
> On Mon, 11 Apr 2022 11:58:41 +0800, Rex-BC Chen wrote:
> > The driver data of MT8183 and MT8173 are different.
> >
> > For MT8173, the gamma module is inside disp_aal. When we need to adjust
> > gamma value, we need to use "has_gamma" to control gamma function
> > inside disp_aal to adjust the gamma value.
> >
> > For successors like MT8183, disp_gamma is separated from disp_aal. We
> > just need to control disp_gamma directly and don't need to control gamma
> > function inside disp_aal.
> >
> > With this modification, the driver doesn't require any functional changes.
> > We only update the dt-binding and DTS node to make it clear.
> >
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2 2/3] arm64: dts: mt8183: Update disp_aal node compatible
2022-04-11 3:58 [PATCH V2 0/3] Update MediaTek disp_aal dt-binding Rex-BC Chen
2022-04-11 3:58 ` [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183 Rex-BC Chen
@ 2022-04-11 3:58 ` Rex-BC Chen
2022-04-22 14:19 ` Matthias Brugger
2022-04-11 3:58 ` [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195 Rex-BC Chen
2 siblings, 1 reply; 9+ messages in thread
From: Rex-BC Chen @ 2022-04-11 3:58 UTC (permalink / raw)
To: chunkuang.hu, robh+dt, krzk+dt, matthias.bgg
Cc: p.zabel, airlied, yongqiang.niu, jason-jh.lin, nancy.lin,
allen-kh.cheng, dri-devel, linux-mediatek, devicetree,
linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Rex-BC Chen
The driver data of MT8183 and MT8173 are different.
The value of has_gamma for MT8173 is true while the value of MT8183 is
false. Therefore, the compatible of disp_aal for MT8183 is not suitable
for the compatible for MT8173.
Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 4b08691ed39e..a3616005d65c 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1466,8 +1466,7 @@
};
aal0: aal@14010000 {
- compatible = "mediatek,mt8183-disp-aal",
- "mediatek,mt8173-disp-aal";
+ compatible = "mediatek,mt8183-disp-aal";
reg = <0 0x14010000 0 0x1000>;
interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_LOW>;
power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
--
2.18.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH V2 2/3] arm64: dts: mt8183: Update disp_aal node compatible
2022-04-11 3:58 ` [PATCH V2 2/3] arm64: dts: mt8183: Update disp_aal node compatible Rex-BC Chen
@ 2022-04-22 14:19 ` Matthias Brugger
0 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2022-04-22 14:19 UTC (permalink / raw)
To: Rex-BC Chen, chunkuang.hu, robh+dt, krzk+dt
Cc: p.zabel, airlied, yongqiang.niu, jason-jh.lin, nancy.lin,
allen-kh.cheng, dri-devel, linux-mediatek, devicetree,
linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group
On 11/04/2022 05:58, Rex-BC Chen wrote:
> The driver data of MT8183 and MT8173 are different.
> The value of has_gamma for MT8173 is true while the value of MT8183 is
> false. Therefore, the compatible of disp_aal for MT8183 is not suitable
> for the compatible for MT8173.
>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Applied thanks!
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 4b08691ed39e..a3616005d65c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1466,8 +1466,7 @@
> };
>
> aal0: aal@14010000 {
> - compatible = "mediatek,mt8183-disp-aal",
> - "mediatek,mt8173-disp-aal";
> + compatible = "mediatek,mt8183-disp-aal";
> reg = <0 0x14010000 0 0x1000>;
> interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_LOW>;
> power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195
2022-04-11 3:58 [PATCH V2 0/3] Update MediaTek disp_aal dt-binding Rex-BC Chen
2022-04-11 3:58 ` [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183 Rex-BC Chen
2022-04-11 3:58 ` [PATCH V2 2/3] arm64: dts: mt8183: Update disp_aal node compatible Rex-BC Chen
@ 2022-04-11 3:58 ` Rex-BC Chen
2022-04-13 23:02 ` Rob Herring
2 siblings, 1 reply; 9+ messages in thread
From: Rex-BC Chen @ 2022-04-11 3:58 UTC (permalink / raw)
To: chunkuang.hu, robh+dt, krzk+dt, matthias.bgg
Cc: p.zabel, airlied, yongqiang.niu, jason-jh.lin, nancy.lin,
allen-kh.cheng, dri-devel, linux-mediatek, devicetree,
linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Rex-BC Chen
Disp_aal of MT8192 and MT8195 are fully compatible with disp_aal of
MT8183. Therefore, we move the them to item "mediatek,mt8183-disp-aal".
Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
---
.../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
index f118075e4a89..d4d585485e7b 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
@@ -27,12 +27,12 @@ properties:
- items:
- enum:
- mediatek,mt2712-disp-aal
- - mediatek,mt8192-disp-aal
- - mediatek,mt8195-disp-aal
- const: mediatek,mt8173-disp-aal
- items:
- enum:
- mediatek,mt8186-disp-aal
+ - mediatek,mt8192-disp-aal
+ - mediatek,mt8195-disp-aal
- const: mediatek,mt8183-disp-aal
reg:
--
2.18.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195
2022-04-11 3:58 ` [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195 Rex-BC Chen
@ 2022-04-13 23:02 ` Rob Herring
2022-04-16 14:21 ` Chun-Kuang Hu
0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2022-04-13 23:02 UTC (permalink / raw)
To: Rex-BC Chen
Cc: p.zabel, airlied, yongqiang.niu, nancy.lin, krzk+dt, dri-devel,
robh+dt, jason-jh.lin, Project_Global_Chrome_Upstream_Group,
allen-kh.cheng, chunkuang.hu, linux-mediatek, devicetree,
linux-arm-kernel, matthias.bgg, linux-kernel
On Mon, 11 Apr 2022 11:58:43 +0800, Rex-BC Chen wrote:
> Disp_aal of MT8192 and MT8195 are fully compatible with disp_aal of
> MT8183. Therefore, we move the them to item "mediatek,mt8183-disp-aal".
>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195
2022-04-13 23:02 ` Rob Herring
@ 2022-04-16 14:21 ` Chun-Kuang Hu
0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2022-04-16 14:21 UTC (permalink / raw)
To: Rob Herring
Cc: Rex-BC Chen, Philipp Zabel, David Airlie, Yongqiang Niu,
Nancy Lin, krzk+dt, DRI Development, Rob Herring, Jason-JH Lin,
Project_Global_Chrome_Upstream_Group, allen-kh.cheng,
Chun-Kuang Hu, moderated list:ARM/Mediatek SoC support, DTML,
Linux ARM, Matthias Brugger, linux-kernel
Rob Herring <robh@kernel.org> 於 2022年4月14日 週四 上午7:02寫道:
>
> On Mon, 11 Apr 2022 11:58:43 +0800, Rex-BC Chen wrote:
> > Disp_aal of MT8192 and MT8195 are fully compatible with disp_aal of
> > MT8183. Therefore, we move the them to item "mediatek,mt8183-disp-aal".
> >
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
^ permalink raw reply [flat|nested] 9+ messages in thread