From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexandre Courbot <gnurou@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Andrew Bresticker <abrestic@chromium.org>,
Simon Glass <sjg@chromium.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Kumar Gala <galak@codeaurora.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Dylan Reid <dgreid@chromium.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 01/10] ARM: tegra: Set the sound card model that alsaucm expects
Date: Tue, 3 Feb 2015 14:13:28 +0100 [thread overview]
Message-ID: <CAAObsKCm-9GOvis=MZ-nyA0N+g_ZuWYUfDSdEcVy5p5ykCmkcQ@mail.gmail.com> (raw)
In-Reply-To: <54CFE754.7000500@wwwdotorg.org>
On 2 February 2015 at 22:08, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 01/28/2015 03:50 AM, Tomeu Vizoso wrote:
>>
>> Patches are on its way to add a config file to alsaucm for the Nyan
>> boards. Use the same card ID that alsaucm will expect.
>
>
>> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts
>> b/arch/arm/boot/dts/tegra124-nyan-big.dts
>
>
>> sound {
>> - compatible = "nvidia,tegra-audio-max98090-nyan-big",
>> + compatible = "nvidia,tegra-audio-max98090-nyan",
>> "nvidia,tegra-audio-max98090";
>
>
> I'm not convinced that removing the board-specific compatible value is a
> great idea. What if we find we need to distinguish between different boards
> that use this same binding in the future. That situation is exactly why we
> have board-/SoC-specific values in compatible even if we don't immediately
> use them.
I understand the need of naming each component variant so they can be
distinguished in the future, but in this case it's the exact same hw.
>> - nvidia,model = "Acer Chromebook 13";
>> + nvidia,model = "GoogleNyan";
>
>
> I believe this also technically breaks ABI, since some user-space tools use
> the model to look up saved state. Can we not leave this as is, and just have
> the UCM files know about both names?
Well, "A13" isn't a great card id. Given that there's no users yet, I
would prefer to take this chance to put a sane value in there. Btw,
alsa-lib has now a UCM config for this and it uses the GoogleNyan card
id (has been picked up already by OpenSUSE).
So in this case, I think it would be good to change the card id now
before people start to actually use it.
Regards,
Tomeu
> Aside from that, I think the series looks OK at a quick glance.
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2015-02-03 13:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 10:50 [PATCH v3 00/10] Improvements to Tegra-based Chromebook support Tomeu Vizoso
2015-01-28 10:50 ` [PATCH v3 01/10] ARM: tegra: Set the sound card model that alsaucm expects Tomeu Vizoso
2015-02-02 21:08 ` Stephen Warren
2015-02-03 13:13 ` Tomeu Vizoso [this message]
2015-02-03 16:35 ` Stephen Warren
2015-02-04 9:13 ` Tomeu Vizoso
2015-02-04 16:56 ` Stephen Warren
2015-01-28 10:51 ` [PATCH v3 02/10] ARM: tegra: Move out nyan-generic parts out from the nyan-big DT Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 03/10] drm/panel: add support for Samsung LTN140AT29 panel Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 04/10] ARM: tegra: Add DTS for the nyan-blaze board Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 05/10] ARM: tegra: Add node for trackpad in Nyan boards Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 06/10] ASoC: tegra: Add a control for the headphone switch Tomeu Vizoso
2015-01-28 11:02 ` Mark Brown
2015-01-28 17:46 ` Dylan Reid
2015-01-28 18:24 ` Mark Brown
2015-01-28 10:51 ` [PATCH v3 07/10] ASoC: tegra: add sink for the internal mic to tegra_max98090 Tomeu Vizoso
2015-01-28 17:15 ` Mark Brown
2015-01-28 10:51 ` [PATCH v3 08/10] ARM: tegra: Use pwrseq-simple for the wifi in Nyan Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 09/10] ARM: tegra: Use the generated pinmux data Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 10/10] ARM: tegra: Set spi-max-frequency property to flash node Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAObsKCm-9GOvis=MZ-nyA0N+g_ZuWYUfDSdEcVy5p5ykCmkcQ@mail.gmail.com' \
--to=tomeu.vizoso@collabora.com \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@chromium.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sjg@chromium.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).