linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/1] mmc: dw_mmc: hi3798cv200: add MMC_CAP_CMD23 cap
@ 2018-08-20 13:04 Igor Opaniuk
  2018-08-20 14:21 ` Shawn Guo
  2018-08-22  9:48 ` Ulf Hansson
  0 siblings, 2 replies; 3+ messages in thread
From: Igor Opaniuk @ 2018-08-20 13:04 UTC (permalink / raw)
  To: linux-mmc
  Cc: Jaehoon Chung, Ulf Hansson, Shawn Guo, tianshuliang, linux-kernel

Enable access to the RPMB on the on-board eMMC of the
Poplar board.

Signed-off-by: Igor Opaniuk <igor.opaniuk@linaro.org>
---

v2:
- as there are three dwmmc blocks integrated on Hi3798CV200 SoC with
identical CMD23 support, provide MMC_CAP_CMD23 capability instead of 0 for 
the third block also.

 drivers/mmc/host/dw_mmc-hi3798cv200.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
index f9b333f..bc51cef 100644
--- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
+++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
@@ -23,6 +23,12 @@ struct hi3798cv200_priv {
 	struct clk *drive_clk;
 };
 
+static unsigned long dw_mci_hi3798cv200_caps[] = {
+	MMC_CAP_CMD23,
+	MMC_CAP_CMD23,
+	MMC_CAP_CMD23
+};
+
 static void dw_mci_hi3798cv200_set_ios(struct dw_mci *host, struct mmc_ios *ios)
 {
 	struct hi3798cv200_priv *priv = host->priv;
@@ -160,6 +166,8 @@ static int dw_mci_hi3798cv200_init(struct dw_mci *host)
 }
 
 static const struct dw_mci_drv_data hi3798cv200_data = {
+	.caps = dw_mci_hi3798cv200_caps,
+	.num_caps = ARRAY_SIZE(dw_mci_hi3798cv200_caps),
 	.init = dw_mci_hi3798cv200_init,
 	.set_ios = dw_mci_hi3798cv200_set_ios,
 	.execute_tuning = dw_mci_hi3798cv200_execute_tuning,
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] mmc: dw_mmc: hi3798cv200: add MMC_CAP_CMD23 cap
  2018-08-20 13:04 [PATCH v2 1/1] mmc: dw_mmc: hi3798cv200: add MMC_CAP_CMD23 cap Igor Opaniuk
@ 2018-08-20 14:21 ` Shawn Guo
  2018-08-22  9:48 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2018-08-20 14:21 UTC (permalink / raw)
  To: igor.opaniuk
  Cc: linux-mmc, Jaehoon Chung, Ulf Hansson, tianshuliang,
	Linux Kernel Mailing List

On Mon, Aug 20, 2018 at 9:04 PM Igor Opaniuk <igor.opaniuk@linaro.org> wrote:
>
> Enable access to the RPMB on the on-board eMMC of the
> Poplar board.
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@linaro.org>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] mmc: dw_mmc: hi3798cv200: add MMC_CAP_CMD23 cap
  2018-08-20 13:04 [PATCH v2 1/1] mmc: dw_mmc: hi3798cv200: add MMC_CAP_CMD23 cap Igor Opaniuk
  2018-08-20 14:21 ` Shawn Guo
@ 2018-08-22  9:48 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2018-08-22  9:48 UTC (permalink / raw)
  To: Igor Opaniuk
  Cc: linux-mmc, Jaehoon Chung, Shawn Guo, tianshuliang,
	Linux Kernel Mailing List

On 20 August 2018 at 15:04, Igor Opaniuk <igor.opaniuk@linaro.org> wrote:
> Enable access to the RPMB on the on-board eMMC of the
> Poplar board.
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@linaro.org>

Thanks, queued for v.4.20!

Kind regards
Uffe

> ---
>
> v2:
> - as there are three dwmmc blocks integrated on Hi3798CV200 SoC with
> identical CMD23 support, provide MMC_CAP_CMD23 capability instead of 0 for
> the third block also.
>
>  drivers/mmc/host/dw_mmc-hi3798cv200.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> index f9b333f..bc51cef 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> @@ -23,6 +23,12 @@ struct hi3798cv200_priv {
>         struct clk *drive_clk;
>  };
>
> +static unsigned long dw_mci_hi3798cv200_caps[] = {
> +       MMC_CAP_CMD23,
> +       MMC_CAP_CMD23,
> +       MMC_CAP_CMD23
> +};
> +
>  static void dw_mci_hi3798cv200_set_ios(struct dw_mci *host, struct mmc_ios *ios)
>  {
>         struct hi3798cv200_priv *priv = host->priv;
> @@ -160,6 +166,8 @@ static int dw_mci_hi3798cv200_init(struct dw_mci *host)
>  }
>
>  static const struct dw_mci_drv_data hi3798cv200_data = {
> +       .caps = dw_mci_hi3798cv200_caps,
> +       .num_caps = ARRAY_SIZE(dw_mci_hi3798cv200_caps),
>         .init = dw_mci_hi3798cv200_init,
>         .set_ios = dw_mci_hi3798cv200_set_ios,
>         .execute_tuning = dw_mci_hi3798cv200_execute_tuning,
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-22  9:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-20 13:04 [PATCH v2 1/1] mmc: dw_mmc: hi3798cv200: add MMC_CAP_CMD23 cap Igor Opaniuk
2018-08-20 14:21 ` Shawn Guo
2018-08-22  9:48 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).