* [PATCH][V2] mtd: sharpslpart: fix overflow on block_adr calculation
@ 2017-11-08 16:13 Colin King
2017-11-10 16:35 ` Andrea Adami
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-11-08 16:13 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, Andrea Adami, linux-mtd
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Multiplying block_num and mtd->erasesize may potentially overflow
as they are both unsigned ints and so the multiplication is evaluated
in unsigned int arithmetic. Cast block_adr to off_t to ensure
multiplication is off_t sized to avoid any potential overflow.
Detected by CoverityScan, CID#1461264 ("Unintentional integer overflow")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mtd/parsers/sharpslpart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
index 5fe0079ea5ed..0ddb79ac390d 100644
--- a/drivers/mtd/parsers/sharpslpart.c
+++ b/drivers/mtd/parsers/sharpslpart.c
@@ -192,7 +192,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
/* create physical-logical table */
for (block_num = 0; block_num < phymax; block_num++) {
- block_adr = block_num * mtd->erasesize;
+ block_adr = (loff_t)block_num * mtd->erasesize;
if (mtd_block_isbad(mtd, block_adr))
continue;
@@ -244,7 +244,7 @@ static int sharpsl_nand_read_laddr(struct mtd_info *mtd,
return -EINVAL;
block_num = ftl->log2phy[log_num];
- block_adr = block_num * mtd->erasesize;
+ block_adr = (loff_t)block_num * mtd->erasesize;
block_ofs = mtd_mod_by_eb((u32)from, mtd);
err = mtd_read(mtd, block_adr + block_ofs, len, &retlen, buf);
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][V2] mtd: sharpslpart: fix overflow on block_adr calculation
2017-11-08 16:13 [PATCH][V2] mtd: sharpslpart: fix overflow on block_adr calculation Colin King
@ 2017-11-10 16:35 ` Andrea Adami
2017-12-18 16:27 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Andrea Adami @ 2017-11-10 16:35 UTC (permalink / raw)
To: Colin King
Cc: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, linux-mtd, kernel-janitors,
LKML
On Wed, Nov 8, 2017 at 5:13 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Multiplying block_num and mtd->erasesize may potentially overflow
> as they are both unsigned ints and so the multiplication is evaluated
> in unsigned int arithmetic. Cast block_adr to off_t to ensure
> multiplication is off_t sized to avoid any potential overflow.
>
> Detected by CoverityScan, CID#1461264 ("Unintentional integer overflow")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mtd/parsers/sharpslpart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
> index 5fe0079ea5ed..0ddb79ac390d 100644
> --- a/drivers/mtd/parsers/sharpslpart.c
> +++ b/drivers/mtd/parsers/sharpslpart.c
> @@ -192,7 +192,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
>
> /* create physical-logical table */
> for (block_num = 0; block_num < phymax; block_num++) {
> - block_adr = block_num * mtd->erasesize;
> + block_adr = (loff_t)block_num * mtd->erasesize;
>
> if (mtd_block_isbad(mtd, block_adr))
> continue;
> @@ -244,7 +244,7 @@ static int sharpsl_nand_read_laddr(struct mtd_info *mtd,
> return -EINVAL;
>
> block_num = ftl->log2phy[log_num];
> - block_adr = block_num * mtd->erasesize;
> + block_adr = (loff_t)block_num * mtd->erasesize;
> block_ofs = mtd_mod_by_eb((u32)from, mtd);
>
> err = mtd_read(mtd, block_adr + block_ofs, len, &retlen, buf);
> --
> 2.14.1
>
Thanks for spotting this,
Acked-by: Andrea Adami <andrea.adami@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][V2] mtd: sharpslpart: fix overflow on block_adr calculation
2017-11-10 16:35 ` Andrea Adami
@ 2017-12-18 16:27 ` Boris Brezillon
0 siblings, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2017-12-18 16:27 UTC (permalink / raw)
To: Andrea Adami
Cc: Colin King, Richard Weinberger, kernel-janitors, LKML,
Marek Vasut, linux-mtd, Cyrille Pitchen, Brian Norris,
David Woodhouse
On Fri, 10 Nov 2017 17:35:13 +0100
Andrea Adami <andrea.adami@gmail.com> wrote:
> On Wed, Nov 8, 2017 at 5:13 PM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Multiplying block_num and mtd->erasesize may potentially overflow
> > as they are both unsigned ints and so the multiplication is evaluated
> > in unsigned int arithmetic. Cast block_adr to off_t to ensure
> > multiplication is off_t sized to avoid any potential overflow.
> >
> > Detected by CoverityScan, CID#1461264 ("Unintentional integer overflow")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/mtd/parsers/sharpslpart.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
> > index 5fe0079ea5ed..0ddb79ac390d 100644
> > --- a/drivers/mtd/parsers/sharpslpart.c
> > +++ b/drivers/mtd/parsers/sharpslpart.c
> > @@ -192,7 +192,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
> >
> > /* create physical-logical table */
> > for (block_num = 0; block_num < phymax; block_num++) {
> > - block_adr = block_num * mtd->erasesize;
> > + block_adr = (loff_t)block_num * mtd->erasesize;
> >
> > if (mtd_block_isbad(mtd, block_adr))
> > continue;
> > @@ -244,7 +244,7 @@ static int sharpsl_nand_read_laddr(struct mtd_info *mtd,
> > return -EINVAL;
> >
> > block_num = ftl->log2phy[log_num];
> > - block_adr = block_num * mtd->erasesize;
> > + block_adr = (loff_t)block_num * mtd->erasesize;
> > block_ofs = mtd_mod_by_eb((u32)from, mtd);
> >
> > err = mtd_read(mtd, block_adr + block_ofs, len, &retlen, buf);
> > --
> > 2.14.1
> >
>
> Thanks for spotting this,
>
> Acked-by: Andrea Adami <andrea.adami@gmail.com>
Applied.
Thanks,
Boris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-18 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-08 16:13 [PATCH][V2] mtd: sharpslpart: fix overflow on block_adr calculation Colin King
2017-11-10 16:35 ` Andrea Adami
2017-12-18 16:27 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).