Re: [PATCH v2 0/5] Fix some checkpatch issues

Re: [PATCH v2 0/5] Fix some checkpatch issues

[Franziska Näpelt]

Thanks for your feedback :)
Since not all the patches of my first patch series have been applied, I thought I have to submit the whole series again. Submitting a series of 5 patches, where 3 have been already applied of course fails.
So does it mean, if 3 of 5 patches of a series have been applied and I want to submit a new version, I only submit patches for the remaining work and not all of them again?

Thanks, Franziska

Re: [PATCH v2 0/5] Fix some checkpatch issues

[Philipp Hortmann]

On 6/25/23 15:33, Franziska Näpelt wrote:
> Thanks for your feedback :)
> Since not all the patches of my first patch series have been applied, I thought I have to submit the whole series again. Submitting a series of 5 patches, where 3 have been already applied of course fails.
> So does it mean, if 3 of 5 patches of a series have been applied and I want to submit a new version, I only submit patches for the remaining work and not all of them again?
yes
> 
> Thanks, Franziska

Hi Franziska,

please only submit the not applied patches because the others cannot be 
applied anymore.

Thanks

Bye Philipp

Re: [PATCH v2 0/5] Fix some checkpatch issues

[<gregkh@linuxfoundation.org>]

On Sun, Jun 25, 2023 at 03:33:59PM +0200, Franziska Näpelt wrote:
> Thanks for your feedback :)
> Since not all the patches of my first patch series have been applied, I thought I have to submit the whole series again. Submitting a series of 5 patches, where 3 have been already applied of course fails.
> So does it mean, if 3 of 5 patches of a series have been applied and I want to submit a new version, I only submit patches for the remaining work and not all of them again?

Yes, just submit the remaining ones.

thanks,

greg k-h

Re: [PATCH v2 0/5] Fix some checkpatch issues

[Franziska Näpelt]

Am So., 25. Juni 2023 um 15:55 Uhr schrieb
<gregkh@linuxfoundation.org> <gregkh@linuxfoundation.org>:
>
> On Sun, Jun 25, 2023 at 03:33:59PM +0200, Franziska Näpelt wrote:
> > Thanks for your feedback :)
> > Since not all the patches of my first patch series have been applied, I thought I have to submit the whole series again. Submitting a series of 5 patches, where 3 have been already applied of course fails.
> > So does it mean, if 3 of 5 patches of a series have been applied and I want to submit a new version, I only submit patches for the remaining work and not all of them again?
>
> Yes, just submit the remaining ones.
>
> thanks,
>
> greg k-h

Done in v3. Thanks :)
https://lore.kernel.org/linux-staging/CAAUT3iM3k3iVx7UOQ-s9OJ=aVWarAp3rEDNTzSfY-m3yJpGe4Q@mail.gmail.com/T/#t

Re: [PATCH v2 0/5] Fix some checkpatch issues

[Greg KH]

On Fri, Jun 23, 2023 at 07:20:42PM +0200, Philipp Hortmann wrote:
> On 6/23/23 10:18, Greg KH wrote:
> > On Wed, Jun 21, 2023 at 08:46:35PM +0200, Franziska Naepelt wrote:
> > > This is a series of patches to fix some trivial checkpatch issues. Not all
> > > issues have been fixed. I intend to submit another series to fix more stuff.
> > 
> > None of these apply to my staging-next branch :(
> > 
> 
> Hi,
> 
> this is the repo and branch I use:
> 
> git remote show origin
> * remote origin
>   Fetch URL:
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> ...
> git branch -a
> my branch: staging-testing

Please note that this branch will get rebased at times, so be aware of
that and know how to handle it properly.

thanks,

greg k-h

Re: [PATCH v2 0/5] Fix some checkpatch issues

[Philipp Hortmann]

On 6/23/23 10:18, Greg KH wrote:
> On Wed, Jun 21, 2023 at 08:46:35PM +0200, Franziska Naepelt wrote:
>> This is a series of patches to fix some trivial checkpatch issues. Not all
>> issues have been fixed. I intend to submit another series to fix more stuff.
> 
> None of these apply to my staging-next branch :(
>

Hi,

this is the repo and branch I use:

git remote show origin
* remote origin
   Fetch URL: 
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
...
git branch -a
my branch: staging-testing

Bye Philipp

Re: [PATCH v2 0/5] Fix some checkpatch issues

[Greg KH]

On Wed, Jun 21, 2023 at 08:46:35PM +0200, Franziska Naepelt wrote:
> This is a series of patches to fix some trivial checkpatch issues. Not all
> issues have been fixed. I intend to submit another series to fix more stuff.

None of these apply to my staging-next branch :(

[PATCH v2 0/5] Fix some checkpatch issues

[Franziska Naepelt]

This is a series of patches to fix some trivial checkpatch issues. Not all
issues have been fixed. I intend to submit another series to fix more stuff.

Testing:
* Build the kernel with `CONFIG_RTL8723BS=m`
* Boot the kernel with busybox in initramfs
* Load the module
-> No errors or warnings

---
v2: Move blank line change from commit 2 to commit 4

Franziska Naepelt (5):
  staging: rtl8723bs: Fix indentation issues
  staging: rtl8723bs: Fix space issues
  staging: rtl8723bs: Fix block comment issue
  staging: rtl8723bs: Fix blank line issues
  staging: rtl8723bs: Fix alignment open parenthesis

 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 224 +++++++-----------
 1 file changed, 92 insertions(+), 132 deletions(-)


base-commit: 45a3e24f65e90a047bef86f927ebdc4c710edaa1
--
2.39.2 (Apple Git-143)