From: Alexandre Courbot <gnurou@gmail.com>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: max77620: Fix FPS switch statements
Date: Wed, 15 Jun 2016 15:11:13 +0900 [thread overview]
Message-ID: <CAAVeFuKHEtQyX0YYmbGXLX+JFrEu7qrYmwKZ4tEWzu2qMCLxUw@mail.gmail.com> (raw)
In-Reply-To: <8e25e615-e2db-ad9b-2aad-cc44599c58d1@nvidia.com>
On Wed, Jun 15, 2016 at 1:50 AM, Rhyland Klein <rklein@nvidia.com> wrote:
> On 6/7/2016 4:05 AM, Lee Jones wrote:
>> On Thu, 12 May 2016, Rhyland Klein wrote:
>>
>>> When configuring FPS during probe, assuming a DT node is present for
>>> FPS, the code can run into a problem with the switch statements in
>>> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
>>> in the case of chip->chip_id == MAX77620, it will set
>>> fps_[mix|max]_period but then fall through to the default switch case
>>> and return -EINVAL. Returning this from max77620_config_fps() will
>>> cause probe to fail.
>>>
>>> Signed-off-by: Rhyland Klein <rklein@nvidia.com>
>>> ---
>>> drivers/mfd/max77620.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>
>> Applied to -fixes with Thierry and Laxman's Acks.
>>
>
> I don't see this in linux-next yet (as of 20160614). Can we get this
> merged there to.
Was about to say the same thing. FWIW:
Tested-by: Alexandre Courbot <acourbot@nvidia.com>
prev parent reply other threads:[~2016-06-15 6:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 17:45 [PATCH] mfd: max77620: Fix FPS switch statements Rhyland Klein
2016-05-12 17:52 ` Laxman Dewangan
2016-05-27 20:31 ` Rhyland Klein
2016-05-31 7:30 ` Lee Jones
2016-06-01 15:29 ` Rhyland Klein
2016-06-06 15:32 ` Thierry Reding
2016-06-07 8:05 ` Lee Jones
2016-06-14 16:50 ` Rhyland Klein
2016-06-15 6:11 ` Alexandre Courbot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAVeFuKHEtQyX0YYmbGXLX+JFrEu7qrYmwKZ4tEWzu2qMCLxUw@mail.gmail.com \
--to=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).