[PATCH 3.7.0 1/9] i82975x_edac.c: fix style errors

[PATCH 3.7.0 1/9] i82975x_edac.c: fix style errors

[Arvind R]

Subject: [PATCH 3.7.0 1/9] i82975x_edac.c: fix style errors

splits or shortens extra long lines in source.
Signed-off-by: Arvind R. <arvino55@gmail.com>
---
 i82975x_edac.c |   15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

--- a/drivers/edac/i82975x_edac.c	2012-12-11 09:00:57 +0530
+++ b/drivers/edac/i82975x_edac.c	2012-12-15 16:01:29 +0530
@@ -48,7 +48,7 @@
 #define I82975X_DES		0x5d	/* Dram ERRor DeSTination (8b)
 					 * 0h:    Processor Memory Reads
 					 * 1h:7h  reserved
-					 * More - See Page 65 of Intel DocSheet.
+					 * More - See Pg.65 of Intel DocSheet.
 					 */

 #define I82975X_ERRSTS		0xc8	/* Error Status Register (16b)
@@ -98,7 +98,7 @@ NOTE: Only ONE of the three must be enab
 #define I82975X_XEAP	0xfc	/* Extended Dram Error Address Pointer (8b)
 					 *
 					 * 7:1   reserved
-					 * 0     Bit32 of the Dram Error Address
+					 * 0     Bit32 of Dram Error Address
 					 */

 #define I82975X_MCHBAR		0x44	/*
@@ -305,13 +305,13 @@ static int i82975x_process_error_info(st
 			"\tXEAP=%u\n"
 			"\t EAP=0x%08x\n"
 			"\tPAGE=0x%08x\n",
-			(info->xeap & 1) ? 1 : 0, info->eap, (unsigned int) page);
+			(info->xeap & 1) ? 1 : 0, info->eap, (unsigned) page);
 		return 0;
 	}
 	chan = (mci->csrows[row]->nr_channels == 1) ? 0 : info->eap & 1;
 	offst = info->eap
 			& ((1 << PAGE_SHIFT) -
-			   (1 << mci->csrows[row]->channels[chan]->dimm->grain));
+			(1 << mci->csrows[row]->channels[chan]->dimm->grain));

 	if (info->errsts & 0x0002)
 		edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci, 1,
@@ -420,12 +420,13 @@ static void i82975x_init_csrows(struct m

 			dimm->nr_pages = nr_pages / csrow->nr_channels;

-			snprintf(csrow->channels[chan]->dimm->label, EDAC_MC_LABEL_LEN, "DIMM %c%d",
+			snprintf(csrow->channels[chan]->dimm->label,
+				 EDAC_MC_LABEL_LEN, "DIMM %c%d",
 				 (chan == 0) ? 'A' : 'B',
 				 index);
-			dimm->grain = 1 << 7;	/* 128Byte cache-line resolution */
+			dimm->grain = 1 << 7;	/* always */
 			dimm->dtype = i82975x_dram_type(mch_window, index);
-			dimm->mtype = MEM_DDR2; /* I82975x supports only DDR2 */
+			dimm->mtype = MEM_DDR2; /* only supported */
 			dimm->edac_mode = EDAC_SECDED; /* only supported */
 		}

Re: [PATCH 3.7.0 1/9] i82975x_edac.c: fix style errors

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

Hi Arvind,

On Sun, 16 Dec 2012 02:08:50 +0530 Arvind R <arvino55@gmail.com> wrote:
>
> Subject: [PATCH 3.7.0 1/9] i82975x_edac.c: fix style errors
> 
> splits or shortens extra long lines in source.

Don't do this, except for the one marked below, these add no value.  The
line length is a guide.

> -			snprintf(csrow->channels[chan]->dimm->label, EDAC_MC_LABEL_LEN, "DIMM %c%d",
> +			snprintf(csrow->channels[chan]->dimm->label,
> +				 EDAC_MC_LABEL_LEN, "DIMM %c%d",

Only keep this one.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]