* [PATCH 3.7.0 2/9] i82975x_edac.c: fix layers initialisation
@ 2012-12-15 20:39 Arvind R
2012-12-17 11:39 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Arvind R @ 2012-12-15 20:39 UTC (permalink / raw)
To: linux-edac, LKML, linux-next
Subject: [PATCH 3.7.0 2/9] i82975x_edac.c: fix layers initialisation
correct the absolutely wrong initialisation of memory layout.
Signed-off-by: Arvind R. <arvino55@gmail.com>
---
i82975x_edac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/edac/i82975x_edac.c 2012-12-15 16:17:28 +0530
+++ b/drivers/edac/i82975x_edac.c 2012-12-15 16:16:51 +0530
@@ -544,10 +544,10 @@ static int i82975x_probe1(struct pci_dev
/* assuming only one controller, index thus is 0 */
layers[0].type = EDAC_MC_LAYER_CHIP_SELECT;
- layers[0].size = I82975X_NR_DIMMS;
+ layers[0].size = I82975X_NR_CSROWS(chans);
layers[0].is_virt_csrow = true;
layers[1].type = EDAC_MC_LAYER_CHANNEL;
- layers[1].size = I82975X_NR_CSROWS(chans);
+ layers[1].size = chans;
layers[1].is_virt_csrow = false;
mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, sizeof(*pvt));
if (!mci) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3.7.0 2/9] i82975x_edac.c: fix layers initialisation
2012-12-15 20:39 [PATCH 3.7.0 2/9] i82975x_edac.c: fix layers initialisation Arvind R
@ 2012-12-17 11:39 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2012-12-17 11:39 UTC (permalink / raw)
To: Arvind R; +Cc: linux-edac, LKML, linux-next
Hi Arvin,
Em Sun, 16 Dec 2012 02:09:46 +0530
Arvind R <arvino55@gmail.com> escreveu:
> Subject: [PATCH 3.7.0 2/9] i82975x_edac.c: fix layers initialisation
>
> correct the absolutely wrong initialisation of memory layout.
> Signed-off-by: Arvind R. <arvino55@gmail.com>
This patch looks ok for me.
I didn't have time yet to test this patch series. My plan is to test it
after the merge window, likely in the beginning of January.
If you prefer, I can then merge this changeset (after being fixed with
the relevant comments that developers may point to you) on my linux-edac
tree, with my tested-by.
Regards,
Mauro
> ---
> i82975x_edac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/edac/i82975x_edac.c 2012-12-15 16:17:28 +0530
> +++ b/drivers/edac/i82975x_edac.c 2012-12-15 16:16:51 +0530
> @@ -544,10 +544,10 @@ static int i82975x_probe1(struct pci_dev
>
> /* assuming only one controller, index thus is 0 */
> layers[0].type = EDAC_MC_LAYER_CHIP_SELECT;
> - layers[0].size = I82975X_NR_DIMMS;
> + layers[0].size = I82975X_NR_CSROWS(chans);
> layers[0].is_virt_csrow = true;
> layers[1].type = EDAC_MC_LAYER_CHANNEL;
> - layers[1].size = I82975X_NR_CSROWS(chans);
> + layers[1].size = chans;
> layers[1].is_virt_csrow = false;
> mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, sizeof(*pvt));
> if (!mci) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-17 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-15 20:39 [PATCH 3.7.0 2/9] i82975x_edac.c: fix layers initialisation Arvind R
2012-12-17 11:39 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).