From: Andrey Konovalov <andreyknvl@google.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Andrew Morton <akpm@linux-foundation.org>,
USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
"kernelci . org bot" <bot@kernelci.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH USB] usb: raw_gadget: fix compilation warnings in uapi headers
Date: Thu, 19 Mar 2020 23:13:19 +0100 [thread overview]
Message-ID: <CAAeHK+xtO_A7WGFxYiJ9P9+_6B7r2E6MCoq+EhsBe0dDj=r2WQ@mail.gmail.com> (raw)
In-Reply-To: <6206b80b3810f95bfe1d452de45596609a07b6ea.1584456779.git.andreyknvl@google.com>
On Thu, Mar 19, 2020 at 11:11 PM Andrey Konovalov <andreyknvl@google.com> wrote:
>
> Mark usb_raw_io_flags_valid() and usb_raw_io_flags_zero() as inline to
> fix the following warnings:
>
> ./usr/include/linux/usb/raw_gadget.h:69:12: warning: unused function 'usb_raw_io_flags_valid' [-Wunused-function]
> ./usr/include/linux/usb/raw_gadget.h:74:12: warning: unused function 'usb_raw_io_flags_zero' [-Wunused-function]
>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> ---
> include/uapi/linux/usb/raw_gadget.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/usb/raw_gadget.h b/include/uapi/linux/usb/raw_gadget.h
> index 00cbded71061..ea375082b3ac 100644
> --- a/include/uapi/linux/usb/raw_gadget.h
> +++ b/include/uapi/linux/usb/raw_gadget.h
> @@ -66,12 +66,12 @@ struct usb_raw_event {
> #define USB_RAW_IO_FLAGS_ZERO 0x0001
> #define USB_RAW_IO_FLAGS_MASK 0x0001
>
> -static int usb_raw_io_flags_valid(__u16 flags)
> +static inline int usb_raw_io_flags_valid(__u16 flags)
> {
> return (flags & ~USB_RAW_IO_FLAGS_MASK) == 0;
> }
>
> -static int usb_raw_io_flags_zero(__u16 flags)
> +static inline int usb_raw_io_flags_zero(__u16 flags)
> {
> return (flags & USB_RAW_IO_FLAGS_ZERO);
> }
> --
> 2.25.1.481.gfbce0eb801-goog
>
(Sorry, accidental resend, please ignore.)
next prev parent reply other threads:[~2020-03-19 22:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 22:11 [PATCH v3 0/7] kcov: collect coverage from usb soft interrupts Andrey Konovalov
2020-03-17 14:54 ` [PATCH USB] usb: raw_gadget: fix compilation warnings in uapi headers Andrey Konovalov
2020-03-19 22:11 ` Andrey Konovalov
2020-03-19 22:13 ` Andrey Konovalov [this message]
2020-03-19 22:11 ` [PATCH v3 1/7] kcov: cleanup debug messages Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 2/7] kcov: fix potential use-after-free in kcov_remote_start Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 3/7] kcov: move t->kcov assignments into kcov_start/stop Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 4/7] kcov: move t->kcov_sequence assignment Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 5/7] kcov: use t->kcov_mode as enabled indicator Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 6/7] kcov: collect coverage from interrupts Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 7/7] usb: core: kcov: collect coverage from usb complete callback Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeHK+xtO_A7WGFxYiJ9P9+_6B7r2E6MCoq+EhsBe0dDj=r2WQ@mail.gmail.com' \
--to=andreyknvl@google.com \
--cc=akpm@linux-foundation.org \
--cc=bot@kernelci.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).