From: Andrey Konovalov <andreyknvl@google.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Andrey Konovalov <andreyknvl@google.com>
Subject: [PATCH v3 4/7] kcov: move t->kcov_sequence assignment
Date: Thu, 19 Mar 2020 23:11:38 +0100 [thread overview]
Message-ID: <f0283c676bab3335cb48bfe12d375a3da4719f59.1584655448.git.andreyknvl@google.com> (raw)
In-Reply-To: <cover.1584655448.git.andreyknvl@google.com>
From: Andrey Konovalov <andreyknvl@gmail.com>
Move t->kcov_sequence assignment before assigning t->kcov_mode
for consistency.
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
kernel/kcov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kcov.c b/kernel/kcov.c
index 888d0a236b04..b985b7a72870 100644
--- a/kernel/kcov.c
+++ b/kernel/kcov.c
@@ -318,10 +318,10 @@ static void kcov_start(struct task_struct *t, struct kcov *kcov,
/* Cache in task struct for performance. */
t->kcov_size = size;
t->kcov_area = area;
+ t->kcov_sequence = sequence;
/* See comment in check_kcov_mode(). */
barrier();
WRITE_ONCE(t->kcov_mode, mode);
- t->kcov_sequence = sequence;
}
static void kcov_stop(struct task_struct *t)
--
2.25.1.696.g5e7596f4ac-goog
next prev parent reply other threads:[~2020-03-19 22:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 22:11 [PATCH v3 0/7] kcov: collect coverage from usb soft interrupts Andrey Konovalov
2020-03-17 14:54 ` [PATCH USB] usb: raw_gadget: fix compilation warnings in uapi headers Andrey Konovalov
2020-03-19 22:11 ` Andrey Konovalov
2020-03-19 22:13 ` Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 1/7] kcov: cleanup debug messages Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 2/7] kcov: fix potential use-after-free in kcov_remote_start Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 3/7] kcov: move t->kcov assignments into kcov_start/stop Andrey Konovalov
2020-03-19 22:11 ` Andrey Konovalov [this message]
2020-03-19 22:11 ` [PATCH v3 5/7] kcov: use t->kcov_mode as enabled indicator Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 6/7] kcov: collect coverage from interrupts Andrey Konovalov
2020-03-19 22:11 ` [PATCH v3 7/7] usb: core: kcov: collect coverage from usb complete callback Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0283c676bab3335cb48bfe12d375a3da4719f59.1584655448.git.andreyknvl@google.com \
--to=andreyknvl@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).