From: Chunyan Zhang <zhang.lyra@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
Baolin Wang <baolin.wang7@gmail.com>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
Date: Sat, 8 Oct 2022 10:57:35 +0800 [thread overview]
Message-ID: <CAAfSe-u4y84kjjksv-Y7=zyosV=34M-=_wrDQC9884znvx9V4Q@mail.gmail.com> (raw)
In-Reply-To: <727a540d-0ca9-ade3-894d-f1774d10a681@linaro.org>
On Fri, 30 Sept 2022 at 19:09, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 30/09/2022 10:24, Chunyan Zhang wrote:
> > From: Chunyan Zhang <chunyan.zhang@unisoc.com>
> >
> > Convert the Unisoc EIC controller binding to DT schema format.
> > Update the maxItems of 'reg' property, since the current gpio-eic-sprd
> > driver supports 3 reg items. Also remove three redundant examples.
> >
> > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > ---
> > .../bindings/gpio/gpio-eic-sprd.txt | 97 --------------
> > .../bindings/gpio/sprd,gpio-eic.yaml | 119 ++++++++++++++++++
> > 2 files changed, 119 insertions(+), 97 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
> > create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
[snip]
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + eic_debounce: gpio@40210000 {
> > + compatible = "sprd,sc9860-eic-debounce";
> > + reg = <0 0x40210000 0 0x80>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + interrupt-controller;
> > + #interrupt-cells = <2>;
> > + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> > + };
> > + };
> > +
> > + sc2730_pmic {
>
> If you insisted to keep it, at least should be correct, so just pmic.
>
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pmic_eic: gpio@300 {
>
> It's exactly the same example as above - all same properties. Drop it or
> bring some differences.
The differences are on #address-cells and #size-cells.
Thanks for the review,
Chunyan
next prev parent reply other threads:[~2022-10-08 2:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 8:24 [PATCH V2 0/3] Convert Unisoc GPIO bindings to yaml and add support for UMS512 Chunyan Zhang
2022-09-30 8:24 ` [PATCH V2 1/3] dt-bindings: gpio: Convert Unisoc GPIO controller binding to yaml Chunyan Zhang
2022-09-30 11:07 ` Krzysztof Kozlowski
2022-09-30 8:24 ` [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC " Chunyan Zhang
2022-09-30 11:09 ` Krzysztof Kozlowski
2022-10-08 2:57 ` Chunyan Zhang [this message]
2022-10-09 15:14 ` Krzysztof Kozlowski
2022-10-10 1:52 ` Chunyan Zhang
2022-09-30 21:41 ` Rob Herring
2022-09-30 8:24 ` [PATCH V2 3/3] dt-bindings: gpio: Add compatible string to support Unisoc UMS512 Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAfSe-u4y84kjjksv-Y7=zyosV=34M-=_wrDQC9884znvx9V4Q@mail.gmail.com' \
--to=zhang.lyra@gmail.com \
--cc=baolin.wang7@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=chunyan.zhang@unisoc.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).