From: Chunyan Zhang <zhang.lyra@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
Baolin Wang <baolin.wang7@gmail.com>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
Date: Mon, 10 Oct 2022 09:52:11 +0800 [thread overview]
Message-ID: <CAAfSe-vQ3Vhjpp9kwRxmha1WR=kfW08BmuYEW+r1POBD1oFqnQ@mail.gmail.com> (raw)
In-Reply-To: <e0d69843-4b37-2e0d-66c7-fc8fd09ed385@linaro.org>
On Sun, 9 Oct 2022 at 23:17, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 08/10/2022 04:57, Chunyan Zhang wrote:
> >>> + eic_debounce: gpio@40210000 {
> >>> + compatible = "sprd,sc9860-eic-debounce";
> >>> + reg = <0 0x40210000 0 0x80>;
> >>> + gpio-controller;
> >>> + #gpio-cells = <2>;
> >>> + interrupt-controller;
> >>> + #interrupt-cells = <2>;
> >>> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> >>> + };
> >>> + };
> >>> +
> >>> + sc2730_pmic {
> >>
> >> If you insisted to keep it, at least should be correct, so just pmic.
> >>
> >>> + #address-cells = <1>;
> >>> + #size-cells = <0>;
> >>> +
> >>> + pmic_eic: gpio@300 {
> >>
> >> It's exactly the same example as above - all same properties. Drop it or
> >> bring some differences.
> >
> > The differences are on #address-cells and #size-cells.
> >
>
> Which don't really matter...
Alright, will drop it in the next version.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-10-10 1:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 8:24 [PATCH V2 0/3] Convert Unisoc GPIO bindings to yaml and add support for UMS512 Chunyan Zhang
2022-09-30 8:24 ` [PATCH V2 1/3] dt-bindings: gpio: Convert Unisoc GPIO controller binding to yaml Chunyan Zhang
2022-09-30 11:07 ` Krzysztof Kozlowski
2022-09-30 8:24 ` [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC " Chunyan Zhang
2022-09-30 11:09 ` Krzysztof Kozlowski
2022-10-08 2:57 ` Chunyan Zhang
2022-10-09 15:14 ` Krzysztof Kozlowski
2022-10-10 1:52 ` Chunyan Zhang [this message]
2022-09-30 21:41 ` Rob Herring
2022-09-30 8:24 ` [PATCH V2 3/3] dt-bindings: gpio: Add compatible string to support Unisoc UMS512 Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAfSe-vQ3Vhjpp9kwRxmha1WR=kfW08BmuYEW+r1POBD1oFqnQ@mail.gmail.com' \
--to=zhang.lyra@gmail.com \
--cc=baolin.wang7@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=chunyan.zhang@unisoc.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).