From: Anup Patel <anup@brainfault.org>
To: Vineet Gupta <vgupta@kernel.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Anup Patel <anup.patel@wdc.com>,
Jisheng Zhang <jszhang@kernel.org>,
Guo Ren <guoren@linux.alibaba.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: mm: don't advertise 1 num_asid for 0 asid bits
Date: Wed, 8 Sep 2021 14:05:18 +0530 [thread overview]
Message-ID: <CAAhSdy018QJ2hdqL2BSZXV81-CVbTf_g6chJSHM4UH2EhLUpCA@mail.gmail.com> (raw)
In-Reply-To: <20210907200254.467375-1-vgupta@kernel.org>
On Wed, Sep 8, 2021 at 1:33 AM Vineet Gupta <vgupta@kernel.org> wrote:
>
> Even if mmu doesn't support ASID, current code calculates @num_asids=1
> which is misleading, so avoid setting any asid related variables in such
> a case.
>
> Also while here, print the number of asid bits discovered even for the
> disabled case.
>
> Verified this on Hifive Unmatched.
>
> Signed-off-by: Vineet Gupta <vgupta@kernel.org>
> ---
> arch/riscv/mm/context.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c
> index ee3459cb6750..c8c6f8831a3b 100644
> --- a/arch/riscv/mm/context.c
> +++ b/arch/riscv/mm/context.c
> @@ -233,8 +233,10 @@ static int __init asids_init(void)
> local_flush_tlb_all();
>
> /* Pre-compute ASID details */
> - num_asids = 1 << asid_bits;
> - asid_mask = num_asids - 1;
> + if (asid_bits) {
> + num_asids = 1 << asid_bits;
> + asid_mask = num_asids - 1;
> + }
>
> /*
> * Use ASID allocator only if number of HW ASIDs are
> @@ -255,7 +257,7 @@ static int __init asids_init(void)
> pr_info("ASID allocator using %lu bits (%lu entries)\n",
> asid_bits, num_asids);
> } else {
> - pr_info("ASID allocator disabled\n");
> + pr_info("ASID allocator disabled: %lu bits\n", asid_bits);
May be use:
pr_info("ASID allocator disabled (%lu bits)\n", asid_bits);
for consistency with the ASID enabled case.
Otherwise, it looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
> }
>
> return 0;
> --
> 2.30.2
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Regards,
Anup
next prev parent reply other threads:[~2021-09-08 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 20:02 [PATCH] riscv: mm: don't advertise 1 num_asid for 0 asid bits Vineet Gupta
2021-09-08 8:35 ` Anup Patel [this message]
2021-09-08 17:30 ` [PATCH v2] " Vineet Gupta
2021-10-03 17:10 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy018QJ2hdqL2BSZXV81-CVbTf_g6chJSHM4UH2EhLUpCA@mail.gmail.com \
--to=anup@brainfault.org \
--cc=anup.patel@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=guoren@linux.alibaba.com \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=vgupta@kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).