* [PATCH v4 0/2] dt-bindings: timer: sifive, clint: Miscellaneous improvements
@ 2022-01-28 9:07 Geert Uytterhoeven
2022-01-28 9:07 ` [PATCH v4 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-01-28 9:07 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Palmer Dabbelt, Paul Walmsley,
Anup Patel
Cc: Rob Herring, linux-kernel, devicetree, linux-riscv, Geert Uytterhoeven
Hi all,
This patch series contains two improvements for the SiFive CLINT DT
bindings.
Changes compared to v3[1]:
- Use architectural maximum instead of practical maximum of 10,
- Add Reviewed-by (this time for real ;-).
Changes compared to v2[2]:
- Add Acked-by, Reviewed-by.
Changes compared to v1[3]:
- Split in two patches,
- Improve patch description and document limit rationale.
Thanks!
[1] https://lore.kernel.org/r/cover.1639744468.git.geert@linux-m68k.org/
[2] https://lore.kernel.org/r/cover.1639662093.git.geert@linux-m68k.org
[3] https://lore.kernel.org/r/20211125152317.162958-1-geert@linux-m68k.org
Geert Uytterhoeven (2):
dt-bindings: timer: sifive,clint: Fix number of interrupts
dt-bindings: timer: sifive,clint: Group interrupt tuples
.../devicetree/bindings/timer/sifive,clint.yaml | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--
2.25.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts
2022-01-28 9:07 [PATCH v4 0/2] dt-bindings: timer: sifive, clint: Miscellaneous improvements Geert Uytterhoeven
@ 2022-01-28 9:07 ` Geert Uytterhoeven
2022-01-28 13:16 ` [PATCH v4 1/2] dt-bindings: timer: sifive, clint: " Anup Patel
2022-01-28 17:55 ` Conor Dooley
2022-01-28 9:07 ` [PATCH v4 2/2] dt-bindings: timer: sifive,clint: Group interrupt tuples Geert Uytterhoeven
2022-02-28 19:57 ` [PATCH v4 0/2] dt-bindings: timer: sifive, clint: Miscellaneous improvements Rob Herring
2 siblings, 2 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-01-28 9:07 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Palmer Dabbelt, Paul Walmsley,
Anup Patel
Cc: Rob Herring, linux-kernel, devicetree, linux-riscv,
Geert Uytterhoeven, Rob Herring
The number of interrupts lacks an upper bound, thus assuming one,
causing properly grouped "interrupts-extended" properties to be flagged
as an error by "make dtbs_check".
Fix this by adding the missing "maxItems", using the architectural
maximum of 4095 interrupts.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Rob Herring <robh@kernel.org>
---
v4:
- Use architectural maximum instead of practical maximum of 10,
v3:
- Add Acked-by,
v2:
- Split in two patches,
- Improve patch description and document limit rationale.
---
Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
index 8d5f4687add9e81e..fe4b73c3f269fc0f 100644
--- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
+++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
@@ -44,6 +44,7 @@ properties:
interrupts-extended:
minItems: 1
+ maxItems: 4095
additionalProperties: false
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v4 2/2] dt-bindings: timer: sifive,clint: Group interrupt tuples
2022-01-28 9:07 [PATCH v4 0/2] dt-bindings: timer: sifive, clint: Miscellaneous improvements Geert Uytterhoeven
2022-01-28 9:07 ` [PATCH v4 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts Geert Uytterhoeven
@ 2022-01-28 9:07 ` Geert Uytterhoeven
2022-01-28 13:17 ` [PATCH v4 2/2] dt-bindings: timer: sifive, clint: " Anup Patel
2022-02-28 19:57 ` [PATCH v4 0/2] dt-bindings: timer: sifive, clint: Miscellaneous improvements Rob Herring
2 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-01-28 9:07 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Palmer Dabbelt, Paul Walmsley,
Anup Patel
Cc: Rob Herring, linux-kernel, devicetree, linux-riscv,
Geert Uytterhoeven, Rob Herring
To improve human readability and enable automatic validation, the tuples
in "interrupts-extended" properties should be grouped using angle
brackets.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
v4:
- Add Reviewed-by (this time for real ;-),
v3:
- Add Reviewed-by,
v2:
- Split in two patches.
---
Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
index fe4b73c3f269fc0f..e64f46339079fa3f 100644
--- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
+++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
@@ -57,10 +57,10 @@ examples:
- |
timer@2000000 {
compatible = "sifive,fu540-c000-clint", "sifive,clint0";
- interrupts-extended = <&cpu1intc 3 &cpu1intc 7
- &cpu2intc 3 &cpu2intc 7
- &cpu3intc 3 &cpu3intc 7
- &cpu4intc 3 &cpu4intc 7>;
+ interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>,
+ <&cpu2intc 3>, <&cpu2intc 7>,
+ <&cpu3intc 3>, <&cpu3intc 7>,
+ <&cpu4intc 3>, <&cpu4intc 7>;
reg = <0x2000000 0x10000>;
};
...
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: timer: sifive, clint: Fix number of interrupts
2022-01-28 9:07 ` [PATCH v4 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts Geert Uytterhoeven
@ 2022-01-28 13:16 ` Anup Patel
2022-01-28 17:55 ` Conor Dooley
1 sibling, 0 replies; 7+ messages in thread
From: Anup Patel @ 2022-01-28 13:16 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Daniel Lezcano, Thomas Gleixner, Palmer Dabbelt, Paul Walmsley,
Anup Patel, Rob Herring, linux-kernel@vger.kernel.org List, DTML,
linux-riscv, Rob Herring
On Fri, Jan 28, 2022 at 2:37 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> The number of interrupts lacks an upper bound, thus assuming one,
> causing properly grouped "interrupts-extended" properties to be flagged
> as an error by "make dtbs_check".
>
> Fix this by adding the missing "maxItems", using the architectural
> maximum of 4095 interrupts.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Rob Herring <robh@kernel.org>
Looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards,
Anup
> ---
> v4:
> - Use architectural maximum instead of practical maximum of 10,
>
> v3:
> - Add Acked-by,
>
> v2:
> - Split in two patches,
> - Improve patch description and document limit rationale.
> ---
> Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> index 8d5f4687add9e81e..fe4b73c3f269fc0f 100644
> --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> @@ -44,6 +44,7 @@ properties:
>
> interrupts-extended:
> minItems: 1
> + maxItems: 4095
>
> additionalProperties: false
>
> --
> 2.25.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: timer: sifive, clint: Group interrupt tuples
2022-01-28 9:07 ` [PATCH v4 2/2] dt-bindings: timer: sifive,clint: Group interrupt tuples Geert Uytterhoeven
@ 2022-01-28 13:17 ` Anup Patel
0 siblings, 0 replies; 7+ messages in thread
From: Anup Patel @ 2022-01-28 13:17 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Daniel Lezcano, Thomas Gleixner, Palmer Dabbelt, Paul Walmsley,
Anup Patel, Rob Herring, linux-kernel@vger.kernel.org List, DTML,
linux-riscv, Rob Herring
On Fri, Jan 28, 2022 at 2:37 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> To improve human readability and enable automatic validation, the tuples
> in "interrupts-extended" properties should be grouped using angle
> brackets.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
Looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards,
Anup
> ---
> v4:
> - Add Reviewed-by (this time for real ;-),
>
> v3:
> - Add Reviewed-by,
>
> v2:
> - Split in two patches.
> ---
> Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> index fe4b73c3f269fc0f..e64f46339079fa3f 100644
> --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> @@ -57,10 +57,10 @@ examples:
> - |
> timer@2000000 {
> compatible = "sifive,fu540-c000-clint", "sifive,clint0";
> - interrupts-extended = <&cpu1intc 3 &cpu1intc 7
> - &cpu2intc 3 &cpu2intc 7
> - &cpu3intc 3 &cpu3intc 7
> - &cpu4intc 3 &cpu4intc 7>;
> + interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>,
> + <&cpu2intc 3>, <&cpu2intc 7>,
> + <&cpu3intc 3>, <&cpu3intc 7>,
> + <&cpu4intc 3>, <&cpu4intc 7>;
> reg = <0x2000000 0x10000>;
> };
> ...
> --
> 2.25.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: timer: sifive, clint: Fix number of interrupts
2022-01-28 9:07 ` [PATCH v4 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts Geert Uytterhoeven
2022-01-28 13:16 ` [PATCH v4 1/2] dt-bindings: timer: sifive, clint: " Anup Patel
@ 2022-01-28 17:55 ` Conor Dooley
1 sibling, 0 replies; 7+ messages in thread
From: Conor Dooley @ 2022-01-28 17:55 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Daniel Lezcano, Thomas Gleixner, Palmer Dabbelt, Paul Walmsley,
Anup Patel, Rob Herring, linux-kernel, devicetree, linux-riscv,
Rob Herring
> The number of interrupts lacks an upper bound, thus assuming one,
> causing properly grouped "interrupts-extended" properties to be flagged
> as an error by "make dtbs_check".
>
> Fix this by adding the missing "maxItems", using the architectural
> maximum of 4095 interrupts.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> v4:
> - Use architectural maximum instead of practical maximum of 10,
>
> v3:
> - Add Acked-by,
>
> v2:
> - Split in two patches,
> - Improve patch description and document limit rationale.
> ---
> Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> index 8d5f4687add9e81e..fe4b73c3f269fc0f 100644
> --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> @@ -44,6 +44,7 @@ properties:
>
> interrupts-extended:
> minItems: 1
> + maxItems: 4095
>
> additionalProperties: false
>
> --
> 2.25.1
Clears errors on the icicle dt, so fwiw: Acked-by: Conor Dooley <conor.dooley@microchip.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 0/2] dt-bindings: timer: sifive, clint: Miscellaneous improvements
2022-01-28 9:07 [PATCH v4 0/2] dt-bindings: timer: sifive, clint: Miscellaneous improvements Geert Uytterhoeven
2022-01-28 9:07 ` [PATCH v4 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts Geert Uytterhoeven
2022-01-28 9:07 ` [PATCH v4 2/2] dt-bindings: timer: sifive,clint: Group interrupt tuples Geert Uytterhoeven
@ 2022-02-28 19:57 ` Rob Herring
2 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-02-28 19:57 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Daniel Lezcano, Thomas Gleixner, Palmer Dabbelt, Paul Walmsley,
Anup Patel, linux-kernel, devicetree, linux-riscv
On Fri, Jan 28, 2022 at 3:07 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi all,
>
> This patch series contains two improvements for the SiFive CLINT DT
> bindings.
>
> Changes compared to v3[1]:
> - Use architectural maximum instead of practical maximum of 10,
> - Add Reviewed-by (this time for real ;-).
>
> Changes compared to v2[2]:
> - Add Acked-by, Reviewed-by.
>
> Changes compared to v1[3]:
> - Split in two patches,
> - Improve patch description and document limit rationale.
>
> Thanks!
>
> [1] https://lore.kernel.org/r/cover.1639744468.git.geert@linux-m68k.org/
> [2] https://lore.kernel.org/r/cover.1639662093.git.geert@linux-m68k.org
> [3] https://lore.kernel.org/r/20211125152317.162958-1-geert@linux-m68k.org
>
> Geert Uytterhoeven (2):
> dt-bindings: timer: sifive,clint: Fix number of interrupts
> dt-bindings: timer: sifive,clint: Group interrupt tuples
>
> .../devicetree/bindings/timer/sifive,clint.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
As these have not been picked up yet, I've applied them.
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-02-28 19:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-28 9:07 [PATCH v4 0/2] dt-bindings: timer: sifive, clint: Miscellaneous improvements Geert Uytterhoeven
2022-01-28 9:07 ` [PATCH v4 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts Geert Uytterhoeven
2022-01-28 13:16 ` [PATCH v4 1/2] dt-bindings: timer: sifive, clint: " Anup Patel
2022-01-28 17:55 ` Conor Dooley
2022-01-28 9:07 ` [PATCH v4 2/2] dt-bindings: timer: sifive,clint: Group interrupt tuples Geert Uytterhoeven
2022-01-28 13:17 ` [PATCH v4 2/2] dt-bindings: timer: sifive, clint: " Anup Patel
2022-02-28 19:57 ` [PATCH v4 0/2] dt-bindings: timer: sifive, clint: Miscellaneous improvements Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).