* [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get
@ 2019-03-14 6:45 Kangjie Lu
2019-03-14 9:08 ` [greybus-dev] " Viresh Kumar
2019-03-15 5:19 ` Vaibhav Agarwal
0 siblings, 2 replies; 4+ messages in thread
From: Kangjie Lu @ 2019-03-14 6:45 UTC (permalink / raw)
To: kjlu
Cc: pakki001, Vaibhav Agarwal, Mark Greer, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel
ida_simple_get could fail. The fix inserts a check for its
return value.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/staging/greybus/audio_manager.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
index d44b070d8862..c2a4af4c1d06 100644
--- a/drivers/staging/greybus/audio_manager.c
+++ b/drivers/staging/greybus/audio_manager.c
@@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc)
int err;
id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
+ if (id < 0)
+ return id;
+
err = gb_audio_manager_module_create(&module, manager_kset,
id, desc);
if (err) {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [greybus-dev] [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get
2019-03-14 6:45 [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get Kangjie Lu
@ 2019-03-14 9:08 ` Viresh Kumar
2019-03-15 5:19 ` Vaibhav Agarwal
1 sibling, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2019-03-14 9:08 UTC (permalink / raw)
To: Kangjie Lu
Cc: devel, Alex Elder, Johan Hovold, greybus-dev, pakki001, linux-kernel
On 14-03-19, 01:45, Kangjie Lu wrote:
> ida_simple_get could fail. The fix inserts a check for its
> return value.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/staging/greybus/audio_manager.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
> index d44b070d8862..c2a4af4c1d06 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc)
> int err;
>
> id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
> + if (id < 0)
> + return id;
> +
> err = gb_audio_manager_module_create(&module, manager_kset,
> id, desc);
> if (err) {
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get
2019-03-14 6:45 [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get Kangjie Lu
2019-03-14 9:08 ` [greybus-dev] " Viresh Kumar
@ 2019-03-15 5:19 ` Vaibhav Agarwal
2019-04-30 15:19 ` Mark Greer
1 sibling, 1 reply; 4+ messages in thread
From: Vaibhav Agarwal @ 2019-03-15 5:19 UTC (permalink / raw)
To: Kangjie Lu
Cc: pakki001, Mark Greer, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel
On Thu, Mar 14, 2019 at 12:15 PM Kangjie Lu <kjlu@umn.edu> wrote:
>
> ida_simple_get could fail. The fix inserts a check for its
> return value.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/staging/greybus/audio_manager.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
> index d44b070d8862..c2a4af4c1d06 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc)
> int err;
>
> id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
> + if (id < 0)
> + return id;
> +
> err = gb_audio_manager_module_create(&module, manager_kset,
> id, desc);
> if (err) {
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
--
./va
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get
2019-03-15 5:19 ` Vaibhav Agarwal
@ 2019-04-30 15:19 ` Mark Greer
0 siblings, 0 replies; 4+ messages in thread
From: Mark Greer @ 2019-04-30 15:19 UTC (permalink / raw)
To: Vaibhav Agarwal
Cc: Kangjie Lu, pakki001, Mark Greer, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel
On Fri, Mar 15, 2019 at 10:49:46AM +0530, Vaibhav Agarwal wrote:
> On Thu, Mar 14, 2019 at 12:15 PM Kangjie Lu <kjlu@umn.edu> wrote:
> >
> > ida_simple_get could fail. The fix inserts a check for its
> > return value.
> >
> > Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> > ---
> > drivers/staging/greybus/audio_manager.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
> > index d44b070d8862..c2a4af4c1d06 100644
> > --- a/drivers/staging/greybus/audio_manager.c
> > +++ b/drivers/staging/greybus/audio_manager.c
> > @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc)
> > int err;
> >
> > id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
> > + if (id < 0)
> > + return id;
> > +
> > err = gb_audio_manager_module_create(&module, manager_kset,
> > id, desc);
> > if (err) {
>
> Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
I am sorry for not responding until now. For some strange reason, email
from this list are being delayed. I just got this today (April 30).
Thanks for the patch, Kangjie, and thanks for the review, Vaibhav.
And FWIW,
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
Mark
--
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-30 15:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-14 6:45 [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get Kangjie Lu
2019-03-14 9:08 ` [greybus-dev] " Viresh Kumar
2019-03-15 5:19 ` Vaibhav Agarwal
2019-04-30 15:19 ` Mark Greer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).