* [PATCH] Bluetooth: Don't assign twice the same value
@ 2022-03-02 20:18 Christophe JAILLET
2022-03-02 21:36 ` Luiz Augusto von Dentz
2022-03-14 22:00 ` Luiz Augusto von Dentz
0 siblings, 2 replies; 4+ messages in thread
From: Christophe JAILLET @ 2022-03-02 20:18 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
David S. Miller, Jakub Kicinski
Cc: linux-kernel, kernel-janitors, Christophe JAILLET,
linux-bluetooth, netdev
data.pid is set twice with the same value. Remove one of these redundant
calls.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
net/bluetooth/l2cap_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index e817ff0607a0..0d460cb7f965 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -1443,7 +1443,6 @@ static void l2cap_ecred_connect(struct l2cap_chan *chan)
data.pdu.scid[0] = cpu_to_le16(chan->scid);
chan->ident = l2cap_get_ident(conn);
- data.pid = chan->ops->get_peer_pid(chan);
data.count = 1;
data.chan = chan;
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth: Don't assign twice the same value
2022-03-02 20:18 [PATCH] Bluetooth: Don't assign twice the same value Christophe JAILLET
@ 2022-03-02 21:36 ` Luiz Augusto von Dentz
2022-03-03 5:48 ` Christophe JAILLET
2022-03-14 22:00 ` Luiz Augusto von Dentz
1 sibling, 1 reply; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2022-03-02 21:36 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Marcel Holtmann, Johan Hedberg, David S. Miller, Jakub Kicinski,
Linux Kernel Mailing List, kernel-janitors, linux-bluetooth,
open list:NETWORKING [GENERAL]
Hi Christophe,
On Wed, Mar 2, 2022 at 12:18 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> data.pid is set twice with the same value. Remove one of these redundant
> calls.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> net/bluetooth/l2cap_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index e817ff0607a0..0d460cb7f965 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -1443,7 +1443,6 @@ static void l2cap_ecred_connect(struct l2cap_chan *chan)
> data.pdu.scid[0] = cpu_to_le16(chan->scid);
>
> chan->ident = l2cap_get_ident(conn);
> - data.pid = chan->ops->get_peer_pid(chan);
Perhaps we should do if (!data->pid) then since afaik one can do
connect without bind.
> data.count = 1;
> data.chan = chan;
> --
> 2.32.0
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth: Don't assign twice the same value
2022-03-02 21:36 ` Luiz Augusto von Dentz
@ 2022-03-03 5:48 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2022-03-03 5:48 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: Marcel Holtmann, Johan Hedberg, David S. Miller, Jakub Kicinski,
Linux Kernel Mailing List, kernel-janitors, linux-bluetooth,
linux-bluetooth, open list:NETWORKING [GENERAL]
Le 02/03/2022 à 22:36, Luiz Augusto von Dentz a écrit :
> Hi Christophe,
>
> On Wed, Mar 2, 2022 at 12:18 PM Christophe JAILLET
> <christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org> wrote:
>>
>> data.pid is set twice with the same value. Remove one of these redundant
>> calls.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org>
>> ---
>> net/bluetooth/l2cap_core.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
>> index e817ff0607a0..0d460cb7f965 100644
>> --- a/net/bluetooth/l2cap_core.c
>> +++ b/net/bluetooth/l2cap_core.c
>> @@ -1443,7 +1443,6 @@ static void l2cap_ecred_connect(struct l2cap_chan *chan)
>> data.pdu.scid[0] = cpu_to_le16(chan->scid);
>>
>> chan->ident = l2cap_get_ident(conn);
>> - data.pid = chan->ops->get_peer_pid(chan);
>
> Perhaps we should do if (!data->pid) then since afaik one can do
> connect without bind.
Not sure to follow you.
'data' is local to this function. data->pid is undefined at this point.
If your comment is about the end of the function that should be
conditional, I don't know the bluetooth stack at all and can't have any
opinion about it.
If it is relevant, s.o. else will need to provide a patch for it.
CJ
>
>> data.count = 1;
>> data.chan = chan;
>> --
>> 2.32.0
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth: Don't assign twice the same value
2022-03-02 20:18 [PATCH] Bluetooth: Don't assign twice the same value Christophe JAILLET
2022-03-02 21:36 ` Luiz Augusto von Dentz
@ 2022-03-14 22:00 ` Luiz Augusto von Dentz
1 sibling, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2022-03-14 22:00 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Marcel Holtmann, Johan Hedberg, David S. Miller, Jakub Kicinski,
Linux Kernel Mailing List, kernel-janitors, linux-bluetooth,
open list:NETWORKING [GENERAL]
Hi Christophe,
On Wed, Mar 2, 2022 at 12:18 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> data.pid is set twice with the same value. Remove one of these redundant
> calls.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> net/bluetooth/l2cap_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index e817ff0607a0..0d460cb7f965 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -1443,7 +1443,6 @@ static void l2cap_ecred_connect(struct l2cap_chan *chan)
> data.pdu.scid[0] = cpu_to_le16(chan->scid);
>
> chan->ident = l2cap_get_ident(conn);
> - data.pid = chan->ops->get_peer_pid(chan);
>
> data.count = 1;
> data.chan = chan;
> --
> 2.32.0
>
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-14 22:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 20:18 [PATCH] Bluetooth: Don't assign twice the same value Christophe JAILLET
2022-03-02 21:36 ` Luiz Augusto von Dentz
2022-03-03 5:48 ` Christophe JAILLET
2022-03-14 22:00 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).