* [PATCH] drm/nouveau/bios/dp: make array vsoff static, shrinks object size
@ 2018-09-04 15:23 Colin King
2019-01-24 17:26 ` Colin Ian King
0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2018-09-04 15:23 UTC (permalink / raw)
To: Ben Skeggs, David Airlie, dri-devel, nouveau
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the array vsoff on the stack but instead make it
static. Makes the object code smaller by 67 bytes:
Before:
text data bss dec hex filename
5753 112 0 5865 16e9 .../nouveau/nvkm/subdev/bios/dp.o
After:
text data bss dec hex filename
5622 176 0 5798 16a6 .../nouveau/nvkm/subdev/bios/dp.o
(gcc version 8.2.0 x86_64)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
index 3133b28f849c..b099d1209be8 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
@@ -212,7 +212,7 @@ nvbios_dpcfg_match(struct nvkm_bios *bios, u16 outp, u8 pc, u8 vs, u8 pe,
u16 data;
if (*ver >= 0x30) {
- const u8 vsoff[] = { 0, 4, 7, 9 };
+ static const u8 vsoff[] = { 0, 4, 7, 9 };
idx = (pc * 10) + vsoff[vs] + pe;
if (*ver >= 0x40 && *ver <= 0x41 && *hdr >= 0x12)
idx += nvbios_rd08(bios, outp + 0x11) * 40;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/nouveau/bios/dp: make array vsoff static, shrinks object size
2018-09-04 15:23 [PATCH] drm/nouveau/bios/dp: make array vsoff static, shrinks object size Colin King
@ 2019-01-24 17:26 ` Colin Ian King
2019-01-24 22:05 ` Ben Skeggs
0 siblings, 1 reply; 4+ messages in thread
From: Colin Ian King @ 2019-01-24 17:26 UTC (permalink / raw)
To: Ben Skeggs, David Airlie, dri-devel, nouveau
Cc: kernel-janitors, linux-kernel
ping?
On 04/09/2018 16:23, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array vsoff on the stack but instead make it
> static. Makes the object code smaller by 67 bytes:
>
> Before:
> text data bss dec hex filename
> 5753 112 0 5865 16e9 .../nouveau/nvkm/subdev/bios/dp.o
>
> After:
> text data bss dec hex filename
> 5622 176 0 5798 16a6 .../nouveau/nvkm/subdev/bios/dp.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> index 3133b28f849c..b099d1209be8 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> @@ -212,7 +212,7 @@ nvbios_dpcfg_match(struct nvkm_bios *bios, u16 outp, u8 pc, u8 vs, u8 pe,
> u16 data;
>
> if (*ver >= 0x30) {
> - const u8 vsoff[] = { 0, 4, 7, 9 };
> + static const u8 vsoff[] = { 0, 4, 7, 9 };
> idx = (pc * 10) + vsoff[vs] + pe;
> if (*ver >= 0x40 && *ver <= 0x41 && *hdr >= 0x12)
> idx += nvbios_rd08(bios, outp + 0x11) * 40;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/nouveau/bios/dp: make array vsoff static, shrinks object size
2019-01-24 17:26 ` Colin Ian King
@ 2019-01-24 22:05 ` Ben Skeggs
0 siblings, 0 replies; 4+ messages in thread
From: Ben Skeggs @ 2019-01-24 22:05 UTC (permalink / raw)
To: Colin Ian King; +Cc: David Airlie, dri-devel, nouveau, kernel-janitors, LKML
On Fri, Jan 25, 2019 at 3:26 AM Colin Ian King <colin.king@canonical.com> wrote:
>
> ping?
I've pushed this, and the others you pinged about, to my tree.
Thank you,
Ben.
>
> On 04/09/2018 16:23, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Don't populate the array vsoff on the stack but instead make it
> > static. Makes the object code smaller by 67 bytes:
> >
> > Before:
> > text data bss dec hex filename
> > 5753 112 0 5865 16e9 .../nouveau/nvkm/subdev/bios/dp.o
> >
> > After:
> > text data bss dec hex filename
> > 5622 176 0 5798 16a6 .../nouveau/nvkm/subdev/bios/dp.o
> >
> > (gcc version 8.2.0 x86_64)
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> > index 3133b28f849c..b099d1209be8 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> > @@ -212,7 +212,7 @@ nvbios_dpcfg_match(struct nvkm_bios *bios, u16 outp, u8 pc, u8 vs, u8 pe,
> > u16 data;
> >
> > if (*ver >= 0x30) {
> > - const u8 vsoff[] = { 0, 4, 7, 9 };
> > + static const u8 vsoff[] = { 0, 4, 7, 9 };
> > idx = (pc * 10) + vsoff[vs] + pe;
> > if (*ver >= 0x40 && *ver <= 0x41 && *hdr >= 0x12)
> > idx += nvbios_rd08(bios, outp + 0x11) * 40;
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/nouveau/bios/dp: Make array vsoff static, shrinks object size
@ 2018-09-26 8:22 Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2018-09-26 8:22 UTC (permalink / raw)
To: Ben Skeggs, David Airlie, dri-devel, nouveau
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the array vsoff on the stack but instead make it
static. Makes the object code smaller by 67 bytes:
Before:
text data bss dec hex filename
5753 112 0 5865 16e9 drm/nouveau/nvkm/subdev/bios/dp.o
After:
text data bss dec hex filename
5622 176 0 5798 16a6 drm/nouveau/nvkm/subdev/bios/dp.o
(gcc version 8.2.0 x86_64)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
index 3133b28f849c..b099d1209be8 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
@@ -212,7 +212,7 @@ nvbios_dpcfg_match(struct nvkm_bios *bios, u16 outp, u8 pc, u8 vs, u8 pe,
u16 data;
if (*ver >= 0x30) {
- const u8 vsoff[] = { 0, 4, 7, 9 };
+ static const u8 vsoff[] = { 0, 4, 7, 9 };
idx = (pc * 10) + vsoff[vs] + pe;
if (*ver >= 0x40 && *ver <= 0x41 && *hdr >= 0x12)
idx += nvbios_rd08(bios, outp + 0x11) * 40;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-24 22:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-04 15:23 [PATCH] drm/nouveau/bios/dp: make array vsoff static, shrinks object size Colin King
2019-01-24 17:26 ` Colin Ian King
2019-01-24 22:05 ` Ben Skeggs
2018-09-26 8:22 [PATCH] drm/nouveau/bios/dp: Make " Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).