From: Stephane Eranian <eranian@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] perf jit: remove some no-op error handling
Date: Sat, 16 Jul 2016 09:25:32 -0700 [thread overview]
Message-ID: <CABPqkBQL0QNtZF6vY_08bomxdFu=0e7CS9mqhCiVN_Y5Hi9GPQ@mail.gmail.com> (raw)
In-Reply-To: <20160715222721.GF8740@kernel.org>
On Fri, Jul 15, 2016 at 3:27 PM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
> Em Sat, Jul 16, 2016 at 12:08:36AM +0300, Dan Carpenter escreveu:
>> info.e_machine is a uint16_t so m is never less than zero. It looks
>> like this was maybe left over code from earlier versions so I've just
>> removed it.
>
> Yeah, it sure looks like that, applying, thanks,
>
Thanks for cleaning this up.
> - Arnaldo
>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/tools/perf/jvmti/jvmti_agent.c b/tools/perf/jvmti/jvmti_agent.c
>> index 91bf333..55daeff 100644
>> --- a/tools/perf/jvmti/jvmti_agent.c
>> +++ b/tools/perf/jvmti/jvmti_agent.c
>> @@ -59,7 +59,6 @@ static int get_e_machine(struct jitheader *hdr)
>> ssize_t sret;
>> char id[16];
>> int fd, ret = -1;
>> - int m = -1;
>> struct {
>> uint16_t e_type;
>> uint16_t e_machine;
>> @@ -81,11 +80,7 @@ static int get_e_machine(struct jitheader *hdr)
>> if (sret != sizeof(info))
>> goto error;
>>
>> - m = info.e_machine;
>> - if (m < 0)
>> - m = 0; /* ELF EM_NONE */
>> -
>> - hdr->elf_mach = m;
>> + hdr->elf_mach = info.e_machine;
>> ret = 0;
>> error:
>> close(fd);
next prev parent reply other threads:[~2016-07-16 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 21:08 [patch 2/2] perf jit: remove some no-op error handling Dan Carpenter
2016-07-15 22:27 ` Arnaldo Carvalho de Melo
2016-07-16 16:25 ` Stephane Eranian [this message]
2016-07-19 6:49 ` [tip:perf/core] perf jit: Remove " tip-bot for Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPqkBQL0QNtZF6vY_08bomxdFu=0e7CS9mqhCiVN_Y5Hi9GPQ@mail.gmail.com' \
--to=eranian@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).