From: Stephane Eranian <eranian@google.com>
To: Jacob Shin <jacob.shin@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86 <x86@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND V5 3/6] perf, amd: Use proper naming scheme for AMD bit field definitions
Date: Fri, 25 Jan 2013 12:08:37 +0100 [thread overview]
Message-ID: <CABPqkBR5baJ5rQoCiJwG7dZ6p_5BpDbtVqUAcB4A1PjtW+rr6w@mail.gmail.com> (raw)
In-Reply-To: <1357847443-3878-4-git-send-email-jacob.shin@amd.com>
On Thu, Jan 10, 2013 at 8:50 PM, Jacob Shin <jacob.shin@amd.com> wrote:
> Update these AMD bit field names to be consistent with naming
> convention followed by the rest of the file.
>
> Signed-off-by: Jacob Shin <jacob.shin@amd.com>
Acked-by: Stephane Eranian <eranian@google.com>
> ---
> arch/x86/include/asm/perf_event.h | 4 ++--
> arch/x86/kernel/cpu/perf_event_amd.c | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_event.h
> index 4fabcdf..2234eaaec 100644
> --- a/arch/x86/include/asm/perf_event.h
> +++ b/arch/x86/include/asm/perf_event.h
> @@ -29,8 +29,8 @@
> #define ARCH_PERFMON_EVENTSEL_INV (1ULL << 23)
> #define ARCH_PERFMON_EVENTSEL_CMASK 0xFF000000ULL
>
> -#define AMD_PERFMON_EVENTSEL_GUESTONLY (1ULL << 40)
> -#define AMD_PERFMON_EVENTSEL_HOSTONLY (1ULL << 41)
> +#define AMD64_EVENTSEL_GUESTONLY (1ULL << 40)
> +#define AMD64_EVENTSEL_HOSTONLY (1ULL << 41)
>
> #define AMD64_EVENTSEL_EVENT \
> (ARCH_PERFMON_EVENTSEL_EVENT | (0x0FULL << 32))
> diff --git a/arch/x86/kernel/cpu/perf_event_amd.c b/arch/x86/kernel/cpu/perf_event_amd.c
> index 9541fe5..0c2cc51 100644
> --- a/arch/x86/kernel/cpu/perf_event_amd.c
> +++ b/arch/x86/kernel/cpu/perf_event_amd.c
> @@ -156,9 +156,9 @@ static int amd_pmu_hw_config(struct perf_event *event)
> event->hw.config &= ~(ARCH_PERFMON_EVENTSEL_USR |
> ARCH_PERFMON_EVENTSEL_OS);
> else if (event->attr.exclude_host)
> - event->hw.config |= AMD_PERFMON_EVENTSEL_GUESTONLY;
> + event->hw.config |= AMD64_EVENTSEL_GUESTONLY;
> else if (event->attr.exclude_guest)
> - event->hw.config |= AMD_PERFMON_EVENTSEL_HOSTONLY;
> + event->hw.config |= AMD64_EVENTSEL_HOSTONLY;
>
> if (event->attr.type != PERF_TYPE_RAW)
> return 0;
> @@ -336,7 +336,7 @@ static void amd_pmu_cpu_starting(int cpu)
> struct amd_nb *nb;
> int i, nb_id;
>
> - cpuc->perf_ctr_virt_mask = AMD_PERFMON_EVENTSEL_HOSTONLY;
> + cpuc->perf_ctr_virt_mask = AMD64_EVENTSEL_HOSTONLY;
>
> if (boot_cpu_data.x86_max_cores < 2)
> return;
> @@ -669,7 +669,7 @@ void amd_pmu_disable_virt(void)
> * SVM is disabled the Guest-only bits still gets set and the counter
> * will not count anything.
> */
> - cpuc->perf_ctr_virt_mask = AMD_PERFMON_EVENTSEL_HOSTONLY;
> + cpuc->perf_ctr_virt_mask = AMD64_EVENTSEL_HOSTONLY;
>
> /* Reload all events */
> x86_pmu_disable_all();
> --
> 1.7.9.5
>
>
next prev parent reply other threads:[~2013-01-25 11:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 19:50 [PATCH RESEND V5 0/6] perf, amd: Enable AMD family 15h northbridge counters Jacob Shin
2013-01-10 19:50 ` [PATCH RESEND V5 1/6] perf, amd: Rework northbridge event constraints handler Jacob Shin
2013-01-25 10:52 ` Stephane Eranian
2013-01-10 19:50 ` [PATCH RESEND V5 2/6] perf, amd: Generalize northbridge constraints code for family 15h Jacob Shin
2013-01-25 11:07 ` Stephane Eranian
2013-01-25 15:56 ` Jacob Shin
2013-01-10 19:50 ` [PATCH RESEND V5 3/6] perf, amd: Use proper naming scheme for AMD bit field definitions Jacob Shin
2013-01-25 11:08 ` Stephane Eranian [this message]
2013-01-10 19:50 ` [PATCH RESEND V5 4/6] perf, x86: Move MSR address offset calculation to architecture specific files Jacob Shin
2013-01-25 11:15 ` Stephane Eranian
2013-01-25 15:59 ` Jacob Shin
2013-01-10 19:50 ` [PATCH RESEND V5 5/6] perf, x86: Allow for architecture specific RDPMC indexes Jacob Shin
2013-01-25 13:16 ` Stephane Eranian
2013-01-10 19:50 ` [PATCH RESEND V5 6/6] perf, amd: Enable northbridge performance counters on AMD family 15h Jacob Shin
2013-01-25 15:13 ` Stephane Eranian
2013-01-24 13:31 ` [PATCH RESEND V5 0/6] perf, amd: Enable AMD family 15h northbridge counters Stephane Eranian
2013-01-24 22:06 ` Jacob Shin
2013-01-25 9:42 ` [perfmon2] " Stephane Eranian
2013-01-25 15:46 ` Jacob Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPqkBR5baJ5rQoCiJwG7dZ6p_5BpDbtVqUAcB4A1PjtW+rr6w@mail.gmail.com \
--to=eranian@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=hpa@zytor.com \
--cc=jacob.shin@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).