From: David Gow <davidgow@google.com>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: Shuah Khan <shuah@kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] kunit: tool: unmark test_data as binary blobs
Date: Sat, 7 Nov 2020 12:09:16 +0800 [thread overview]
Message-ID: <CABVgOSnVj+EXZ13vgx7pj3fFJ7yx9xPYU39nuCP_v_fNYpN12w@mail.gmail.com> (raw)
In-Reply-To: <20201105232440.1049635-1-brendanhiggins@google.com>
On Fri, Nov 6, 2020 at 7:24 AM Brendan Higgins
<brendanhiggins@google.com> wrote:
>
> The tools/testing/kunit/test_data/ directory was marked as binary
> because some of the test_data files cause checkpatch warnings. Fix this
> by dropping the .gitattributes file.
>
> Fixes: afc63da64f1e ("kunit: kunit_parser: make parser more robust")
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
Reviewed-by: David Gow <davidgow@google.com>
Thanks. I wasn't able to find any issues which required those files to
be binary.
For the record, a link to the original issue, which appeared to be
with whitespace (spaces before tabs) in git apply:
https://lkml.org/lkml/2020/3/13/920
Cheers,
-- David
prev parent reply other threads:[~2020-11-07 4:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 23:24 [PATCH v1] kunit: tool: unmark test_data as binary blobs Brendan Higgins
2020-11-07 4:09 ` David Gow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABVgOSnVj+EXZ13vgx7pj3fFJ7yx9xPYU39nuCP_v_fNYpN12w@mail.gmail.com \
--to=davidgow@google.com \
--cc=brendanhiggins@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).