* [PATCH v1] kunit: tool: unmark test_data as binary blobs
@ 2020-11-05 23:24 Brendan Higgins
2020-11-07 4:09 ` David Gow
0 siblings, 1 reply; 2+ messages in thread
From: Brendan Higgins @ 2020-11-05 23:24 UTC (permalink / raw)
To: shuah, davidgow; +Cc: linux-kselftest, kunit-dev, linux-kernel, Brendan Higgins
The tools/testing/kunit/test_data/ directory was marked as binary
because some of the test_data files cause checkpatch warnings. Fix this
by dropping the .gitattributes file.
Fixes: afc63da64f1e ("kunit: kunit_parser: make parser more robust")
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
tools/testing/kunit/.gitattributes | 1 -
1 file changed, 1 deletion(-)
delete mode 100644 tools/testing/kunit/.gitattributes
diff --git a/tools/testing/kunit/.gitattributes b/tools/testing/kunit/.gitattributes
deleted file mode 100644
index 5b7da1fc3b8f1..0000000000000
--- a/tools/testing/kunit/.gitattributes
+++ /dev/null
@@ -1 +0,0 @@
-test_data/* binary
base-commit: 4ef8451b332662d004df269d4cdeb7d9f31419b5
--
2.29.1.341.ge80a0c044ae-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] kunit: tool: unmark test_data as binary blobs
2020-11-05 23:24 [PATCH v1] kunit: tool: unmark test_data as binary blobs Brendan Higgins
@ 2020-11-07 4:09 ` David Gow
0 siblings, 0 replies; 2+ messages in thread
From: David Gow @ 2020-11-07 4:09 UTC (permalink / raw)
To: Brendan Higgins
Cc: Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK,
KUnit Development, Linux Kernel Mailing List
On Fri, Nov 6, 2020 at 7:24 AM Brendan Higgins
<brendanhiggins@google.com> wrote:
>
> The tools/testing/kunit/test_data/ directory was marked as binary
> because some of the test_data files cause checkpatch warnings. Fix this
> by dropping the .gitattributes file.
>
> Fixes: afc63da64f1e ("kunit: kunit_parser: make parser more robust")
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
Reviewed-by: David Gow <davidgow@google.com>
Thanks. I wasn't able to find any issues which required those files to
be binary.
For the record, a link to the original issue, which appeared to be
with whitespace (spaces before tabs) in git apply:
https://lkml.org/lkml/2020/3/13/920
Cheers,
-- David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-07 4:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-05 23:24 [PATCH v1] kunit: tool: unmark test_data as binary blobs Brendan Higgins
2020-11-07 4:09 ` David Gow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).