From: Guenter Roeck <groeck@google.com>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Gwendal Grignou <gwendal@chromium.org>,
ejcaruso@chromium.org, Olof Johansson <olof@lixom.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 3/3] mfd: cros_ec: Add support for dumping panic information
Date: Tue, 23 Aug 2016 14:19:16 -0700 [thread overview]
Message-ID: <CABXOdTcQNE5ROF8NsYJkG28-T1E-Xp5DLsnA_pDuUUtnZPBvUQ@mail.gmail.com> (raw)
In-Reply-To: <1471926859-21263-4-git-send-email-drinkcat@chromium.org>
On Mon, Aug 22, 2016 at 9:34 PM, Nicolas Boichat <drinkcat@chromium.org> wrote:
> This dumps the EC panic information from the previous reboot.
>
> Similar to the information presented by ectool panicinfo, except
> that we do not bother doing any parsing (we should write a small
> offline tool for that).
>
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/platform/chrome/cros_ec_debugfs.c | 54 +++++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
> index 225f936..f4b6a29 100644
> --- a/drivers/platform/chrome/cros_ec_debugfs.c
> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
> @@ -47,15 +47,19 @@
> * @log_mutex: mutex to protect circular buffer
> * @log_wq: waitqueue for log readers
> * @log_poll_work: recurring task to poll EC for new console log data
> + * @panicinfo_blob: panicinfo debugfs blob
> */
> struct cros_ec_debugfs {
> struct cros_ec_dev *ec;
> struct dentry *dir;
> + /* EC log */
> struct circ_buf log_buffer;
> struct cros_ec_command *read_msg;
> struct mutex log_mutex;
> wait_queue_head_t log_wq;
> struct delayed_work log_poll_work;
> + /* EC panicinfo */
> + struct debugfs_blob_wrapper panicinfo_blob;
> };
>
> /*
> @@ -308,6 +312,52 @@ static void cros_ec_cleanup_console_log(struct cros_ec_debugfs *debug_info)
> }
> }
>
> +static int cros_ec_create_panicinfo(struct cros_ec_debugfs *debug_info)
> +{
> + struct cros_ec_device *ec_dev = debug_info->ec->ec_dev;
> + int ret;
> + struct cros_ec_command *msg;
> + int insize;
> +
> + insize = ec_dev->max_response;
> +
> + msg = devm_kzalloc(debug_info->ec->dev,
> + sizeof(*msg) + insize, GFP_KERNEL);
> + if (!msg)
> + return -ENOMEM;
> +
> + msg->command = EC_CMD_GET_PANIC_INFO;
> + msg->insize = insize;
> +
> + ret = cros_ec_cmd_xfer(ec_dev, msg);
> + if (ret < 0) {
> + dev_warn(debug_info->ec->dev, "Cannot read panicinfo.\n");
> + ret = 0;
> + goto free;
> + }
> +
> + /* No panic data */
> + if (ret == 0)
> + goto free;
> +
> + debug_info->panicinfo_blob.data = msg->data;
> + debug_info->panicinfo_blob.size = ret;
> +
> + if (!debugfs_create_blob("panicinfo",
> + S_IFREG | S_IRUGO,
> + debug_info->dir,
> + &debug_info->panicinfo_blob)) {
> + ret = -ENOMEM;
> + goto free;
> + }
> +
> + return 0;
> +
> +free:
> + devm_kfree(debug_info->ec->dev, msg);
> + return ret;
> +}
> +
> int cros_ec_debugfs_init(struct cros_ec_dev *ec)
> {
> struct cros_ec_platform *ec_platform = dev_get_platdata(ec->dev);
> @@ -324,6 +374,10 @@ int cros_ec_debugfs_init(struct cros_ec_dev *ec)
> if (!debug_info->dir)
> return -ENOMEM;
>
> + ret = cros_ec_create_panicinfo(debug_info);
> + if (ret)
> + goto remove_debugfs;
> +
> ret = cros_ec_create_console_log(debug_info);
> if (ret)
> goto remove_debugfs;
> --
> 2.8.0.rc3.226.g39d4020
>
prev parent reply other threads:[~2016-08-23 21:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 4:34 [PATCH 0/3] mfd: cros_ec: Add debugfs directory to capture logs/panicinfo Nicolas Boichat
2016-08-23 4:34 ` [PATCH 1/3] mfd: cros_ec: Add EC console read structures definitions Nicolas Boichat
2016-08-23 21:15 ` Guenter Roeck
2016-08-31 11:45 ` Lee Jones
2016-10-13 3:24 ` Nicolas Boichat
2016-10-13 18:06 ` Olof Johansson
2016-10-13 20:32 ` Nicolas Boichat
2016-08-23 4:34 ` [PATCH 2/3] mfd: cros_ec: add debugfs, console log file Nicolas Boichat
2016-08-23 21:17 ` Guenter Roeck
2016-08-31 11:45 ` Lee Jones
2017-02-22 21:49 ` Doug Anderson
2016-08-23 4:34 ` [PATCH 3/3] mfd: cros_ec: Add support for dumping panic information Nicolas Boichat
2016-08-23 21:19 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABXOdTcQNE5ROF8NsYJkG28-T1E-Xp5DLsnA_pDuUUtnZPBvUQ@mail.gmail.com \
--to=groeck@google.com \
--cc=drinkcat@chromium.org \
--cc=ejcaruso@chromium.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).