From: Doug Anderson <dianders@chromium.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Lee Jones <lee.jones@linaro.org>,
"gwendal@chromium.org" <gwendal@chromium.org>,
ejcaruso@chromium.org, Olof Johansson <olof@lixom.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Thierry Escande <thierry.escande@collabora.com>,
Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH 2/3] mfd: cros_ec: add debugfs, console log file
Date: Wed, 22 Feb 2017 13:49:06 -0800 [thread overview]
Message-ID: <CAD=FV=Unuhxbiw6sEiMsgKBxkmCUiJ6m2M9LOQ4W90gpRXPLwA@mail.gmail.com> (raw)
In-Reply-To: <1471926859-21263-3-git-send-email-drinkcat@chromium.org>
Hi,
I'm not sure what happened to this patch, but I found it when making
sure that the bugfix pointed out in
<https://chromium-review.googlesource.com/c/444085/3/drivers/platform/chrome/cros_ec_debugfs.c#240>.
Presumably someone will want to pick it up eventually? +Benson
On Mon, Aug 22, 2016 at 9:34 PM, Nicolas Boichat <drinkcat@chromium.org> wrote:
> +static int ec_read_version_supported(struct cros_ec_dev *ec)
> +{
> + struct ec_params_get_cmd_versions_v1 *params;
> + struct ec_response_get_cmd_versions *response;
> + int ret;
> +
> + struct cros_ec_command *msg;
> +
> + msg = kzalloc(sizeof(*msg) + max(sizeof(params), sizeof(response)),
> + GFP_KERNEL);
> + if (!msg)
> + return 0;
> +
> + msg->command = EC_CMD_GET_CMD_VERSIONS + ec->cmd_offset;
> + msg->outsize = sizeof(params);
> + msg->insize = sizeof(response);
The above sizeof() calls are wrong. They need "*"
next prev parent reply other threads:[~2017-02-22 21:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 4:34 [PATCH 0/3] mfd: cros_ec: Add debugfs directory to capture logs/panicinfo Nicolas Boichat
2016-08-23 4:34 ` [PATCH 1/3] mfd: cros_ec: Add EC console read structures definitions Nicolas Boichat
2016-08-23 21:15 ` Guenter Roeck
2016-08-31 11:45 ` Lee Jones
2016-10-13 3:24 ` Nicolas Boichat
2016-10-13 18:06 ` Olof Johansson
2016-10-13 20:32 ` Nicolas Boichat
2016-08-23 4:34 ` [PATCH 2/3] mfd: cros_ec: add debugfs, console log file Nicolas Boichat
2016-08-23 21:17 ` Guenter Roeck
2016-08-31 11:45 ` Lee Jones
2017-02-22 21:49 ` Doug Anderson [this message]
2016-08-23 4:34 ` [PATCH 3/3] mfd: cros_ec: Add support for dumping panic information Nicolas Boichat
2016-08-23 21:19 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Unuhxbiw6sEiMsgKBxkmCUiJ6m2M9LOQ4W90gpRXPLwA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=bleung@chromium.org \
--cc=drinkcat@chromium.org \
--cc=ejcaruso@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).