* [PATCH] drm/rockchip: add extcon dependency for DP
@ 2017-02-14 21:31 Arnd Bergmann
2017-02-14 22:06 ` Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-02-14 21:31 UTC (permalink / raw)
To: Mark Yao, David Airlie
Cc: Sean Paul, Guenter Roeck, Arnd Bergmann, Heiko Stuebner,
Daniel Vetter, Yakir Yang, Philipp Zabel, Chris Zhong,
Tobias Jakobi, dri-devel, linux-arm-kernel, linux-rockchip,
linux-kernel
The newly added DP driver links against the extcon core, which fails when
extcon is a module and this driver is not:
drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state'
cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property'
Let's make Kconfig enforce correct behavior with a dependency.
Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/rockchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index ad31b3eb408f..0e4eb845cbb0 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP
config ROCKCHIP_CDN_DP
tristate "Rockchip cdn DP"
depends on DRM_ROCKCHIP
+ depends on EXTCON
select SND_SOC_HDMI_CODEC if SND_SOC
help
This selects support for Rockchip SoC specific extensions
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rockchip: add extcon dependency for DP
2017-02-14 21:31 [PATCH] drm/rockchip: add extcon dependency for DP Arnd Bergmann
@ 2017-02-14 22:06 ` Guenter Roeck
2017-02-15 1:06 ` Mark yao
2017-02-23 16:48 ` Sean Paul
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2017-02-14 22:06 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Yao, David Airlie, Sean Paul, Guenter Roeck, Heiko Stuebner,
Daniel Vetter, Yakir Yang, Philipp Zabel, Chris Zhong,
Tobias Jakobi, dri-devel, linux-arm-kernel,
open list:ARM/Rockchip SoC...,
linux-kernel
On Tue, Feb 14, 2017 at 1:31 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added DP driver links against the extcon core, which fails when
> extcon is a module and this driver is not:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property'
>
> Let's make Kconfig enforce correct behavior with a dependency.
>
> Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index ad31b3eb408f..0e4eb845cbb0 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP
> config ROCKCHIP_CDN_DP
> tristate "Rockchip cdn DP"
> depends on DRM_ROCKCHIP
> + depends on EXTCON
> select SND_SOC_HDMI_CODEC if SND_SOC
> help
> This selects support for Rockchip SoC specific extensions
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rockchip: add extcon dependency for DP
2017-02-14 21:31 [PATCH] drm/rockchip: add extcon dependency for DP Arnd Bergmann
2017-02-14 22:06 ` Guenter Roeck
@ 2017-02-15 1:06 ` Mark yao
2017-02-23 16:48 ` Sean Paul
2 siblings, 0 replies; 4+ messages in thread
From: Mark yao @ 2017-02-15 1:06 UTC (permalink / raw)
To: Arnd Bergmann, David Airlie
Cc: Sean Paul, Guenter Roeck, Heiko Stuebner, Daniel Vetter,
Philipp Zabel, Chris Zhong, Tobias Jakobi, dri-devel,
linux-arm-kernel, linux-rockchip, linux-kernel
On 2017年02月15日 05:31, Arnd Bergmann wrote:
> The newly added DP driver links against the extcon core, which fails when
> extcon is a module and this driver is not:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property'
>
> Let's make Kconfig enforce correct behavior with a dependency.
Thanks for the fix.
Applied to my drm-next.
> Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index ad31b3eb408f..0e4eb845cbb0 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP
> config ROCKCHIP_CDN_DP
> tristate "Rockchip cdn DP"
> depends on DRM_ROCKCHIP
> + depends on EXTCON
> select SND_SOC_HDMI_CODEC if SND_SOC
> help
> This selects support for Rockchip SoC specific extensions
--
Ｍark Yao
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rockchip: add extcon dependency for DP
2017-02-14 21:31 [PATCH] drm/rockchip: add extcon dependency for DP Arnd Bergmann
2017-02-14 22:06 ` Guenter Roeck
2017-02-15 1:06 ` Mark yao
@ 2017-02-23 16:48 ` Sean Paul
2 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2017-02-23 16:48 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Yao, David Airlie, Tobias Jakobi, Daniel Vetter,
linux-kernel, dri-devel, Chris Zhong, Yakir Yang, Guenter Roeck,
linux-rockchip, linux-arm-kernel
On Tue, Feb 14, 2017 at 10:31:51PM +0100, Arnd Bergmann wrote:
> The newly added DP driver links against the extcon core, which fails when
> extcon is a module and this driver is not:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property'
>
> Let's make Kconfig enforce correct behavior with a dependency.
>
> Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to drm-misc-next-fixes
Thanks,
Sean
> ---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index ad31b3eb408f..0e4eb845cbb0 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP
> config ROCKCHIP_CDN_DP
> tristate "Rockchip cdn DP"
> depends on DRM_ROCKCHIP
> + depends on EXTCON
> select SND_SOC_HDMI_CODEC if SND_SOC
> help
> This selects support for Rockchip SoC specific extensions
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-23 16:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-14 21:31 [PATCH] drm/rockchip: add extcon dependency for DP Arnd Bergmann
2017-02-14 22:06 ` Guenter Roeck
2017-02-15 1:06 ` Mark yao
2017-02-23 16:48 ` Sean Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).