linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jassi Brar <jassisinghbrar@gmail.com>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot
Date: Mon, 31 Jul 2017 22:13:22 +0530	[thread overview]
Message-ID: <CABb+yY18zJUtC6-1-OKUbK1RLdqmAn330D4Q-FgKx8R4He8ynQ@mail.gmail.com> (raw)
In-Reply-To: <874ltt0w7w.fsf@e105922-lin.cambridge.arm.com>

[CC'ing Rafael J. Wysocki, who picks patches for pcc.c]

On Mon, Jul 31, 2017 at 3:22 PM, Punit Agrawal <punit.agrawal@arm.com> wrote:
> Punit Agrawal <punit.agrawal@arm.com> writes:
>
>> When booting on an ACPI enabled system that does not provide the
>> Platform Communications Channel Table (PCCT), the pcc mailbox driver
>> prints -
>>
>> [    0.484261] PCCT header not found.
>>
>> during probe before returning -ENODEV.
>>
>> This message clutters the bootlog and doesn't provide any useful
>> information. Drop this message.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> Cc: Jassi Brar <jassisinghbrar@gmail.com>
>> ---
>>  drivers/mailbox/pcc.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
>> index ac91fd0d62c6..3d83cdc11ab5 100644
>> --- a/drivers/mailbox/pcc.c
>> +++ b/drivers/mailbox/pcc.c
>> @@ -457,10 +457,8 @@ static int __init acpi_pcc_probe(void)
>>       /* Search for PCCT */
>>       status = acpi_get_table(ACPI_SIG_PCCT, 0, &pcct_tbl);
>>
>> -     if (ACPI_FAILURE(status) || !pcct_tbl) {
>> -             pr_warn("PCCT header not found.\n");
>> +     if (ACPI_FAILURE(status) || !pcct_tbl)
>>               return -ENODEV;
>> -     }
>>
>>       count = acpi_table_parse_entries(ACPI_SIG_PCCT,
>>                       sizeof(struct acpi_table_pcct),
>
> Ping! Any comments/concerns with dropping the message?
>
> Thanks.

  parent reply	other threads:[~2017-07-31 16:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 11:03 [PATCH 0/4] Drop uninformative messages from bootlog Punit Agrawal
2017-07-20 11:03 ` [PATCH 1/4] arm64/numa: Drop duplicate message Punit Agrawal
2017-07-20 11:04 ` [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot Punit Agrawal
     [not found]   ` <874ltt0w7w.fsf@e105922-lin.cambridge.arm.com>
2017-07-31 16:43     ` Jassi Brar [this message]
2017-07-31 17:47   ` Alexey Klimov
2017-07-31 22:23     ` Rafael J. Wysocki
2017-08-01  8:57       ` Punit Agrawal
2017-07-20 11:04 ` [PATCH 3/4] ACPI / APEI: Drop uninformative messages " Punit Agrawal
2017-07-20 11:17   ` Borislav Petkov
2017-07-20 12:29     ` Punit Agrawal
2017-07-20 13:54       ` Borislav Petkov
2017-07-20 17:50         ` Punit Agrawal
2017-07-21 13:27           ` Borislav Petkov
2017-07-27  9:35             ` Punit Agrawal
2017-07-27  9:52               ` Borislav Petkov
2017-07-27  9:55                 ` Punit Agrawal
2017-07-20 11:04 ` [PATCH 4/4] xen: Drop un-informative message " Punit Agrawal
2017-07-20 21:20   ` Boris Ostrovsky
2017-07-21 10:12     ` [Xen-devel] " Punit Agrawal
2017-07-21 10:19       ` Juergen Gross
2017-07-21 10:21         ` Punit Agrawal
2017-07-28  9:34   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABb+yY18zJUtC6-1-OKUbK1RLdqmAn330D4Q-FgKx8R4He8ynQ@mail.gmail.com \
    --to=jassisinghbrar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=punit.agrawal@arm.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).