From: Punit Agrawal <punit.agrawal@arm.com>
To: Borislav Petkov <bp@suse.de>
Cc: linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com,
sudeep.holla@arm.com, linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot
Date: Thu, 27 Jul 2017 10:35:45 +0100 [thread overview]
Message-ID: <87zibqi5n2.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <20170721132731.GA5041@nazgul.tnic> (Borislav Petkov's message of "Fri, 21 Jul 2017 15:27:31 +0200")
Hi Boris,
Apologies for the delayed response. I somehow managed to lose updates on
this thread.
Borislav Petkov <bp@suse.de> writes:
> On Thu, Jul 20, 2017 at 06:50:51PM +0100, Punit Agrawal wrote:
>> "Firmware does not support APEI firmware first mode"
>>
>> Thoughts?
>
> I guess the simplest would be to add a third state to that hest_disable
> to denote "HEST table not found" and then exit ghes_init() early, based on
> checking it.
Although simple, won't it make the already convoluted code flow more
so. Instead in addition to not setting hest_disable when the table is
not found ...
>
> Otherwise ghes_init() inits a bunch of things which you probably don't
> want on a platform which doesn't support APEI.
... would you be open to a patch re-working the ghes driver
initialisation to only do the platform driver registration. The the rest
of the initialisation (including the apei_osc_setup and related
messages) can be performed when the first ghes device gets probed.
Does that sound like a better alternative?
>
> --
> Regards/Gruss,
> Boris.
>
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-07-27 9:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 11:03 [PATCH 0/4] Drop uninformative messages from bootlog Punit Agrawal
2017-07-20 11:03 ` [PATCH 1/4] arm64/numa: Drop duplicate message Punit Agrawal
2017-07-20 11:04 ` [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot Punit Agrawal
[not found] ` <874ltt0w7w.fsf@e105922-lin.cambridge.arm.com>
2017-07-31 16:43 ` Jassi Brar
2017-07-31 17:47 ` Alexey Klimov
2017-07-31 22:23 ` Rafael J. Wysocki
2017-08-01 8:57 ` Punit Agrawal
2017-07-20 11:04 ` [PATCH 3/4] ACPI / APEI: Drop uninformative messages " Punit Agrawal
2017-07-20 11:17 ` Borislav Petkov
2017-07-20 12:29 ` Punit Agrawal
2017-07-20 13:54 ` Borislav Petkov
2017-07-20 17:50 ` Punit Agrawal
2017-07-21 13:27 ` Borislav Petkov
2017-07-27 9:35 ` Punit Agrawal [this message]
2017-07-27 9:52 ` Borislav Petkov
2017-07-27 9:55 ` Punit Agrawal
2017-07-20 11:04 ` [PATCH 4/4] xen: Drop un-informative message " Punit Agrawal
2017-07-20 21:20 ` Boris Ostrovsky
2017-07-21 10:12 ` [Xen-devel] " Punit Agrawal
2017-07-21 10:19 ` Juergen Gross
2017-07-21 10:21 ` Punit Agrawal
2017-07-28 9:34 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zibqi5n2.fsf@e105922-lin.cambridge.arm.com \
--to=punit.agrawal@arm.com \
--cc=bp@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).