* [PATCH 1/4] ARM: mstar: Mark timer with arm,cpu-registers-not-fw-configured
2021-09-10 19:03 [PATCH 0/4] Add support for IDO-SBC2D06-V1B-22W Romain Perier
@ 2021-09-10 19:03 ` Romain Perier
2021-09-10 19:03 ` [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W Romain Perier
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: Romain Perier @ 2021-09-10 19:03 UTC (permalink / raw)
To: Daniel Palmer, Romain Perier, Rob Herring, Arnd Bergmann,
Olof Johansson, soc
Cc: linux-arm-kernel, devicetree, linux-kernel
The vendor u-boot does not configure the arch timer correctly on
MStar, let Linux do it.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
---
arch/arm/boot/dts/mstar-v7.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dtsi
index 2273295e140f..982dba9d28eb 100644
--- a/arch/arm/boot/dts/mstar-v7.dtsi
+++ b/arch/arm/boot/dts/mstar-v7.dtsi
@@ -39,6 +39,7 @@ arch_timer {
* u-boot is broken
*/
clock-frequency = <6000000>;
+ arm,cpu-registers-not-fw-configured;
};
pmu: pmu {
--
2.33.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
2021-09-10 19:03 [PATCH 0/4] Add support for IDO-SBC2D06-V1B-22W Romain Perier
2021-09-10 19:03 ` [PATCH 1/4] ARM: mstar: Mark timer with arm,cpu-registers-not-fw-configured Romain Perier
@ 2021-09-10 19:03 ` Romain Perier
2021-09-11 3:18 ` Daniel Palmer
2021-09-10 19:03 ` [PATCH 3/4] dt-bindings: add vendor prefix for Wireless Tag Romain Perier
2021-09-10 19:03 ` [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers Romain Perier
3 siblings, 1 reply; 14+ messages in thread
From: Romain Perier @ 2021-09-10 19:03 UTC (permalink / raw)
To: Daniel Palmer, Romain Perier, Rob Herring, Arnd Bergmann,
Olof Johansson, soc
Cc: linux-arm-kernel, devicetree, linux-kernel
The Wireless Tag IDO-SBC2D06-V1B-22W[1] is an SBC powered by SSD202D
with a dual Ethernet and a connector for a 4-inch and 7-inch display.
It embeds a System-On-Module IDO-SOM2D01[2] with an Mstar SSD202 SoC
dual-core Cortex-A7 CPU @ 1.2Ghz , 2D GPU, 128 MB DDR3 (on-chip) and
a 256MB SPI NAND flash. This commit adds basic definition for this
board.
1. http://linux-chenxing.org/infinity2/ido-sbc2d06
2. http://www.wireless-tag.com/portfolio/ido-som2d01
Signed-off-by: Romain Perier <romain.perier@gmail.com>
---
.../devicetree/bindings/arm/mstar/mstar.yaml | 2 ++
arch/arm/boot/dts/Makefile | 1 +
...star-infinity2m-ssd201-som2d01-common.dtsi | 21 ++++++++++++++
...sd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts | 23 +++++++++++++++
...ity2m-ssd202d-wirelesstag-ido-som2d01.dtsi | 28 +++++++++++++++++++
5 files changed, 75 insertions(+)
create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi
create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
diff --git a/Documentation/devicetree/bindings/arm/mstar/mstar.yaml b/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
index a316eef1b728..10efd703717e 100644
--- a/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
+++ b/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
@@ -25,6 +25,8 @@ properties:
- enum:
- honestar,ssd201htv2 # Honestar SSD201_HT_V2 devkit
- m5stack,unitv2 # M5Stack UnitV2
+ - wirelesstag,ido-som2d01 # Wireless Tag IDO-SOM2D01
+ - wirelesstag,ido-sbc2d06-v1b-22w # Wireless Tag IDO-SBC2D06-1VB-22W
- const: mstar,infinity2m
- description: infinity3 boards
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 7e0934180724..7f0e92cea716 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1448,6 +1448,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \
dtb-$(CONFIG_ARCH_MILBEAUT) += milbeaut-m10v-evb.dtb
dtb-$(CONFIG_ARCH_MSTARV7) += \
mstar-infinity-msc313-breadbee_crust.dtb \
+ mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dtb \
mstar-infinity2m-ssd202d-ssd201htv2.dtb \
mstar-infinity2m-ssd202d-unitv2.dtb \
mstar-infinity3-msc313e-breadbee.dtb \
diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi b/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi
new file mode 100644
index 000000000000..0178d17ab15d
--- /dev/null
+++ b/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright (c) 2021 thingy.jp.
+ * Author: Daniel Palmer <daniel@thingy.jp>
+ * Author: Romain Perier <romain.perier@gmail.com>
+ */
+
+/ {
+
+ reg_vcc_dram: regulator-vcc-dram {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_dram";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ };
+};
+
+&pm_uart {
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
new file mode 100644
index 000000000000..20b40b711d4f
--- /dev/null
+++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright (c) 2021 thingy.jp.
+ * Author: Daniel Palmer <daniel@thingy.jp>
+ * Author: Romain Perier <romain.perier@gmail.com>
+ */
+
+/dts-v1/;
+#include "mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+ model = "Wireless Tag IDO-SBC2D06-1VB-22W";
+ compatible = "wirelesstag,ido-sbc2d06-v1b-22w", "wirelesstag,ido-som2d01", "mstar,infinity2m";
+
+ leds {
+ compatible = "gpio-leds";
+ sys_led {
+ gpios = <&gpio SSD20XD_GPIO_GPIO85 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+};
diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
new file mode 100644
index 000000000000..06567a5219c5
--- /dev/null
+++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright (c) 2021 thingy.jp.
+ * Author: Daniel Palmer <daniel@thingy.jp>
+ * Author: Romain Perier <romain.perier@gmail.com>
+ */
+
+/dts-v1/;
+#include "mstar-infinity2m-ssd202d.dtsi"
+#include "mstar-infinity2m-ssd201-som2d01-common.dtsi"
+
+/ {
+ model = "Wireless Tag IDO-SOM2D01 (SSD202D)";
+ compatible = "wirelesstag,ido-som2d01", "mstar,infinity2m";
+
+ aliases {
+ serial0 = &pm_uart;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+};
+
+®_vcc_dram {
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1500000>;
+};
--
2.33.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
2021-09-10 19:03 ` [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W Romain Perier
@ 2021-09-11 3:18 ` Daniel Palmer
2021-09-11 12:19 ` Romain Perier
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Palmer @ 2021-09-11 3:18 UTC (permalink / raw)
To: Romain Perier
Cc: Rob Herring, Arnd Bergmann, Olof Johansson, SoC Team,
linux-arm-kernel, DTML, Linux Kernel Mailing List
Hi Romain,
On Sat, 11 Sept 2021 at 04:03, Romain Perier <romain.perier@gmail.com> wrote:
> + - wirelesstag,ido-som2d01 # Wireless Tag IDO-SOM2D01
> + - wirelesstag,ido-sbc2d06-v1b-22w # Wireless Tag IDO-SBC2D06-1VB-22W
For anyone wondering why we have two strings here:
The SBC board is made up of a SoM and a board with the connectors.
The SoM could be used standalone so we might as well have a compatible
for it too.
We have some dtsis for the SoM but really those could be built as is
to support someone using the SoM on it's own.
> +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi
For anyone wondering:
The som2d01 can come with an SSD201 (64MB DDR2 integrated) or SSD202D
(128MB DDR3 integrated) and they need different fixed regulators for
the DDR supply.
So we have a common dtsi and then override the regulator in another
layer of dtsi for the SSD202D version.
Thinking about it now I think we can drop common from the file name.
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2021 thingy.jp.
> + * Author: Daniel Palmer <daniel@thingy.jp>
> + * Author: Romain Perier <romain.perier@gmail.com>
> + */
> +
> +/ {
> +
Unneeded space.
> + reg_vcc_dram: regulator-vcc-dram {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_dram";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + };
> +};
> +
> +&pm_uart {
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> new file mode 100644
> index 000000000000..20b40b711d4f
> --- /dev/null
> +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2021 thingy.jp.
> + * Author: Daniel Palmer <daniel@thingy.jp>
> + * Author: Romain Perier <romain.perier@gmail.com>
> + */
> +
> +/dts-v1/;
> +#include "mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> + model = "Wireless Tag IDO-SBC2D06-1VB-22W";
> + compatible = "wirelesstag,ido-sbc2d06-v1b-22w", "wirelesstag,ido-som2d01", "mstar,infinity2m";
> +
> + leds {
> + compatible = "gpio-leds";
> + sys_led {
> + gpios = <&gpio SSD20XD_GPIO_GPIO85 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +};
> diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
> new file mode 100644
> index 000000000000..06567a5219c5
> --- /dev/null
> +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2021 thingy.jp.
> + * Author: Daniel Palmer <daniel@thingy.jp>
> + * Author: Romain Perier <romain.perier@gmail.com>
> + */
> +
> +/dts-v1/;
> +#include "mstar-infinity2m-ssd202d.dtsi"
> +#include "mstar-infinity2m-ssd201-som2d01-common.dtsi"
> +
> +/ {
> + model = "Wireless Tag IDO-SOM2D01 (SSD202D)";
> + compatible = "wirelesstag,ido-som2d01", "mstar,infinity2m";
> +
> + aliases {
> + serial0 = &pm_uart;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +};
> +
> +®_vcc_dram {
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> +};
> --
> 2.33.0
>
Cheers,
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
2021-09-11 3:18 ` Daniel Palmer
@ 2021-09-11 12:19 ` Romain Perier
0 siblings, 0 replies; 14+ messages in thread
From: Romain Perier @ 2021-09-11 12:19 UTC (permalink / raw)
To: Daniel Palmer
Cc: Rob Herring, Arnd Bergmann, Olof Johansson, SoC Team,
linux-arm-kernel, DTML, Linux Kernel Mailing List
Hi Daniel,
Ack, I will fix it (remove "common" from the file name and the unneeded space)
Thanks,
Romain
Le sam. 11 sept. 2021 à 05:18, Daniel Palmer <daniel@0x0f.com> a écrit :
>
> Hi Romain,
>
> On Sat, 11 Sept 2021 at 04:03, Romain Perier <romain.perier@gmail.com> wrote:
> > + - wirelesstag,ido-som2d01 # Wireless Tag IDO-SOM2D01
> > + - wirelesstag,ido-sbc2d06-v1b-22w # Wireless Tag IDO-SBC2D06-1VB-22W
>
> For anyone wondering why we have two strings here:
> The SBC board is made up of a SoM and a board with the connectors.
> The SoM could be used standalone so we might as well have a compatible
> for it too.
> We have some dtsis for the SoM but really those could be built as is
> to support someone using the SoM on it's own.
>
> > +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi
>
> For anyone wondering:
>
> The som2d01 can come with an SSD201 (64MB DDR2 integrated) or SSD202D
> (128MB DDR3 integrated) and they need different fixed regulators for
> the DDR supply.
> So we have a common dtsi and then override the regulator in another
> layer of dtsi for the SSD202D version.
>
> Thinking about it now I think we can drop common from the file name.
>
> > @@ -0,0 +1,21 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > +/*
> > + * Copyright (c) 2021 thingy.jp.
> > + * Author: Daniel Palmer <daniel@thingy.jp>
> > + * Author: Romain Perier <romain.perier@gmail.com>
> > + */
> > +
> > +/ {
> > +
>
> Unneeded space.
>
> > + reg_vcc_dram: regulator-vcc-dram {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_dram";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-boot-on;
> > + };
> > +};
> > +
> > +&pm_uart {
> > + status = "okay";
> > +};
> > diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> > new file mode 100644
> > index 000000000000..20b40b711d4f
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> > @@ -0,0 +1,23 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > +/*
> > + * Copyright (c) 2021 thingy.jp.
> > + * Author: Daniel Palmer <daniel@thingy.jp>
> > + * Author: Romain Perier <romain.perier@gmail.com>
> > + */
> > +
> > +/dts-v1/;
> > +#include "mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi"
> > +#include <dt-bindings/gpio/gpio.h>
> > +
> > +/ {
> > + model = "Wireless Tag IDO-SBC2D06-1VB-22W";
> > + compatible = "wirelesstag,ido-sbc2d06-v1b-22w", "wirelesstag,ido-som2d01", "mstar,infinity2m";
> > +
> > + leds {
> > + compatible = "gpio-leds";
> > + sys_led {
> > + gpios = <&gpio SSD20XD_GPIO_GPIO85 GPIO_ACTIVE_LOW>;
> > + linux,default-trigger = "heartbeat";
> > + };
> > + };
> > +};
> > diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
> > new file mode 100644
> > index 000000000000..06567a5219c5
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
> > @@ -0,0 +1,28 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > +/*
> > + * Copyright (c) 2021 thingy.jp.
> > + * Author: Daniel Palmer <daniel@thingy.jp>
> > + * Author: Romain Perier <romain.perier@gmail.com>
> > + */
> > +
> > +/dts-v1/;
> > +#include "mstar-infinity2m-ssd202d.dtsi"
> > +#include "mstar-infinity2m-ssd201-som2d01-common.dtsi"
> > +
> > +/ {
> > + model = "Wireless Tag IDO-SOM2D01 (SSD202D)";
> > + compatible = "wirelesstag,ido-som2d01", "mstar,infinity2m";
> > +
> > + aliases {
> > + serial0 = &pm_uart;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0:115200n8";
> > + };
> > +};
> > +
> > +®_vcc_dram {
> > + regulator-min-microvolt = <1500000>;
> > + regulator-max-microvolt = <1500000>;
> > +};
> > --
> > 2.33.0
> >
>
> Cheers,
>
> Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/4] dt-bindings: add vendor prefix for Wireless Tag
2021-09-10 19:03 [PATCH 0/4] Add support for IDO-SBC2D06-V1B-22W Romain Perier
2021-09-10 19:03 ` [PATCH 1/4] ARM: mstar: Mark timer with arm,cpu-registers-not-fw-configured Romain Perier
2021-09-10 19:03 ` [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W Romain Perier
@ 2021-09-10 19:03 ` Romain Perier
2021-09-11 2:59 ` Daniel Palmer
2021-09-10 19:03 ` [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers Romain Perier
3 siblings, 1 reply; 14+ messages in thread
From: Romain Perier @ 2021-09-10 19:03 UTC (permalink / raw)
To: Daniel Palmer, Romain Perier, Rob Herring, Arnd Bergmann,
Olof Johansson, soc
Cc: linux-arm-kernel, devicetree, linux-kernel
This adds a vendor prefix for wireless tag boards and SOMs.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index a867f7102c35..b50d62dde7c5 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -517,6 +517,8 @@ patternProperties:
description: International Business Machines (IBM)
"^icplus,.*":
description: IC Plus Corp.
+ "^wirelesstag,.*":
+ description: Wireless Tag (qiming yunduan)
"^idt,.*":
description: Integrated Device Technologies, Inc.
"^ifi,.*":
--
2.33.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 3/4] dt-bindings: add vendor prefix for Wireless Tag
2021-09-10 19:03 ` [PATCH 3/4] dt-bindings: add vendor prefix for Wireless Tag Romain Perier
@ 2021-09-11 2:59 ` Daniel Palmer
2021-09-11 12:20 ` Romain Perier
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Palmer @ 2021-09-11 2:59 UTC (permalink / raw)
To: Romain Perier
Cc: Rob Herring, Arnd Bergmann, Olof Johansson, SoC Team,
linux-arm-kernel, DTML, Linux Kernel Mailing List
Hi Romain,
Sorry for sending this again. Gmail decided to switch to html email so
the first version bounced from the mailing lists.
On Sat, 11 Sept 2021 at 04:03, Romain Perier <romain.perier@gmail.com> wrote:
>
> This adds a vendor prefix for wireless tag boards and SOMs.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index a867f7102c35..b50d62dde7c5 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -517,6 +517,8 @@ patternProperties:
> description: International Business Machines (IBM)
> "^icplus,.*":
> description: IC Plus Corp.
> + "^wirelesstag,.*":
> + description: Wireless Tag (qiming yunduan)
> "^idt,.*":
> description: Integrated Device Technologies, Inc.
> "^ifi,.*":
> --
> 2.33.0
>
This should be in alphabetical order.
Also, this commit should be before adding the DT for the board I think.
The prefix should be in before something that uses it.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/4] dt-bindings: add vendor prefix for Wireless Tag
2021-09-11 2:59 ` Daniel Palmer
@ 2021-09-11 12:20 ` Romain Perier
0 siblings, 0 replies; 14+ messages in thread
From: Romain Perier @ 2021-09-11 12:20 UTC (permalink / raw)
To: Daniel Palmer
Cc: Rob Herring, Arnd Bergmann, Olof Johansson, SoC Team,
linux-arm-kernel, DTML, Linux Kernel Mailing List
Hi Daniel,
Le sam. 11 sept. 2021 à 04:59, Daniel Palmer <daniel@0x0f.com> a écrit :
>
> Hi Romain,
> Sorry for sending this again. Gmail decided to switch to html email so
> the first version bounced from the mailing lists.
>
> On Sat, 11 Sept 2021 at 04:03, Romain Perier <romain.perier@gmail.com> wrote:
> >
> > This adds a vendor prefix for wireless tag boards and SOMs.
> >
> > Signed-off-by: Romain Perier <romain.perier@gmail.com>
> > ---
> > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index a867f7102c35..b50d62dde7c5 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -517,6 +517,8 @@ patternProperties:
> > description: International Business Machines (IBM)
> > "^icplus,.*":
> > description: IC Plus Corp.
> > + "^wirelesstag,.*":
> > + description: Wireless Tag (qiming yunduan)
> > "^idt,.*":
> > description: Integrated Device Technologies, Inc.
> > "^ifi,.*":
> > --
> > 2.33.0
> >
>
> This should be in alphabetical order.
> Also, this commit should be before adding the DT for the board I think.
> The prefix should be in before something that uses it.
>
> Thanks,
Ack, I will fix it.
Cheers,
Romain
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
2021-09-10 19:03 [PATCH 0/4] Add support for IDO-SBC2D06-V1B-22W Romain Perier
` (2 preceding siblings ...)
2021-09-10 19:03 ` [PATCH 3/4] dt-bindings: add vendor prefix for Wireless Tag Romain Perier
@ 2021-09-10 19:03 ` Romain Perier
2021-09-11 2:56 ` Daniel Palmer
3 siblings, 1 reply; 14+ messages in thread
From: Romain Perier @ 2021-09-10 19:03 UTC (permalink / raw)
To: Daniel Palmer, Romain Perier, Rob Herring, Arnd Bergmann,
Olof Johansson, soc
Cc: linux-arm-kernel, devicetree, linux-kernel
As proposed by Daniel, I am going to help him to maintain the platform,
so add myself as co-maintainer.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3a9a7cbf9456..ad1a0e5a5425 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2231,6 +2231,7 @@ F: arch/arm/mach-pxa/mioa701.c
ARM/MStar/Sigmastar Armv7 SoC support
M: Daniel Palmer <daniel@thingy.jp>
+M: Romain Perier <romain.perier@gmail.com>
L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
S: Maintained
W: http://linux-chenxing.org/
--
2.33.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
2021-09-10 19:03 ` [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers Romain Perier
@ 2021-09-11 2:56 ` Daniel Palmer
2021-09-14 13:54 ` Arnd Bergmann
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Palmer @ 2021-09-11 2:56 UTC (permalink / raw)
To: Romain Perier
Cc: Rob Herring, Arnd Bergmann, Olof Johansson, SoC Team,
linux-arm-kernel, DTML, Linux Kernel Mailing List
Hi Romain,
On Sat, 11 Sept 2021 at 04:03, Romain Perier <romain.perier@gmail.com> wrote:
>
> As proposed by Daniel, I am going to help him to maintain the platform,
> so add myself as co-maintainer.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3a9a7cbf9456..ad1a0e5a5425 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2231,6 +2231,7 @@ F: arch/arm/mach-pxa/mioa701.c
>
> ARM/MStar/Sigmastar Armv7 SoC support
> M: Daniel Palmer <daniel@thingy.jp>
> +M: Romain Perier <romain.perier@gmail.com>
> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S: Maintained
> W: http://linux-chenxing.org/
> --
> 2.33.0
>
Acked-by: Daniel Palmer <daniel@thingy.jp>
For everyone else: For MStar/SigmaStar I have a ~350 commit backlog
that makes almost everything work on these machines.
It's impossible for me to finish up working out the hardware and clean
up and push patches without the whole process taking years.
Romain stepped up to help out and has been pulling out patches,
cleaning them up and pushing them. He deserves to be listed as a
maintainer.
Cheers,
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
2021-09-11 2:56 ` Daniel Palmer
@ 2021-09-14 13:54 ` Arnd Bergmann
2021-09-14 15:04 ` Daniel Palmer
0 siblings, 1 reply; 14+ messages in thread
From: Arnd Bergmann @ 2021-09-14 13:54 UTC (permalink / raw)
To: Daniel Palmer
Cc: Romain Perier, Rob Herring, Arnd Bergmann, Olof Johansson,
SoC Team, linux-arm-kernel, DTML, Linux Kernel Mailing List
On Sat, Sep 11, 2021 at 4:57 AM Daniel Palmer <daniel@0x0f.com> wrote:
> On Sat, 11 Sept 2021 at 04:03, Romain Perier <romain.perier@gmail.com> wrote:
> >
> > As proposed by Daniel, I am going to help him to maintain the platform,
> > so add myself as co-maintainer.
> >
> > Signed-off-by: Romain Perier <romain.perier@gmail.com>
> > ---
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3a9a7cbf9456..ad1a0e5a5425 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2231,6 +2231,7 @@ F: arch/arm/mach-pxa/mioa701.c
> >
> > ARM/MStar/Sigmastar Armv7 SoC support
> > M: Daniel Palmer <daniel@thingy.jp>
> > +M: Romain Perier <romain.perier@gmail.com>
> > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > S: Maintained
> > W: http://linux-chenxing.org/
> > --
> > 2.33.0
> >
>
> Acked-by: Daniel Palmer <daniel@thingy.jp>
>
> For everyone else: For MStar/SigmaStar I have a ~350 commit backlog
> that makes almost everything work on these machines.
> It's impossible for me to finish up working out the hardware and clean
> up and push patches without the whole process taking years.
> Romain stepped up to help out and has been pulling out patches,
> cleaning them up and pushing them. He deserves to be listed as a
> maintainer.
Sounds good to me.
One process issue though: These emails were sent 'cc:soc@kernel.org', so
they end up in patchwork, but I'm guessing they were not actually meant
for us to apply from there. I'm happy to take merge these patches (or
a future version of the series) directly from patchwork if that's what you
both had in mind, but for clarity please either
a) drop soc@kernel.org from Cc for patches that are meant for review
and will be part of a pull request.
or
b) put soc@kernel.org in the 'to:' field after they have been reviewed
and you want them to get merged.
Or even better, add an explicit sentence below the '---' line asking
for the patches to be merged directly into the soc tree when this
is what you want.
FWIW, I'd suggest merging the MAINTAINERS file change as a
bugfix for 5.15, it's generally better to do these as early as possible
to make sure any patches reach all the right people.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
2021-09-14 13:54 ` Arnd Bergmann
@ 2021-09-14 15:04 ` Daniel Palmer
2021-09-14 15:26 ` Arnd Bergmann
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Palmer @ 2021-09-14 15:04 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Romain Perier, Rob Herring, Olof Johansson, SoC Team,
linux-arm-kernel, DTML, Linux Kernel Mailing List
Hi Arnd,
On Tue, 14 Sept 2021 at 22:54, Arnd Bergmann <arnd@arndb.de> wrote:
> Sounds good to me.
>
> One process issue though: These emails were sent 'cc:soc@kernel.org', so
> they end up in patchwork, but I'm guessing they were not actually meant
> for us to apply from there. I'm happy to take merge these patches (or
> a future version of the series) directly from patchwork if that's what you
> both had in mind, but for clarity please either
>
> a) drop soc@kernel.org from Cc for patches that are meant for review
> and will be part of a pull request.
>
> or
>
> b) put soc@kernel.org in the 'to:' field after they have been reviewed
> and you want them to get merged.
Noted for the future. Until now we haven't done pull requests so
having the patches go into the soc patchwork made sense but from now
on we'll send pull requests when needed to you and Olof for the ARM
specific bits. Which I don't think there will be much aside from dts
stuff.
> Or even better, add an explicit sentence below the '---' line asking
> for the patches to be merged directly into the soc tree when this
> is what you want.
Noted.
> FWIW, I'd suggest merging the MAINTAINERS file change as a
> bugfix for 5.15, it's generally better to do these as early as possible
> to make sure any patches reach all the right people.
That makes sense.
Would it be possible for you to merge that single commit for me?
Seems like that would be easier than me creating a fixes branch for a
single commit, sending you a PR, finding out I still don't actually
know how to do PR properly.. :)
If it's a hassle I'll do the PR though.
Cheers,
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
2021-09-14 15:04 ` Daniel Palmer
@ 2021-09-14 15:26 ` Arnd Bergmann
2021-09-14 17:09 ` Romain Perier
0 siblings, 1 reply; 14+ messages in thread
From: Arnd Bergmann @ 2021-09-14 15:26 UTC (permalink / raw)
To: Daniel Palmer
Cc: Arnd Bergmann, Romain Perier, Rob Herring, Olof Johansson,
SoC Team, linux-arm-kernel, DTML, Linux Kernel Mailing List
On Tue, Sep 14, 2021 at 5:03 PM Daniel Palmer <daniel@0x0f.com> wrote:
> On Tue, 14 Sept 2021 at 22:54, Arnd Bergmann <arnd@arndb.de> wrote:
> > FWIW, I'd suggest merging the MAINTAINERS file change as a
> > bugfix for 5.15, it's generally better to do these as early as possible
> > to make sure any patches reach all the right people.
>
> That makes sense.
> Would it be possible for you to merge that single commit for me?
Done, merged into arm/fixes.
> Seems like that would be easier than me creating a fixes branch for a
> single commit, sending you a PR, finding out I still don't actually
> know how to do PR properly.. :)
> If it's a hassle I'll do the PR though.
If you only have one or two patches, sending that patch to soc@kernel.org
is usually the easiest way anyway, unless there is a reason to keep the
branch description separate from the patch description in the git log.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers
2021-09-14 15:26 ` Arnd Bergmann
@ 2021-09-14 17:09 ` Romain Perier
0 siblings, 0 replies; 14+ messages in thread
From: Romain Perier @ 2021-09-14 17:09 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Daniel Palmer, Rob Herring, Olof Johansson, linux-arm-kernel,
DTML, Linux Kernel Mailing List
Hi,
Thank you very much and sorry for the wrong inclusion of
soc@kernel.org, it's noted for the next time.
Regards,
Romain
Le mar. 14 sept. 2021 à 17:26, Arnd Bergmann <arnd@arndb.de> a écrit :
>
> On Tue, Sep 14, 2021 at 5:03 PM Daniel Palmer <daniel@0x0f.com> wrote:
> > On Tue, 14 Sept 2021 at 22:54, Arnd Bergmann <arnd@arndb.de> wrote:
>
> > > FWIW, I'd suggest merging the MAINTAINERS file change as a
> > > bugfix for 5.15, it's generally better to do these as early as possible
> > > to make sure any patches reach all the right people.
> >
> > That makes sense.
> > Would it be possible for you to merge that single commit for me?
>
> Done, merged into arm/fixes.
>
> > Seems like that would be easier than me creating a fixes branch for a
> > single commit, sending you a PR, finding out I still don't actually
> > know how to do PR properly.. :)
> > If it's a hassle I'll do the PR though.
>
> If you only have one or two patches, sending that patch to soc@kernel.org
> is usually the easiest way anyway, unless there is a reason to keep the
> branch description separate from the patch description in the git log.
>
> Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread