From: Josh Don <joshdon@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Joel Fernandes <joel@joelfernandes.org>,
Vineeth Pillai <vineethrp@gmail.com>, Hao Luo <haoluo@google.com>,
Tao Zhou <tao.zhou@linux.dev>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched/core: forced idle accounting
Date: Tue, 9 Nov 2021 14:59:33 -0800 [thread overview]
Message-ID: <CABk29NsaiO=4fG=0qGpQoSVgBMfw_rSo2DsC5mfgJvAvQcNQzQ@mail.gmail.com> (raw)
In-Reply-To: <YYpLiWCDBIOj4nvz@hirez.programming.kicks-ass.net>
On Tue, Nov 9, 2021 at 2:21 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Mon, Oct 18, 2021 at 01:34:28PM -0700, Josh Don wrote:
> > @@ -280,6 +288,8 @@ static void __sched_core_flip(bool enabled)
> > for_each_cpu(t, smt_mask)
> > cpu_rq(t)->core_enabled = enabled;
> >
> > + cpu_rq(cpu)->core->core_forceidle_start = 0;
> > +
> > sched_core_unlock(cpu, &flags);
> >
> > cpumask_andnot(&sched_core_mask, &sched_core_mask, smt_mask);
>
> Not specific to this patch, but perhaps we should do better here and
> explicitly initialize more state...
The others are not needed for correctness, but I do agree it makes
sense to keep the state consistent. I think that set is
core_pick
core_cookie
core_forceidle_count
core_forceidle_occupation
I can throw another patch on top of this to reset those as well.
next prev parent reply other threads:[~2021-11-09 22:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 20:34 [PATCH v2] sched/core: forced idle accounting Josh Don
2021-10-19 9:34 ` Tao Zhou
2021-11-09 10:20 ` Peter Zijlstra
2021-11-09 22:59 ` Josh Don [this message]
2021-11-09 11:15 ` Peter Zijlstra
2021-11-09 22:59 ` Josh Don
2021-11-10 8:38 ` Peter Zijlstra
2021-11-10 8:59 ` Peter Zijlstra
2021-11-10 18:59 ` Josh Don
2021-11-17 14:00 ` [tip: sched/core] sched/core: Forced " tip-bot2 for Josh Don
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABk29NsaiO=4fG=0qGpQoSVgBMfw_rSo2DsC5mfgJvAvQcNQzQ@mail.gmail.com' \
--to=joshdon@google.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=haoluo@google.com \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tao.zhou@linux.dev \
--cc=vincent.guittot@linaro.org \
--cc=vineethrp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).