linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Don <joshdon@google.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Vineeth Pillai <vineethrp@gmail.com>, Hao Luo <haoluo@google.com>,
	Tao Zhou <tao.zhou@linux.dev>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched/core: forced idle accounting
Date: Wed, 10 Nov 2021 09:38:53 +0100	[thread overview]
Message-ID: <YYuFHZCxtJe+BpWM@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CABk29NucnFxyPQ==n8-v=_hti2THkybrEkxruqJ_v8rvW4yacg@mail.gmail.com>

On Tue, Nov 09, 2021 at 02:59:00PM -0800, Josh Don wrote:
> On Tue, Nov 9, 2021 at 3:15 AM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Mon, Oct 18, 2021 at 01:34:28PM -0700, Josh Don wrote:
> > > @@ -5804,6 +5830,12 @@ pick_next_task(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
> > >               }
> > >       }
> > >
> > > +     if (rq->core->core_forceidle_count) {
> >
> > Does this want to be something like:
> >
> >         if (schedstat_enabled() && .. ) ?
> >
> > afaict without schedstat on this is dead code.
> >
> 
> Makes sense to me, and similarly we can bail out of sched_core_tick()
> early in the disabled case.

Ok, I already changed the patch to include the above, lemme also edit
sched_core_tick().

  reply	other threads:[~2021-11-10  8:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 20:34 [PATCH v2] sched/core: forced idle accounting Josh Don
2021-10-19  9:34 ` Tao Zhou
2021-11-09 10:20 ` Peter Zijlstra
2021-11-09 22:59   ` Josh Don
2021-11-09 11:15 ` Peter Zijlstra
2021-11-09 22:59   ` Josh Don
2021-11-10  8:38     ` Peter Zijlstra [this message]
2021-11-10  8:59       ` Peter Zijlstra
2021-11-10 18:59         ` Josh Don
2021-11-17 14:00 ` [tip: sched/core] sched/core: Forced " tip-bot2 for Josh Don

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYuFHZCxtJe+BpWM@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=haoluo@google.com \
    --cc=joel@joelfernandes.org \
    --cc=joshdon@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tao.zhou@linux.dev \
    --cc=vincent.guittot@linaro.org \
    --cc=vineethrp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).