From: Josh Don <joshdon@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
Nishanth Aravamudan <naravamudan@digitalocean.com>,
Julien Desfossez <jdesfossez@digitalocean.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Vineeth Pillai <viremana@linux.microsoft.com>,
Aaron Lu <aaron.lwe@gmail.com>,
Aubrey Li <aubrey.intel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
torvalds@linux-foundation.org, fweisbec@gmail.com,
Kees Cook <keescook@chromium.org>, Phil Auld <pauld@redhat.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Mel Gorman <mgorman@techsingularity.net>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
vineeth@bitbyteword.org, Chen Yu <yu.c.chen@intel.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Agata Gruza <agata.gruza@intel.com>,
Antonio Gomez Iglesias <antonio.gomez.iglesias@intel.com>,
graf@amazon.com, konrad.wilk@oracle.com, dfaggioli@suse.com,
Steven Rostedt <rostedt@goodmis.org>,
benbjiang@tencent.com,
Alexandre Chartre <alexandre.chartre@oracle.com>,
James.Bottomley@hansenpartnership.com, OWeisse@umich.edu,
Dhaval Giani <dhaval.giani@oracle.com>,
"Hyser,Chris" <chris.hyser@oracle.com>,
Hao Luo <haoluo@google.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 2/6] sched: tagging interface for core scheduling
Date: Mon, 22 Mar 2021 18:15:20 -0700 [thread overview]
Message-ID: <CABk29Nvp92i3_qsr4519XEa9=_XjKYemDpj2Ptk45wx90bYgFw@mail.gmail.com> (raw)
In-Reply-To: <20210320154632.GZ4746@worktop.programming.kicks-ass.net>
> > +static unsigned long sched_core_alloc_task_cookie(void)
> > +{
> > + struct sched_core_task_cookie *ck =
> > + kmalloc(sizeof(struct sched_core_task_cookie), GFP_KERNEL);
>
> struct sched_core_task_cookie *ck = kmalloc(sizeof(*ck), GFP_KERNEL);
>
> Also, those type names are unfortunately long..
>
> > +static void sched_core_get_task_cookie(unsigned long cookie)
> > +{
> > + struct sched_core_task_cookie *ptr =
> > + (struct sched_core_task_cookie *)cookie;
>
> struct sched_core_task_cookie *ptr = (void *)cookie;
>
> Know your language and use it to avoid typing excessively long names :-)
Good point, done. Keeping sched_core_task_cookie for now unless you'd
prefer a replacement, since it is only used internally by coretag.c.
next prev parent reply other threads:[~2021-03-23 1:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 20:32 [PATCH 0/6] Core scheduling remaining patches Joel Fernandes (Google)
2021-03-19 20:32 ` [PATCH 1/6] sched: migration changes for core scheduling Joel Fernandes (Google)
2021-03-20 15:34 ` Peter Zijlstra
2021-03-21 13:34 ` Li, Aubrey
2021-03-22 7:48 ` Peter Zijlstra
2021-03-22 8:12 ` Li, Aubrey
2021-03-22 8:57 ` Peter Zijlstra
2021-03-22 12:31 ` Li, Aubrey
2021-03-22 12:56 ` Peter Zijlstra
2021-03-22 13:17 ` Li, Aubrey
2021-03-23 3:54 ` Li, Aubrey
2021-03-23 21:21 ` Josh Don
2021-03-19 20:32 ` [PATCH 2/6] sched: tagging interface " Joel Fernandes (Google)
2021-03-20 15:46 ` Peter Zijlstra
2021-03-22 17:57 ` Chris Hyser
2021-03-22 18:33 ` Peter Zijlstra
2021-03-22 18:35 ` Chris Hyser
2021-03-23 1:15 ` Josh Don [this message]
2021-03-19 20:32 ` [PATCH 3/6] sched: prctl() cookie manipulation " Joel Fernandes (Google)
2021-03-20 15:51 ` Peter Zijlstra
2021-03-19 20:32 ` [PATCH 4/6] kselftest: Add tests for core-sched interface Joel Fernandes (Google)
2021-03-19 20:32 ` [PATCH 5/6] Documentation: Add core scheduling documentation Joel Fernandes (Google)
2021-03-19 20:32 ` [PATCH 6/6] sched: Debug bits Joel Fernandes (Google)
2021-03-20 15:40 ` [PATCH 0/6] Core scheduling remaining patches Peter Zijlstra
2021-03-22 14:57 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABk29Nvp92i3_qsr4519XEa9=_XjKYemDpj2Ptk45wx90bYgFw@mail.gmail.com' \
--to=joshdon@google.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=OWeisse@umich.edu \
--cc=aaron.lwe@gmail.com \
--cc=agata.gruza@intel.com \
--cc=alexandre.chartre@oracle.com \
--cc=antonio.gomez.iglesias@intel.com \
--cc=aubrey.intel@gmail.com \
--cc=benbjiang@tencent.com \
--cc=chris.hyser@oracle.com \
--cc=christian.brauner@ubuntu.com \
--cc=dfaggioli@suse.com \
--cc=dhaval.giani@oracle.com \
--cc=fweisbec@gmail.com \
--cc=graf@amazon.com \
--cc=haoluo@google.com \
--cc=jdesfossez@digitalocean.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=naravamudan@digitalocean.com \
--cc=pauld@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=valentin.schneider@arm.com \
--cc=vineeth@bitbyteword.org \
--cc=viremana@linux.microsoft.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).