* [PATCH] ARM: dts: NSP: Correct RAM amount for BCM958625HR board
@ 2016-07-13 18:18 Jon Mason
2016-07-13 21:23 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Jon Mason @ 2016-07-13 18:18 UTC (permalink / raw)
To: f.fainelli
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, linux-kernel,
devicetree, linux-arm-kernel
The BCM958625HR board has 2GB of RAM available. Increase the amount
from 512MB to 2GB and add the device type to the memory entry.
Signed-off-by: Jon Mason <jon.mason@broadcom.com>
---
arch/arm/boot/dts/bcm958625hr.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
index 4239e58..66c658a 100644
--- a/arch/arm/boot/dts/bcm958625hr.dts
+++ b/arch/arm/boot/dts/bcm958625hr.dts
@@ -47,7 +47,8 @@
};
memory {
- reg = <0x60000000 0x20000000>;
+ device_type = "memory";
+ reg = <0x60000000 0x40000000>;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: NSP: Correct RAM amount for BCM958625HR board
2016-07-13 18:18 [PATCH] ARM: dts: NSP: Correct RAM amount for BCM958625HR board Jon Mason
@ 2016-07-13 21:23 ` Florian Fainelli
2016-07-14 18:18 ` Jon Mason
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2016-07-13 21:23 UTC (permalink / raw)
To: Jon Mason, f.fainelli
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, linux-kernel,
devicetree, linux-arm-kernel
On 07/13/2016 11:18 AM, Jon Mason wrote:
> The BCM958625HR board has 2GB of RAM available. Increase the amount
> from 512MB to 2GB and add the device type to the memory entry.
>
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> ---
> arch/arm/boot/dts/bcm958625hr.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
> index 4239e58..66c658a 100644
> --- a/arch/arm/boot/dts/bcm958625hr.dts
> +++ b/arch/arm/boot/dts/bcm958625hr.dts
> @@ -47,7 +47,8 @@
> };
>
> memory {
> - reg = <0x60000000 0x20000000>;
> + device_type = "memory";
> + reg = <0x60000000 0x40000000>;
That's just one 1GB, did you intend to provide 0x8000_0000 instead here?
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: NSP: Correct RAM amount for BCM958625HR board
2016-07-13 21:23 ` Florian Fainelli
@ 2016-07-14 18:18 ` Jon Mason
0 siblings, 0 replies; 3+ messages in thread
From: Jon Mason @ 2016-07-14 18:18 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Ray Jui, Scott Branden, BCM Kernel Feedback, linux-kernel,
devicetree, linux-arm-kernel
On Wed, Jul 13, 2016 at 5:23 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 07/13/2016 11:18 AM, Jon Mason wrote:
>> The BCM958625HR board has 2GB of RAM available. Increase the amount
>> from 512MB to 2GB and add the device type to the memory entry.
>>
>> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>> ---
>> arch/arm/boot/dts/bcm958625hr.dts | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
>> index 4239e58..66c658a 100644
>> --- a/arch/arm/boot/dts/bcm958625hr.dts
>> +++ b/arch/arm/boot/dts/bcm958625hr.dts
>> @@ -47,7 +47,8 @@
>> };
>>
>> memory {
>> - reg = <0x60000000 0x20000000>;
>> + device_type = "memory";
>> + reg = <0x60000000 0x40000000>;
>
> That's just one 1GB, did you intend to provide 0x8000_0000 instead here?
Good catch! I'll fix that up in v2 (and add a "Fixes:" referencing
the original patch).
Thanks,
Jon
> --
> Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-14 18:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-13 18:18 [PATCH] ARM: dts: NSP: Correct RAM amount for BCM958625HR board Jon Mason
2016-07-13 21:23 ` Florian Fainelli
2016-07-14 18:18 ` Jon Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).