linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] vdpa/mlx5: Fix MQ to support non power of two num queues
@ 2022-09-12 12:50 Eli Cohen
  2022-09-14  4:44 ` Jason Wang
  2022-09-14 11:14 ` Si-Wei Liu
  0 siblings, 2 replies; 4+ messages in thread
From: Eli Cohen @ 2022-09-12 12:50 UTC (permalink / raw)
  To: mst, jasowang, eperezma, si-wei.liu, virtualization, linux-kernel
  Cc: Eli Cohen

RQT objects require that a power of two value be configured for both
rqt_max_size and rqt_actual size.

For create_rqt, make sure to round up to the power of two the value of
given by the user who created the vdpa device and given by
ndev->rqt_size. The actual size is also rounded up to the power of two
using the current number of VQs given by ndev->cur_num_vqs.

Same goes with modify_rqt where we need to make sure act size is power
of two based on the new number of QPs.

Without this patch, attempt to create a device with non power of two QPs
would result in error from firmware.

Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")
Signed-off-by: Eli Cohen <elic@nvidia.com>
---
 drivers/vdpa/mlx5/net/mlx5_vnet.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index ed100a35e596..90913365def4 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1320,6 +1320,8 @@ static void teardown_vq(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue *
 
 static int create_rqt(struct mlx5_vdpa_net *ndev)
 {
+	int rqt_table_size = roundup_pow_of_two(ndev->rqt_size);
+	int act_sz = roundup_pow_of_two(ndev->cur_num_vqs / 2);
 	__be32 *list;
 	void *rqtc;
 	int inlen;
@@ -1327,7 +1329,7 @@ static int create_rqt(struct mlx5_vdpa_net *ndev)
 	int i, j;
 	int err;
 
-	inlen = MLX5_ST_SZ_BYTES(create_rqt_in) + ndev->rqt_size * MLX5_ST_SZ_BYTES(rq_num);
+	inlen = MLX5_ST_SZ_BYTES(create_rqt_in) + rqt_table_size * MLX5_ST_SZ_BYTES(rq_num);
 	in = kzalloc(inlen, GFP_KERNEL);
 	if (!in)
 		return -ENOMEM;
@@ -1336,12 +1338,12 @@ static int create_rqt(struct mlx5_vdpa_net *ndev)
 	rqtc = MLX5_ADDR_OF(create_rqt_in, in, rqt_context);
 
 	MLX5_SET(rqtc, rqtc, list_q_type, MLX5_RQTC_LIST_Q_TYPE_VIRTIO_NET_Q);
-	MLX5_SET(rqtc, rqtc, rqt_max_size, ndev->rqt_size);
+	MLX5_SET(rqtc, rqtc, rqt_max_size, rqt_table_size);
 	list = MLX5_ADDR_OF(rqtc, rqtc, rq_num[0]);
-	for (i = 0, j = 0; i < ndev->rqt_size; i++, j += 2)
+	for (i = 0, j = 0; i < act_sz; i++, j += 2)
 		list[i] = cpu_to_be32(ndev->vqs[j % ndev->cur_num_vqs].virtq_id);
 
-	MLX5_SET(rqtc, rqtc, rqt_actual_size, ndev->rqt_size);
+	MLX5_SET(rqtc, rqtc, rqt_actual_size, act_sz);
 	err = mlx5_vdpa_create_rqt(&ndev->mvdev, in, inlen, &ndev->res.rqtn);
 	kfree(in);
 	if (err)
@@ -1354,6 +1356,7 @@ static int create_rqt(struct mlx5_vdpa_net *ndev)
 
 static int modify_rqt(struct mlx5_vdpa_net *ndev, int num)
 {
+	int act_sz = roundup_pow_of_two(num / 2);
 	__be32 *list;
 	void *rqtc;
 	int inlen;
@@ -1361,7 +1364,7 @@ static int modify_rqt(struct mlx5_vdpa_net *ndev, int num)
 	int i, j;
 	int err;
 
-	inlen = MLX5_ST_SZ_BYTES(modify_rqt_in) + ndev->rqt_size * MLX5_ST_SZ_BYTES(rq_num);
+	inlen = MLX5_ST_SZ_BYTES(modify_rqt_in) + act_sz * MLX5_ST_SZ_BYTES(rq_num);
 	in = kzalloc(inlen, GFP_KERNEL);
 	if (!in)
 		return -ENOMEM;
@@ -1372,10 +1375,10 @@ static int modify_rqt(struct mlx5_vdpa_net *ndev, int num)
 	MLX5_SET(rqtc, rqtc, list_q_type, MLX5_RQTC_LIST_Q_TYPE_VIRTIO_NET_Q);
 
 	list = MLX5_ADDR_OF(rqtc, rqtc, rq_num[0]);
-	for (i = 0, j = 0; i < ndev->rqt_size; i++, j += 2)
+	for (i = 0, j = 0; i < act_sz; i++, j = j + 2)
 		list[i] = cpu_to_be32(ndev->vqs[j % num].virtq_id);
 
-	MLX5_SET(rqtc, rqtc, rqt_actual_size, ndev->rqt_size);
+	MLX5_SET(rqtc, rqtc, rqt_actual_size, act_sz);
 	err = mlx5_vdpa_modify_rqt(&ndev->mvdev, in, inlen, ndev->res.rqtn);
 	kfree(in);
 	if (err)
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] vdpa/mlx5: Fix MQ to support non power of two num queues
  2022-09-12 12:50 [PATCH] vdpa/mlx5: Fix MQ to support non power of two num queues Eli Cohen
@ 2022-09-14  4:44 ` Jason Wang
  2022-09-14 11:14 ` Si-Wei Liu
  1 sibling, 0 replies; 4+ messages in thread
From: Jason Wang @ 2022-09-14  4:44 UTC (permalink / raw)
  To: Eli Cohen; +Cc: mst, eperezma, Si-Wei Liu, virtualization, linux-kernel

On Mon, Sep 12, 2022 at 8:50 PM Eli Cohen <elic@nvidia.com> wrote:
>
> RQT objects require that a power of two value be configured for both
> rqt_max_size and rqt_actual size.
>
> For create_rqt, make sure to round up to the power of two the value of
> given by the user who created the vdpa device and given by
> ndev->rqt_size. The actual size is also rounded up to the power of two
> using the current number of VQs given by ndev->cur_num_vqs.
>
> Same goes with modify_rqt where we need to make sure act size is power
> of two based on the new number of QPs.
>
> Without this patch, attempt to create a device with non power of two QPs
> would result in error from firmware.
>
> Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")
> Signed-off-by: Eli Cohen <elic@nvidia.com>

Acked-by: Jason Wang <jasowang@redhat.com>

> ---
>  drivers/vdpa/mlx5/net/mlx5_vnet.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index ed100a35e596..90913365def4 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1320,6 +1320,8 @@ static void teardown_vq(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue *
>
>  static int create_rqt(struct mlx5_vdpa_net *ndev)
>  {
> +       int rqt_table_size = roundup_pow_of_two(ndev->rqt_size);
> +       int act_sz = roundup_pow_of_two(ndev->cur_num_vqs / 2);
>         __be32 *list;
>         void *rqtc;
>         int inlen;
> @@ -1327,7 +1329,7 @@ static int create_rqt(struct mlx5_vdpa_net *ndev)
>         int i, j;
>         int err;
>
> -       inlen = MLX5_ST_SZ_BYTES(create_rqt_in) + ndev->rqt_size * MLX5_ST_SZ_BYTES(rq_num);
> +       inlen = MLX5_ST_SZ_BYTES(create_rqt_in) + rqt_table_size * MLX5_ST_SZ_BYTES(rq_num);
>         in = kzalloc(inlen, GFP_KERNEL);
>         if (!in)
>                 return -ENOMEM;
> @@ -1336,12 +1338,12 @@ static int create_rqt(struct mlx5_vdpa_net *ndev)
>         rqtc = MLX5_ADDR_OF(create_rqt_in, in, rqt_context);
>
>         MLX5_SET(rqtc, rqtc, list_q_type, MLX5_RQTC_LIST_Q_TYPE_VIRTIO_NET_Q);
> -       MLX5_SET(rqtc, rqtc, rqt_max_size, ndev->rqt_size);
> +       MLX5_SET(rqtc, rqtc, rqt_max_size, rqt_table_size);
>         list = MLX5_ADDR_OF(rqtc, rqtc, rq_num[0]);
> -       for (i = 0, j = 0; i < ndev->rqt_size; i++, j += 2)
> +       for (i = 0, j = 0; i < act_sz; i++, j += 2)
>                 list[i] = cpu_to_be32(ndev->vqs[j % ndev->cur_num_vqs].virtq_id);
>
> -       MLX5_SET(rqtc, rqtc, rqt_actual_size, ndev->rqt_size);
> +       MLX5_SET(rqtc, rqtc, rqt_actual_size, act_sz);
>         err = mlx5_vdpa_create_rqt(&ndev->mvdev, in, inlen, &ndev->res.rqtn);
>         kfree(in);
>         if (err)
> @@ -1354,6 +1356,7 @@ static int create_rqt(struct mlx5_vdpa_net *ndev)
>
>  static int modify_rqt(struct mlx5_vdpa_net *ndev, int num)
>  {
> +       int act_sz = roundup_pow_of_two(num / 2);
>         __be32 *list;
>         void *rqtc;
>         int inlen;
> @@ -1361,7 +1364,7 @@ static int modify_rqt(struct mlx5_vdpa_net *ndev, int num)
>         int i, j;
>         int err;
>
> -       inlen = MLX5_ST_SZ_BYTES(modify_rqt_in) + ndev->rqt_size * MLX5_ST_SZ_BYTES(rq_num);
> +       inlen = MLX5_ST_SZ_BYTES(modify_rqt_in) + act_sz * MLX5_ST_SZ_BYTES(rq_num);
>         in = kzalloc(inlen, GFP_KERNEL);
>         if (!in)
>                 return -ENOMEM;
> @@ -1372,10 +1375,10 @@ static int modify_rqt(struct mlx5_vdpa_net *ndev, int num)
>         MLX5_SET(rqtc, rqtc, list_q_type, MLX5_RQTC_LIST_Q_TYPE_VIRTIO_NET_Q);
>
>         list = MLX5_ADDR_OF(rqtc, rqtc, rq_num[0]);
> -       for (i = 0, j = 0; i < ndev->rqt_size; i++, j += 2)
> +       for (i = 0, j = 0; i < act_sz; i++, j = j + 2)
>                 list[i] = cpu_to_be32(ndev->vqs[j % num].virtq_id);
>
> -       MLX5_SET(rqtc, rqtc, rqt_actual_size, ndev->rqt_size);
> +       MLX5_SET(rqtc, rqtc, rqt_actual_size, act_sz);
>         err = mlx5_vdpa_modify_rqt(&ndev->mvdev, in, inlen, ndev->res.rqtn);
>         kfree(in);
>         if (err)
> --
> 2.35.1
>


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] vdpa/mlx5: Fix MQ to support non power of two num queues
  2022-09-12 12:50 [PATCH] vdpa/mlx5: Fix MQ to support non power of two num queues Eli Cohen
  2022-09-14  4:44 ` Jason Wang
@ 2022-09-14 11:14 ` Si-Wei Liu
  2022-09-14 12:23   ` Eli Cohen
  1 sibling, 1 reply; 4+ messages in thread
From: Si-Wei Liu @ 2022-09-14 11:14 UTC (permalink / raw)
  To: Eli Cohen, mst, jasowang, eperezma, virtualization, linux-kernel



On 9/12/2022 1:50 PM, Eli Cohen wrote:
> RQT objects require that a power of two value be configured for both
> rqt_max_size and rqt_actual size.
>
> For create_rqt, make sure to round up to the power of two the value of
> given by the user who created the vdpa device and given by
> ndev->rqt_size. The actual size is also rounded up to the power of two
> using the current number of VQs given by ndev->cur_num_vqs.
>
> Same goes with modify_rqt where we need to make sure act size is power
> of two based on the new number of QPs.
>
> Without this patch, attempt to create a device with non power of two QPs
> would result in error from firmware.

What kind of error would it end up with, is there explicit warning in 
dmesg or it's just implicit? And is there performance impact? It'd be 
nice to add such description that we can easily match the symptom just 
in case.

>
> Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")
> Signed-off-by: Eli Cohen <elic@nvidia.com>
Acked-by: Si-Wei Liu <si-wei.liu@oracle.com>

Thanks,
-Siwei
> ---
>   drivers/vdpa/mlx5/net/mlx5_vnet.c | 17 ++++++++++-------
>   1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index ed100a35e596..90913365def4 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1320,6 +1320,8 @@ static void teardown_vq(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue *
>   
>   static int create_rqt(struct mlx5_vdpa_net *ndev)
>   {
> +	int rqt_table_size = roundup_pow_of_two(ndev->rqt_size);
> +	int act_sz = roundup_pow_of_two(ndev->cur_num_vqs / 2);
>   	__be32 *list;
>   	void *rqtc;
>   	int inlen;
> @@ -1327,7 +1329,7 @@ static int create_rqt(struct mlx5_vdpa_net *ndev)
>   	int i, j;
>   	int err;
>   
> -	inlen = MLX5_ST_SZ_BYTES(create_rqt_in) + ndev->rqt_size * MLX5_ST_SZ_BYTES(rq_num);
> +	inlen = MLX5_ST_SZ_BYTES(create_rqt_in) + rqt_table_size * MLX5_ST_SZ_BYTES(rq_num);
>   	in = kzalloc(inlen, GFP_KERNEL);
>   	if (!in)
>   		return -ENOMEM;
> @@ -1336,12 +1338,12 @@ static int create_rqt(struct mlx5_vdpa_net *ndev)
>   	rqtc = MLX5_ADDR_OF(create_rqt_in, in, rqt_context);
>   
>   	MLX5_SET(rqtc, rqtc, list_q_type, MLX5_RQTC_LIST_Q_TYPE_VIRTIO_NET_Q);
> -	MLX5_SET(rqtc, rqtc, rqt_max_size, ndev->rqt_size);
> +	MLX5_SET(rqtc, rqtc, rqt_max_size, rqt_table_size);
>   	list = MLX5_ADDR_OF(rqtc, rqtc, rq_num[0]);
> -	for (i = 0, j = 0; i < ndev->rqt_size; i++, j += 2)
> +	for (i = 0, j = 0; i < act_sz; i++, j += 2)
>   		list[i] = cpu_to_be32(ndev->vqs[j % ndev->cur_num_vqs].virtq_id);
>   
> -	MLX5_SET(rqtc, rqtc, rqt_actual_size, ndev->rqt_size);
> +	MLX5_SET(rqtc, rqtc, rqt_actual_size, act_sz);
>   	err = mlx5_vdpa_create_rqt(&ndev->mvdev, in, inlen, &ndev->res.rqtn);
>   	kfree(in);
>   	if (err)
> @@ -1354,6 +1356,7 @@ static int create_rqt(struct mlx5_vdpa_net *ndev)
>   
>   static int modify_rqt(struct mlx5_vdpa_net *ndev, int num)
>   {
> +	int act_sz = roundup_pow_of_two(num / 2);
>   	__be32 *list;
>   	void *rqtc;
>   	int inlen;
> @@ -1361,7 +1364,7 @@ static int modify_rqt(struct mlx5_vdpa_net *ndev, int num)
>   	int i, j;
>   	int err;
>   
> -	inlen = MLX5_ST_SZ_BYTES(modify_rqt_in) + ndev->rqt_size * MLX5_ST_SZ_BYTES(rq_num);
> +	inlen = MLX5_ST_SZ_BYTES(modify_rqt_in) + act_sz * MLX5_ST_SZ_BYTES(rq_num);
>   	in = kzalloc(inlen, GFP_KERNEL);
>   	if (!in)
>   		return -ENOMEM;
> @@ -1372,10 +1375,10 @@ static int modify_rqt(struct mlx5_vdpa_net *ndev, int num)
>   	MLX5_SET(rqtc, rqtc, list_q_type, MLX5_RQTC_LIST_Q_TYPE_VIRTIO_NET_Q);
>   
>   	list = MLX5_ADDR_OF(rqtc, rqtc, rq_num[0]);
> -	for (i = 0, j = 0; i < ndev->rqt_size; i++, j += 2)
> +	for (i = 0, j = 0; i < act_sz; i++, j = j + 2)
>   		list[i] = cpu_to_be32(ndev->vqs[j % num].virtq_id);
>   
> -	MLX5_SET(rqtc, rqtc, rqt_actual_size, ndev->rqt_size);
> +	MLX5_SET(rqtc, rqtc, rqt_actual_size, act_sz);
>   	err = mlx5_vdpa_modify_rqt(&ndev->mvdev, in, inlen, ndev->res.rqtn);
>   	kfree(in);
>   	if (err)


^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] vdpa/mlx5: Fix MQ to support non power of two num queues
  2022-09-14 11:14 ` Si-Wei Liu
@ 2022-09-14 12:23   ` Eli Cohen
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Cohen @ 2022-09-14 12:23 UTC (permalink / raw)
  To: Si-Wei Liu, mst, jasowang, eperezma, virtualization, linux-kernel

> From: Si-Wei Liu <si-wei.liu@oracle.com>
> Sent: Wednesday, 14 September 2022 14:15
> To: Eli Cohen <elic@nvidia.com>; mst@redhat.com; jasowang@redhat.com;
> eperezma@redhat.com; virtualization@lists.linux-foundation.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] vdpa/mlx5: Fix MQ to support non power of two num
> queues
> 
> 
> 
> On 9/12/2022 1:50 PM, Eli Cohen wrote:
> > RQT objects require that a power of two value be configured for both
> > rqt_max_size and rqt_actual size.
> >
> > For create_rqt, make sure to round up to the power of two the value of
> > given by the user who created the vdpa device and given by
> > ndev->rqt_size. The actual size is also rounded up to the power of two
> > using the current number of VQs given by ndev->cur_num_vqs.
> >
> > Same goes with modify_rqt where we need to make sure act size is power
> > of two based on the new number of QPs.
> >
> > Without this patch, attempt to create a device with non power of two QPs
> > would result in error from firmware.
> 
> What kind of error would it end up with, is there explicit warning in
> dmesg or it's just implicit?
The error would look something like this:
[Sep14 15:20] mlx5_core.sf mlx5_core.sf.6: mlx5_cmd_out_err:778:(pid 3466): CREATE_RQT(0x916) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x538fab), err(-22)

> And is there performance impact? It'd be
> nice to add such description that we can easily match the symptom just
> in case.
> 
I don't think there would be performance impact but I haven't checked performance with this fix.

> >
> > Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")
> > Signed-off-by: Eli Cohen <elic@nvidia.com>
> Acked-by: Si-Wei Liu <si-wei.liu@oracle.com>
> 
> Thanks,
> -Siwei
> > ---
> >   drivers/vdpa/mlx5/net/mlx5_vnet.c | 17 ++++++++++-------
> >   1 file changed, 10 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > index ed100a35e596..90913365def4 100644
> > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > @@ -1320,6 +1320,8 @@ static void teardown_vq(struct mlx5_vdpa_net
> *ndev, struct mlx5_vdpa_virtqueue *
> >
> >   static int create_rqt(struct mlx5_vdpa_net *ndev)
> >   {
> > +	int rqt_table_size = roundup_pow_of_two(ndev->rqt_size);
> > +	int act_sz = roundup_pow_of_two(ndev->cur_num_vqs / 2);
> >   	__be32 *list;
> >   	void *rqtc;
> >   	int inlen;
> > @@ -1327,7 +1329,7 @@ static int create_rqt(struct mlx5_vdpa_net
> *ndev)
> >   	int i, j;
> >   	int err;
> >
> > -	inlen = MLX5_ST_SZ_BYTES(create_rqt_in) + ndev->rqt_size *
> MLX5_ST_SZ_BYTES(rq_num);
> > +	inlen = MLX5_ST_SZ_BYTES(create_rqt_in) + rqt_table_size *
> MLX5_ST_SZ_BYTES(rq_num);
> >   	in = kzalloc(inlen, GFP_KERNEL);
> >   	if (!in)
> >   		return -ENOMEM;
> > @@ -1336,12 +1338,12 @@ static int create_rqt(struct mlx5_vdpa_net
> *ndev)
> >   	rqtc = MLX5_ADDR_OF(create_rqt_in, in, rqt_context);
> >
> >   	MLX5_SET(rqtc, rqtc, list_q_type,
> MLX5_RQTC_LIST_Q_TYPE_VIRTIO_NET_Q);
> > -	MLX5_SET(rqtc, rqtc, rqt_max_size, ndev->rqt_size);
> > +	MLX5_SET(rqtc, rqtc, rqt_max_size, rqt_table_size);
> >   	list = MLX5_ADDR_OF(rqtc, rqtc, rq_num[0]);
> > -	for (i = 0, j = 0; i < ndev->rqt_size; i++, j += 2)
> > +	for (i = 0, j = 0; i < act_sz; i++, j += 2)
> >   		list[i] = cpu_to_be32(ndev->vqs[j % ndev-
> >cur_num_vqs].virtq_id);
> >
> > -	MLX5_SET(rqtc, rqtc, rqt_actual_size, ndev->rqt_size);
> > +	MLX5_SET(rqtc, rqtc, rqt_actual_size, act_sz);
> >   	err = mlx5_vdpa_create_rqt(&ndev->mvdev, in, inlen, &ndev-
> >res.rqtn);
> >   	kfree(in);
> >   	if (err)
> > @@ -1354,6 +1356,7 @@ static int create_rqt(struct mlx5_vdpa_net
> *ndev)
> >
> >   static int modify_rqt(struct mlx5_vdpa_net *ndev, int num)
> >   {
> > +	int act_sz = roundup_pow_of_two(num / 2);
> >   	__be32 *list;
> >   	void *rqtc;
> >   	int inlen;
> > @@ -1361,7 +1364,7 @@ static int modify_rqt(struct mlx5_vdpa_net
> *ndev, int num)
> >   	int i, j;
> >   	int err;
> >
> > -	inlen = MLX5_ST_SZ_BYTES(modify_rqt_in) + ndev->rqt_size *
> MLX5_ST_SZ_BYTES(rq_num);
> > +	inlen = MLX5_ST_SZ_BYTES(modify_rqt_in) + act_sz *
> MLX5_ST_SZ_BYTES(rq_num);
> >   	in = kzalloc(inlen, GFP_KERNEL);
> >   	if (!in)
> >   		return -ENOMEM;
> > @@ -1372,10 +1375,10 @@ static int modify_rqt(struct mlx5_vdpa_net
> *ndev, int num)
> >   	MLX5_SET(rqtc, rqtc, list_q_type,
> MLX5_RQTC_LIST_Q_TYPE_VIRTIO_NET_Q);
> >
> >   	list = MLX5_ADDR_OF(rqtc, rqtc, rq_num[0]);
> > -	for (i = 0, j = 0; i < ndev->rqt_size; i++, j += 2)
> > +	for (i = 0, j = 0; i < act_sz; i++, j = j + 2)
> >   		list[i] = cpu_to_be32(ndev->vqs[j % num].virtq_id);
> >
> > -	MLX5_SET(rqtc, rqtc, rqt_actual_size, ndev->rqt_size);
> > +	MLX5_SET(rqtc, rqtc, rqt_actual_size, act_sz);
> >   	err = mlx5_vdpa_modify_rqt(&ndev->mvdev, in, inlen, ndev-
> >res.rqtn);
> >   	kfree(in);
> >   	if (err)


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-14 12:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-12 12:50 [PATCH] vdpa/mlx5: Fix MQ to support non power of two num queues Eli Cohen
2022-09-14  4:44 ` Jason Wang
2022-09-14 11:14 ` Si-Wei Liu
2022-09-14 12:23   ` Eli Cohen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).