* [PATCH net-next] bnxt_en: Link representors to PCI device
@ 2023-06-20 14:48 Ivan Vecera
2023-06-20 15:54 ` Simon Horman
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Ivan Vecera @ 2023-06-20 14:48 UTC (permalink / raw)
To: netdev
Cc: Michael Chan, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, open list
Link VF representors to parent PCI device to benefit from
systemd defined naming scheme.
Without this change the representor is visible as ethN.
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
index 2f1a1f2d2157..1467b94a6427 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
@@ -468,6 +468,7 @@ static void bnxt_vf_rep_netdev_init(struct bnxt *bp, struct bnxt_vf_rep *vf_rep,
struct net_device *pf_dev = bp->dev;
u16 max_mtu;
+ SET_NETDEV_DEV(dev, &bp->pdev->dev);
dev->netdev_ops = &bnxt_vf_rep_netdev_ops;
dev->ethtool_ops = &bnxt_vf_rep_ethtool_ops;
/* Just inherit all the featues of the parent PF as the VF-R
--
2.39.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] bnxt_en: Link representors to PCI device
2023-06-20 14:48 [PATCH net-next] bnxt_en: Link representors to PCI device Ivan Vecera
@ 2023-06-20 15:54 ` Simon Horman
2023-06-20 16:49 ` Sriharsha Basavapatna
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2023-06-20 15:54 UTC (permalink / raw)
To: Ivan Vecera
Cc: netdev, Michael Chan, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, open list
On Tue, Jun 20, 2023 at 04:48:55PM +0200, Ivan Vecera wrote:
> Link VF representors to parent PCI device to benefit from
> systemd defined naming scheme.
>
> Without this change the representor is visible as ethN.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] bnxt_en: Link representors to PCI device
2023-06-20 14:48 [PATCH net-next] bnxt_en: Link representors to PCI device Ivan Vecera
2023-06-20 15:54 ` Simon Horman
@ 2023-06-20 16:49 ` Sriharsha Basavapatna
2023-06-20 16:56 ` Jakub Kicinski
2023-06-20 17:26 ` Michael Chan
2023-06-21 21:10 ` patchwork-bot+netdevbpf
3 siblings, 1 reply; 8+ messages in thread
From: Sriharsha Basavapatna @ 2023-06-20 16:49 UTC (permalink / raw)
To: Ivan Vecera
Cc: netdev, Michael Chan, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, open list, Sriharsha Basavapatna
[-- Attachment #1: Type: text/plain, Size: 1954 bytes --]
On Tue, Jun 20, 2023 at 10:00 PM Ivan Vecera <ivecera@redhat.com> wrote:
>
> Link VF representors to parent PCI device to benefit from
> systemd defined naming scheme.
>
> Without this change the representor is visible as ethN.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Acked-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
> index 2f1a1f2d2157..1467b94a6427 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
> @@ -468,6 +468,7 @@ static void bnxt_vf_rep_netdev_init(struct bnxt *bp, struct bnxt_vf_rep *vf_rep,
> struct net_device *pf_dev = bp->dev;
> u16 max_mtu;
>
> + SET_NETDEV_DEV(dev, &bp->pdev->dev);
> dev->netdev_ops = &bnxt_vf_rep_netdev_ops;
> dev->ethtool_ops = &bnxt_vf_rep_ethtool_ops;
> /* Just inherit all the featues of the parent PF as the VF-R
> --
> 2.39.3
>
>
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4236 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] bnxt_en: Link representors to PCI device
2023-06-20 16:49 ` Sriharsha Basavapatna
@ 2023-06-20 16:56 ` Jakub Kicinski
0 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2023-06-20 16:56 UTC (permalink / raw)
To: Sriharsha Basavapatna
Cc: Ivan Vecera, netdev, Michael Chan, David S. Miller, Eric Dumazet,
Paolo Abeni, open list, Andy Gospodarek
On Tue, 20 Jun 2023 22:19:32 +0530 Sriharsha Basavapatna wrote:
> This electronic communication and the information and any files transmitted
> with it, or attached to it, are confidential and are intended solely for
> the use of the individual or entity to whom it is addressed and may contain
> information that is confidential, legally privileged, protected by privacy
> laws, or otherwise restricted from disclosure to anyone else. If you are
> not the intended recipient or the person responsible for delivering the
> e-mail to the intended recipient, you are hereby notified that any use,
> copying, distributing, dissemination, forwarding, printing, or copying of
> this e-mail is strictly prohibited. If you received this e-mail in error,
> please return the e-mail to the sender, delete it from your computer, and
> destroy any printed copy of it.
Your emails to the list must not include any legal note of this nature.
I'll have to manually delete your review tag from the system.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] bnxt_en: Link representors to PCI device
2023-06-20 14:48 [PATCH net-next] bnxt_en: Link representors to PCI device Ivan Vecera
2023-06-20 15:54 ` Simon Horman
2023-06-20 16:49 ` Sriharsha Basavapatna
@ 2023-06-20 17:26 ` Michael Chan
2023-06-20 19:41 ` Simon Horman
2023-06-21 21:10 ` patchwork-bot+netdevbpf
3 siblings, 1 reply; 8+ messages in thread
From: Michael Chan @ 2023-06-20 17:26 UTC (permalink / raw)
To: Ivan Vecera
Cc: netdev, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, open list
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
On Tue, Jun 20, 2023 at 7:52 AM Ivan Vecera <ivecera@redhat.com> wrote:
>
> Link VF representors to parent PCI device to benefit from
> systemd defined naming scheme.
>
> Without this change the representor is visible as ethN.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Thanks.
Reviewed-by: Michael Chan <michael.chan@broadcon.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] bnxt_en: Link representors to PCI device
2023-06-20 17:26 ` Michael Chan
@ 2023-06-20 19:41 ` Simon Horman
2023-06-20 20:12 ` Michael Chan
0 siblings, 1 reply; 8+ messages in thread
From: Simon Horman @ 2023-06-20 19:41 UTC (permalink / raw)
To: Michael Chan
Cc: Ivan Vecera, netdev, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, open list
On Tue, Jun 20, 2023 at 10:26:21AM -0700, Michael Chan wrote:
> On Tue, Jun 20, 2023 at 7:52 AM Ivan Vecera <ivecera@redhat.com> wrote:
> >
> > Link VF representors to parent PCI device to benefit from
> > systemd defined naming scheme.
> >
> > Without this change the representor is visible as ethN.
> >
> > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>
> Thanks.
>
> Reviewed-by: Michael Chan <michael.chan@broadcon.com>
nit:) broadcon -> broadcom
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] bnxt_en: Link representors to PCI device
2023-06-20 19:41 ` Simon Horman
@ 2023-06-20 20:12 ` Michael Chan
0 siblings, 0 replies; 8+ messages in thread
From: Michael Chan @ 2023-06-20 20:12 UTC (permalink / raw)
To: Simon Horman
Cc: Ivan Vecera, netdev, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, open list
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
On Tue, Jun 20, 2023 at 12:41 PM Simon Horman <simon.horman@corigine.com> wrote:
>
> On Tue, Jun 20, 2023 at 10:26:21AM -0700, Michael Chan wrote:
> > On Tue, Jun 20, 2023 at 7:52 AM Ivan Vecera <ivecera@redhat.com> wrote:
> > >
> > > Link VF representors to parent PCI device to benefit from
> > > systemd defined naming scheme.
> > >
> > > Without this change the representor is visible as ethN.
> > >
> > > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> >
> > Thanks.
> >
> > Reviewed-by: Michael Chan <michael.chan@broadcon.com>
>
> nit:) broadcon -> broadcom
>
>
Typo fixed.
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] bnxt_en: Link representors to PCI device
2023-06-20 14:48 [PATCH net-next] bnxt_en: Link representors to PCI device Ivan Vecera
` (2 preceding siblings ...)
2023-06-20 17:26 ` Michael Chan
@ 2023-06-21 21:10 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-21 21:10 UTC (permalink / raw)
To: Ivan Vecera
Cc: netdev, michael.chan, davem, edumazet, kuba, pabeni, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 20 Jun 2023 16:48:55 +0200 you wrote:
> Link VF representors to parent PCI device to benefit from
> systemd defined naming scheme.
>
> Without this change the representor is visible as ethN.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>
> [...]
Here is the summary with links:
- [net-next] bnxt_en: Link representors to PCI device
https://git.kernel.org/netdev/net-next/c/7ad7b7023fcb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-06-21 21:10 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-20 14:48 [PATCH net-next] bnxt_en: Link representors to PCI device Ivan Vecera
2023-06-20 15:54 ` Simon Horman
2023-06-20 16:49 ` Sriharsha Basavapatna
2023-06-20 16:56 ` Jakub Kicinski
2023-06-20 17:26 ` Michael Chan
2023-06-20 19:41 ` Simon Horman
2023-06-20 20:12 ` Michael Chan
2023-06-21 21:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).