linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] broadcom: bnxt: Fix use true/false for bool
@ 2019-10-28 20:16 Saurav Girepunje
  2019-10-28 20:34 ` Michael Chan
  2019-10-30  0:51 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Saurav Girepunje @ 2019-10-28 20:16 UTC (permalink / raw)
  To: michael.chan, davem, netdev, linux-kernel; +Cc: saurav.girepunje

Use true/false for bool type in bnxt_timer function.

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index b4a8cf620a0c..8cdf71f8824d 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -10004,7 +10004,7 @@ static void bnxt_timer(struct timer_list *t)
 
 	if (bp->link_info.phy_retry) {
 		if (time_after(jiffies, bp->link_info.phy_retry_expires)) {
-			bp->link_info.phy_retry = 0;
+			bp->link_info.phy_retry = false;
 			netdev_warn(bp->dev, "failed to update phy settings after maximum retries.\n");
 		} else {
 			set_bit(BNXT_UPDATE_PHY_SP_EVENT, &bp->sp_event);
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] broadcom: bnxt: Fix use true/false for bool
  2019-10-28 20:16 [PATCH] broadcom: bnxt: Fix use true/false for bool Saurav Girepunje
@ 2019-10-28 20:34 ` Michael Chan
  2019-10-30  0:51 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Chan @ 2019-10-28 20:34 UTC (permalink / raw)
  To: Saurav Girepunje; +Cc: David Miller, Netdev, open list, saurav.girepunje

On Mon, Oct 28, 2019 at 1:16 PM Saurav Girepunje
<saurav.girepunje@gmail.com> wrote:
>
> Use true/false for bool type in bnxt_timer function.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

Acked-by: Michael Chan <michael.chan@broadcom.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] broadcom: bnxt: Fix use true/false for bool
  2019-10-28 20:16 [PATCH] broadcom: bnxt: Fix use true/false for bool Saurav Girepunje
  2019-10-28 20:34 ` Michael Chan
@ 2019-10-30  0:51 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-10-30  0:51 UTC (permalink / raw)
  To: saurav.girepunje; +Cc: michael.chan, netdev, linux-kernel, saurav.girepunje

From: Saurav Girepunje <saurav.girepunje@gmail.com>
Date: Tue, 29 Oct 2019 01:46:35 +0530

> Use true/false for bool type in bnxt_timer function.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-30  0:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 20:16 [PATCH] broadcom: bnxt: Fix use true/false for bool Saurav Girepunje
2019-10-28 20:34 ` Michael Chan
2019-10-30  0:51 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).