From: Joel Stanley <joel@jms.id.au>
To: Tao Ren <rentao.bupt@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
devicetree <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Tao Ren <taoren@fb.com>
Subject: Re: [PATCH v2 4/6] ARM: dts: aspeed: Add Facebook Cloudripper (AST2600) BMC
Date: Fri, 13 Aug 2021 04:13:23 +0000 [thread overview]
Message-ID: <CACPK8XeoV8DqDNYFgK97r-Q0DebNjrmgUTydKSYmGt+3x=-vOQ@mail.gmail.com> (raw)
In-Reply-To: <20210813034016.GA21895@taoren-ubuntu-R90MNF91>
On Fri, 13 Aug 2021 at 03:40, Tao Ren <rentao.bupt@gmail.com> wrote:
>
> On Fri, Aug 13, 2021 at 01:29:17AM +0000, Joel Stanley wrote:
> > On Thu, 5 Aug 2021 at 22:28, <rentao.bupt@gmail.com> wrote:
> > > +&mdio1 {
> > > + status = "okay";
> >
> > You're enabling this but it looks like it's unused?
>
> Thanks Joel for the careful review. The MDIO controller is not paired
> with BMC MAC; instead, it's connected to the MDC/MDIO interface of the
> on-board switch (whose ports are connected to BMC, Host and front panel
> management port).
I see!
>
> In other word, the MDIO controller is used, but we do need some user
> space scripts to control the controller. What's your suggestion? For
> example, should I add some comments to explain the purpose?
Yes, that would make sense.
I've applied your patch, so if you want to add comments please send a
diff against this tree:
https://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git/log/?h=dt-for-v5.15
next prev parent reply other threads:[~2021-08-13 4:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 22:28 [PATCH v2 0/6] ARM: dts: Add Facebook AST2600 BMCs rentao.bupt
2021-08-05 22:28 ` [PATCH v2 1/6] ARM: dts: Add Facebook BMC 128MB flash layout rentao.bupt
2021-08-05 22:28 ` [PATCH v2 2/6] ARM: dts: aspeed: wedge400: Use common " rentao.bupt
2021-08-05 22:28 ` [PATCH v2 3/6] ARM: dts: aspeed: Common dtsi for Facebook AST2600 Network BMCs rentao.bupt
2023-12-20 8:14 ` Lukas Wunner
2024-01-03 0:11 ` Tao Ren
2024-01-03 12:45 ` Lukas Wunner
2024-01-03 15:48 ` Patrick Williams
2024-01-03 18:16 ` Tao Ren
2021-08-05 22:28 ` [PATCH v2 4/6] ARM: dts: aspeed: Add Facebook Cloudripper (AST2600) BMC rentao.bupt
2021-08-13 1:29 ` Joel Stanley
2021-08-13 3:40 ` Tao Ren
2021-08-13 4:13 ` Joel Stanley [this message]
2021-08-13 14:45 ` Andrew Lunn
2021-08-14 5:22 ` Tao Ren
2021-08-14 15:26 ` Andrew Lunn
2021-08-17 0:01 ` Tao Ren
2021-08-05 22:28 ` [PATCH v2 5/6] ARM: dts: aspeed: Add Facebook Elbert " rentao.bupt
2021-08-05 22:28 ` [PATCH v2 6/6] ARM: dts: aspeed: Add Facebook Fuji " rentao.bupt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8XeoV8DqDNYFgK97r-Q0DebNjrmgUTydKSYmGt+3x=-vOQ@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rentao.bupt@gmail.com \
--cc=robh+dt@kernel.org \
--cc=taoren@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).