From: Patrick Williams <patrick@stwcx.xyz>
To: Lukas Wunner <lukas@wunner.de>
Cc: Tao Ren <rentao.bupt@gmail.com>,
devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Andrew Jeffery <andrew@aj.id.au>,
taoren@fb.com, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/6] ARM: dts: aspeed: Common dtsi for Facebook AST2600 Network BMCs
Date: Wed, 3 Jan 2024 09:48:51 -0600 [thread overview]
Message-ID: <ZZWB4wRiAyDtlLJM@heinlein.vulture-banana.ts.net> (raw)
In-Reply-To: <20240103124502.GB23899@wunner.de>
[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]
On Wed, Jan 03, 2024 at 01:45:02PM +0100, Lukas Wunner wrote:
> On Tue, Jan 02, 2024 at 04:11:28PM -0800, Tao Ren wrote:
> > On Wed, Dec 20, 2023 at 09:14:02AM +0100, Lukas Wunner wrote:
> > > On Thu, Aug 05, 2021 at 03:28:15PM -0700, rentao.bupt@gmail.com wrote:
> > > > This common descirption is included by all Facebook AST2600 Network BMC
> > > > platforms to minimize duplicated device entries across Facebook Network
> > > > BMC device trees.
> > > [...]
> > > > --- /dev/null
> > > > +++ b/arch/arm/boot/dts/ast2600-facebook-netbmc-common.dtsi
> > > [...]
> > > > + tpmdev@0 {
> > > > + compatible = "tcg,tpm_tis-spi";
> > >
> > > What's the chip used on this board? Going forward, the DT schema for TPMs
> > > requires the exact chip name in addition to the generic "tcg,tpm_tis-spi".
> >
> > Sorry about the late response. It's "infineon,slb9670", and I will
> > submit a patch for fix it soon.
>
> Thank you Tao and Patrick for the replies. I've prepared two commits
> to fix all violations of the TPM schema on this branch:
>
> https://github.com/l1k/linux/commits/tpm-dt3
>
> The commits are named:
>
> e95bdbc arm64: dts: Fix TPM schema violations
> 63e5dfd ARM: dts: Fix TPM schema violations
Feel free to add to "63e5dfd (ARM: dts: Fix TPM schema violations)":
Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
>
> I've now amended the ARM commit to use "infineon,slb9670" for:
>
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-wedge400.dts
> arch/arm/boot/dts/aspeed/ast2600-facebook-netbmc-common.dtsi
>
> I intend to submit the two commits once the TPM schema is applied
> either to Jarkko's or Rob's tree:
>
> https://lore.kernel.org/all/20231220160422.GA282877-robh@kernel.org/
>
> Thanks,
>
> Lukas
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-01-03 15:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 22:28 [PATCH v2 0/6] ARM: dts: Add Facebook AST2600 BMCs rentao.bupt
2021-08-05 22:28 ` [PATCH v2 1/6] ARM: dts: Add Facebook BMC 128MB flash layout rentao.bupt
2021-08-05 22:28 ` [PATCH v2 2/6] ARM: dts: aspeed: wedge400: Use common " rentao.bupt
2021-08-05 22:28 ` [PATCH v2 3/6] ARM: dts: aspeed: Common dtsi for Facebook AST2600 Network BMCs rentao.bupt
2023-12-20 8:14 ` Lukas Wunner
2024-01-03 0:11 ` Tao Ren
2024-01-03 12:45 ` Lukas Wunner
2024-01-03 15:48 ` Patrick Williams [this message]
2024-01-03 18:16 ` Tao Ren
2021-08-05 22:28 ` [PATCH v2 4/6] ARM: dts: aspeed: Add Facebook Cloudripper (AST2600) BMC rentao.bupt
2021-08-13 1:29 ` Joel Stanley
2021-08-13 3:40 ` Tao Ren
2021-08-13 4:13 ` Joel Stanley
2021-08-13 14:45 ` Andrew Lunn
2021-08-14 5:22 ` Tao Ren
2021-08-14 15:26 ` Andrew Lunn
2021-08-17 0:01 ` Tao Ren
2021-08-05 22:28 ` [PATCH v2 5/6] ARM: dts: aspeed: Add Facebook Elbert " rentao.bupt
2021-08-05 22:28 ` [PATCH v2 6/6] ARM: dts: aspeed: Add Facebook Fuji " rentao.bupt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZWB4wRiAyDtlLJM@heinlein.vulture-banana.ts.net \
--to=patrick@stwcx.xyz \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=openbmc@lists.ozlabs.org \
--cc=rentao.bupt@gmail.com \
--cc=robh+dt@kernel.org \
--cc=taoren@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).