* [PATCH v1] ARM: dts: mihawk: Change the name of mihawk led
@ 2020-02-20 5:52 Ben Pai
2020-02-26 10:55 ` Joel Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Ben Pai @ 2020-02-20 5:52 UTC (permalink / raw)
To: robh+dt, mark.rutland, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel
Cc: wangat, Claire_Ku, Ben Pai
1.Change the name of power, fault and rear-id.
2.Remove the two leds.
Signed-off-by: Ben Pai <Ben_Pai@wistron.com>
---
arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
index e55cc454b17f..6c11854b9006 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
@@ -120,35 +120,24 @@
leds {
compatible = "gpio-leds";
- fault {
+ front-fault {
retain-state-shutdown;
default-state = "keep";
gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_LOW>;
};
- power {
+ power-button {
retain-state-shutdown;
default-state = "keep";
gpios = <&gpio ASPEED_GPIO(AA, 1) GPIO_ACTIVE_LOW>;
};
- rear-id {
+ front-id {
retain-state-shutdown;
default-state = "keep";
gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_LOW>;
};
- rear-g {
- retain-state-shutdown;
- default-state = "keep";
- gpios = <&gpio ASPEED_GPIO(AA, 4) GPIO_ACTIVE_LOW>;
- };
-
- rear-ok {
- retain-state-shutdown;
- default-state = "keep";
- gpios = <&gpio ASPEED_GPIO(Y, 0) GPIO_ACTIVE_LOW>;
- };
fan0 {
retain-state-shutdown;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] ARM: dts: mihawk: Change the name of mihawk led
2020-02-20 5:52 [PATCH v1] ARM: dts: mihawk: Change the name of mihawk led Ben Pai
@ 2020-02-26 10:55 ` Joel Stanley
2020-02-27 6:31 ` Ben_Pai
0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2020-02-26 10:55 UTC (permalink / raw)
To: Ben Pai
Cc: Rob Herring, Mark Rutland, Andrew Jeffery, devicetree, Linux ARM,
linux-aspeed, Linux Kernel Mailing List, wangat, Claire_Ku
On Thu, 20 Feb 2020 at 05:53, Ben Pai <Ben_Pai@wistron.com> wrote:
>
> 1.Change the name of power, fault and rear-id.
> 2.Remove the two leds.
The patch looks okay. Why do you remove the other two leds?
Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Signed-off-by: Ben Pai <Ben_Pai@wistron.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> index e55cc454b17f..6c11854b9006 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> @@ -120,35 +120,24 @@
> leds {
> compatible = "gpio-leds";
>
> - fault {
> + front-fault {
> retain-state-shutdown;
> default-state = "keep";
> gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_LOW>;
> };
>
> - power {
> + power-button {
> retain-state-shutdown;
> default-state = "keep";
> gpios = <&gpio ASPEED_GPIO(AA, 1) GPIO_ACTIVE_LOW>;
> };
>
> - rear-id {
> + front-id {
> retain-state-shutdown;
> default-state = "keep";
> gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_LOW>;
> };
>
> - rear-g {
> - retain-state-shutdown;
> - default-state = "keep";
> - gpios = <&gpio ASPEED_GPIO(AA, 4) GPIO_ACTIVE_LOW>;
> - };
> -
> - rear-ok {
> - retain-state-shutdown;
> - default-state = "keep";
> - gpios = <&gpio ASPEED_GPIO(Y, 0) GPIO_ACTIVE_LOW>;
> - };
>
> fan0 {
> retain-state-shutdown;
> --
> 2.17.1
>
>
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
> This email contains confidential or legally privileged information and is for the sole use of its intended recipient.
> Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.
> If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH v1] ARM: dts: mihawk: Change the name of mihawk led
2020-02-26 10:55 ` Joel Stanley
@ 2020-02-27 6:31 ` Ben_Pai
0 siblings, 0 replies; 3+ messages in thread
From: Ben_Pai @ 2020-02-27 6:31 UTC (permalink / raw)
To: joel
Cc: robh+dt, mark.rutland, andrew, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel, wangat, Claire_Ku, Ben_Pai
Mihawk platform no longer supports these two LEDs, so I think these two LEDs should be removed from dts.
Signed-off-by: Ben Pai <Ben_Pai@wistron.com>
-----Original Message-----
From: Joel Stanley <joel@jms.id.au>
Sent: Wednesday, February 26, 2020 6:56 PM
To: Ben Pai/WHQ/Wistron <Ben_Pai@wistron.com>
Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Andrew Jeffery <andrew@aj.id.au>; devicetree <devicetree@vger.kernel.org>; Linux ARM <linux-arm-kernel@lists.infradead.org>; linux-aspeed <linux-aspeed@lists.ozlabs.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; wangat@tw.ibm.com; Claire Ku/WHQ/Wistron <Claire_Ku@wistron.com>
Subject: Re: [PATCH v1] ARM: dts: mihawk: Change the name of mihawk led
On Thu, 20 Feb 2020 at 05:53, Ben Pai <Ben_Pai@wistron.com> wrote:
>
> 1.Change the name of power, fault and rear-id.
> 2.Remove the two leds.
The patch looks okay. Why do you remove the other two leds?
Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Signed-off-by: Ben Pai <Ben_Pai@wistron.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> index e55cc454b17f..6c11854b9006 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> @@ -120,35 +120,24 @@
> leds {
> compatible = "gpio-leds";
>
> - fault {
> + front-fault {
> retain-state-shutdown;
> default-state = "keep";
> gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_LOW>;
> };
>
> - power {
> + power-button {
> retain-state-shutdown;
> default-state = "keep";
> gpios = <&gpio ASPEED_GPIO(AA, 1) GPIO_ACTIVE_LOW>;
> };
>
> - rear-id {
> + front-id {
> retain-state-shutdown;
> default-state = "keep";
> gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_LOW>;
> };
>
> - rear-g {
> - retain-state-shutdown;
> - default-state = "keep";
> - gpios = <&gpio ASPEED_GPIO(AA, 4) GPIO_ACTIVE_LOW>;
> - };
> -
> - rear-ok {
> - retain-state-shutdown;
> - default-state = "keep";
> - gpios = <&gpio ASPEED_GPIO(Y, 0) GPIO_ACTIVE_LOW>;
> - };
>
> fan0 {
> retain-state-shutdown;
> --
> 2.17.1
>
>
> ----------------------------------------------------------------------
> ----------------------------------------------------------------------
> ------------------- This email contains confidential or legally
> privileged information and is for the sole use of its intended recipient.
> Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.
> If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.
> ----------------------------------------------------------------------
> ----------------------------------------------------------------------
> -------------------
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-27 6:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-20 5:52 [PATCH v1] ARM: dts: mihawk: Change the name of mihawk led Ben Pai
2020-02-26 10:55 ` Joel Stanley
2020-02-27 6:31 ` Ben_Pai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).