* [PATCH] ARM: dts: aspeed: tyan-s7106: Update nct7802 config
@ 2021-11-04 21:09 Oskar Senft
2021-11-04 22:03 ` Joel Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Oskar Senft @ 2021-11-04 21:09 UTC (permalink / raw)
To: linux-arm-kernel, linux-aspeed, linux-kernel
Cc: Rob Herring, Joel Stanley, Andrew Jeffery, Oskar Senft
This change updates the configuration for the nct7802 hardware
monitor to correctly configure its temperature sensors.
Signed-off-by: Oskar Senft <osk@google.com>
---
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts | 23 +++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
index 68f332ee1886..fc1585f34a57 100644
--- a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
@@ -213,6 +213,29 @@ &i2c0 {
nct7802@28 {
compatible = "nuvoton,nct7802";
reg = <0x28>;
+ channel@0 { /* LTD */
+ reg = <0>;
+ status = "okay";
+ };
+ channel@1 { /* RTD1 */
+ reg = <1>;
+ status = "okay";
+ sensor-type = "temperature";
+ temperature-mode = "thermistor";
+ };
+
+ channel@2 { /* RTD2 */
+ reg = <2>;
+ status = "okay";
+ sensor-type = "temperature";
+ temperature-mode = "thermistor";
+ };
+
+ channel@3 { /* RTD3 */
+ reg = <3>;
+ status = "okay";
+ sensor-type = "temperature";
+ };
};
/* Also connected to:
--
2.34.0.rc0.344.g81b53c2807-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: tyan-s7106: Update nct7802 config
2021-11-04 21:09 [PATCH] ARM: dts: aspeed: tyan-s7106: Update nct7802 config Oskar Senft
@ 2021-11-04 22:03 ` Joel Stanley
2021-11-05 1:01 ` Oskar Senft
0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2021-11-04 22:03 UTC (permalink / raw)
To: Oskar Senft
Cc: Linux ARM, linux-aspeed, Linux Kernel Mailing List, Rob Herring,
Andrew Jeffery
On Thu, 4 Nov 2021 at 21:09, Oskar Senft <osk@google.com> wrote:
>
> This change updates the configuration for the nct7802 hardware
> monitor to correctly configure its temperature sensors.
>
> Signed-off-by: Oskar Senft <osk@google.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts | 23 +++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
> index 68f332ee1886..fc1585f34a57 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
> @@ -213,6 +213,29 @@ &i2c0 {
> nct7802@28 {
> compatible = "nuvoton,nct7802";
> reg = <0x28>;
> + channel@0 { /* LTD */
> + reg = <0>;
> + status = "okay";
The status = "okay" should be redundant; as long as you don't specify
a status, a node is assumed to be enabled.
> + };
> + channel@1 { /* RTD1 */
> + reg = <1>;
> + status = "okay";
> + sensor-type = "temperature";
> + temperature-mode = "thermistor";
> + };
> +
> + channel@2 { /* RTD2 */
> + reg = <2>;
> + status = "okay";
> + sensor-type = "temperature";
> + temperature-mode = "thermistor";
> + };
> +
> + channel@3 { /* RTD3 */
> + reg = <3>;
> + status = "okay";
> + sensor-type = "temperature";
> + };
> };
>
> /* Also connected to:
> --
> 2.34.0.rc0.344.g81b53c2807-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: tyan-s7106: Update nct7802 config
2021-11-04 22:03 ` Joel Stanley
@ 2021-11-05 1:01 ` Oskar Senft
0 siblings, 0 replies; 3+ messages in thread
From: Oskar Senft @ 2021-11-05 1:01 UTC (permalink / raw)
To: Joel Stanley
Cc: Linux ARM, linux-aspeed, Linux Kernel Mailing List, Rob Herring,
Andrew Jeffery
Hi Joel
> > + channel@0 { /* LTD */
> > + reg = <0>;
> > + status = "okay";
>
> The status = "okay" should be redundant; as long as you don't specify
> a status, a node is assumed to be enabled.
My apologies! I know you mentioned something similar for the DTS
binding patch. I didn't realize that this was a generic statement,
rather than limited to the example in the binding. Fixed in PATCH v2.
Oskar.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-05 1:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 21:09 [PATCH] ARM: dts: aspeed: tyan-s7106: Update nct7802 config Oskar Senft
2021-11-04 22:03 ` Joel Stanley
2021-11-05 1:01 ` Oskar Senft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).