[PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

[PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

[Sachin Kamat]

Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/gpio/gpio-vt8500.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-vt8500.c b/drivers/gpio/gpio-vt8500.c
index 81683ca..b2d8d6f 100644
--- a/drivers/gpio/gpio-vt8500.c
+++ b/drivers/gpio/gpio-vt8500.c
@@ -309,11 +309,9 @@ static int vt8500_gpio_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	gpio_base = devm_request_and_ioremap(&pdev->dev, res);
-	if (!gpio_base) {
-		dev_err(&pdev->dev, "Unable to map GPIO registers\n");
-		return -ENOMEM;
-	}
+	gpio_base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(gpio_base))
+		return PTR_ERR(gpio_base);
 
 	ret = vt8500_add_chips(pdev, gpio_base, of_id->data);
 
-- 
1.7.4.1

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

On Mon, Mar 04, 2013 at 02:39:39PM +0530, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
> 
> devm_ioremap_resource() provides its own error messages; so all explicit
> error messages can be removed from the failure code paths.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/gpio/gpio-vt8500.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)

Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

[Tony Prisk]

On Mon, 2013-03-04 at 14:39 +0530, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
> 
> devm_ioremap_resource() provides its own error messages; so all explicit
> error messages can be removed from the failure code paths.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/gpio/gpio-vt8500.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-vt8500.c b/drivers/gpio/gpio-vt8500.c
> index 81683ca..b2d8d6f 100644
> --- a/drivers/gpio/gpio-vt8500.c
> +++ b/drivers/gpio/gpio-vt8500.c
> @@ -309,11 +309,9 @@ static int vt8500_gpio_probe(struct platform_device *pdev)
>  		return -ENODEV;
>  	}
>  
> -	gpio_base = devm_request_and_ioremap(&pdev->dev, res);
> -	if (!gpio_base) {
> -		dev_err(&pdev->dev, "Unable to map GPIO registers\n");
> -		return -ENOMEM;
> -	}
> +	gpio_base = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(gpio_base))
> +		return PTR_ERR(gpio_base);
>  
>  	ret = vt8500_add_chips(pdev, gpio_base, of_id->data);
>  

Acked-by: Tony Prisk <linux@prisktech.co.nz>

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

[Sachin Kamat]

Hi Linus,

On 4 March 2013 22:38, Tony Prisk <linux@prisktech.co.nz> wrote:
> On Mon, 2013-03-04 at 14:39 +0530, Sachin Kamat wrote:
>> Use the newly introduced devm_ioremap_resource() instead of
>> devm_request_and_ioremap() which provides more consistent error handling.
>>
>> devm_ioremap_resource() provides its own error messages; so all explicit
>> error messages can be removed from the failure code paths.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

> Acked-by: Tony Prisk <linux@prisktech.co.nz>

Would you be picking this patch up or Grant is gonna handle it?


-- 
With warm regards,
Sachin

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

[Linus Walleij]

On Mon, Mar 4, 2013 at 10:09 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:

> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
>
> devm_ioremap_resource() provides its own error messages; so all explicit
> error messages can be removed from the failure code paths.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Patch applied with Tony's and Thierry's ACKs/Reviewed-by.

Yours,
Linus Walleij