* [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)
@ 2022-09-08 14:21 Andy Shevchenko
2022-09-09 8:02 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-09-08 14:21 UTC (permalink / raw)
To: Andy Shevchenko, Linus Walleij, Patrick Rudolph, linux-gpio,
linux-kernel
Move the default values to the 'default' case in the switches.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/pinctrl-cy8c95x0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c
index 1335d07822f9..79f73d364f3f 100644
--- a/drivers/pinctrl/pinctrl-cy8c95x0.c
+++ b/drivers/pinctrl/pinctrl-cy8c95x0.c
@@ -357,9 +357,9 @@ static bool cy8c95x0_volatile_register(struct device *dev, unsigned int reg)
case CY8C95X0_DRV_PP_SLOW:
case CY8C95X0_DRV_HIZ:
return true;
+ default:
+ return false;
}
-
- return false;
}
static bool cy8c95x0_precious_register(struct device *dev, unsigned int reg)
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)
2022-09-08 14:21 [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2) Andy Shevchenko
@ 2022-09-09 8:02 ` Linus Walleij
2022-09-09 8:42 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2022-09-09 8:02 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Patrick Rudolph, linux-gpio, linux-kernel
On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Move the default values to the 'default' case in the switches.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied!
> case CY8C95X0_DRV_PP_SLOW:
> case CY8C95X0_DRV_HIZ:
> return true;
> + default:
> + return false;
> }
> -
> - return false;
> }
Clearly this is better style, I wonder if we could teach checkpatch to
look for this? Or cocinelle?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)
2022-09-09 8:02 ` Linus Walleij
@ 2022-09-09 8:42 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-09-09 8:42 UTC (permalink / raw)
To: Linus Walleij; +Cc: Patrick Rudolph, linux-gpio, linux-kernel
On Fri, Sep 09, 2022 at 10:02:51AM +0200, Linus Walleij wrote:
> On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > Move the default values to the 'default' case in the switches.
> Patch applied!
Thanks!
...
> > case CY8C95X0_DRV_PP_SLOW:
> > case CY8C95X0_DRV_HIZ:
> > return true;
> > + default:
> > + return false;
> > }
> > -
> > - return false;
>
> Clearly this is better style, I wonder if we could teach checkpatch to
> look for this? Or cocinelle?
The latter I believe. But I'm too busy and too lazy to go that road.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-09 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-08 14:21 [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2) Andy Shevchenko
2022-09-09 8:02 ` Linus Walleij
2022-09-09 8:42 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).