* [PATCH] pinctrl: max77620: add OF dependency
@ 2016-10-28 8:19 Arnd Bergmann
2016-10-29 8:30 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-10-28 8:19 UTC (permalink / raw)
To: Linus Walleij
Cc: Laxman Dewangan, Jon Hunter, Arnd Bergmann, Krzysztof Kozlowski,
Lee Jones, linux-gpio, linux-kernel
Drivers using pinconf_generic_params tables cannot be built with
CONFIG_OF disabled:
drivers/pinctrl/pinctrl-max77620.c:53:44: error: array type has incomplete element type ‘struct pinconf_generic_params’
drivers/pinctrl/pinctrl-max77620.c:55:3: error: field name not in record or union initializer
drivers/pinctrl/pinctrl-max77620.c:55:3: note: (near initialization for ‘max77620_cfg_params’)
drivers/pinctrl/pinctrl-max77620.c:56:3: error: field name not in record or union initializer
This adds a dependency for max77620 to disallow that configuration.
Alternatively, we could rework the pinctrl infrastructure to make the
configuration valid for compile-testing.
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>
Fixes: 453943dc8f45 ("mfd: Enable compile testing for max77620 and max77686")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 801fa8bb05e1..3eea73937ce8 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -223,7 +223,7 @@ config PINCTRL_COH901
config PINCTRL_MAX77620
tristate "MAX77620/MAX20024 Pincontrol support"
- depends on MFD_MAX77620
+ depends on MFD_MAX77620 && OF
select PINMUX
select GENERIC_PINCONF
help
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: max77620: add OF dependency
2016-10-28 8:19 [PATCH] pinctrl: max77620: add OF dependency Arnd Bergmann
@ 2016-10-29 8:30 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-10-29 8:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Laxman Dewangan, Jon Hunter, Krzysztof Kozlowski, Lee Jones,
linux-gpio, linux-kernel
On Fri, Oct 28, 2016 at 10:19 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> Drivers using pinconf_generic_params tables cannot be built with
> CONFIG_OF disabled:
>
> drivers/pinctrl/pinctrl-max77620.c:53:44: error: array type has incomplete element type ‘struct pinconf_generic_params’
> drivers/pinctrl/pinctrl-max77620.c:55:3: error: field name not in record or union initializer
> drivers/pinctrl/pinctrl-max77620.c:55:3: note: (near initialization for ‘max77620_cfg_params’)
> drivers/pinctrl/pinctrl-max77620.c:56:3: error: field name not in record or union initializer
>
> This adds a dependency for max77620 to disallow that configuration.
>
> Alternatively, we could rework the pinctrl infrastructure to make the
> configuration valid for compile-testing.
>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Fixes: 453943dc8f45 ("mfd: Enable compile testing for max77620 and max77686")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-29 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-28 8:19 [PATCH] pinctrl: max77620: add OF dependency Arnd Bergmann
2016-10-29 8:30 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).