From: Linus Walleij <linus.walleij@linaro.org>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Bruno Herrera <bruherrera@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v2 6/9] pinctrl: Add IRQ support to STM32 gpios
Date: Fri, 8 Apr 2016 11:43:12 +0200 [thread overview]
Message-ID: <CACRpkdYLPWNQZgdFHVwLOZv+rS=bdERM9St5b0hVHTd_+ZJMKg@mail.gmail.com> (raw)
In-Reply-To: <1459436979-17275-7-git-send-email-mcoquelin.stm32@gmail.com>
On Thu, Mar 31, 2016 at 5:09 PM, Maxime Coquelin
<mcoquelin.stm32@gmail.com> wrote:
> +static int stm32_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
> +{
> + struct stm32_pinctrl *pctl = dev_get_drvdata(chip->parent);
> + struct stm32_gpio_bank *bank = gpiochip_get_data(chip);
> + unsigned int irq;
> +
> + regmap_field_write(pctl->irqmux[offset], bank->range.id);
No. You must implement the irqchip and GPIO controllers to
be orthogonal, doing things like this creates a semantic that
assumes .to_irq() is always called before using the IRQ and
that is not guaranteed at all. A consumer may very well
use an interrupt right off the irqchip without this being called
first. All this function should do is translate a number. No
other semantics.
This needs to be done from the irqchip (sorry).
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-04-08 9:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 15:09 [PATCH v2 0/9] Add STM32 EXTI interrupt controller support Maxime Coquelin
2016-03-31 15:09 ` [PATCH v2 1/9] Documentation: dt-bindings: Document STM32 EXTI controller bindings Maxime Coquelin
2016-04-04 5:15 ` Rob Herring
2016-04-04 14:32 ` Maxime Coquelin
2016-03-31 15:09 ` [PATCH v2 2/9] drivers: irqchip: Add STM32 external interrupts support Maxime Coquelin
2016-04-08 9:38 ` Linus Walleij
2016-04-19 8:00 ` Maxime Coquelin
2016-04-29 8:45 ` Linus Walleij
2016-04-08 9:47 ` Linus Walleij
2016-03-31 15:09 ` [PATCH v2 3/9] ARM: STM32: Select external interrupts controller Maxime Coquelin
2016-03-31 15:09 ` [PATCH v2 4/9] ARM: dts: Add EXTI controller node to stm32f429 Maxime Coquelin
2016-03-31 15:09 ` [PATCH v2 5/9] Documentation: dt-bindings: Add IRQ related properties of STM32 pinctrl Maxime Coquelin
2016-04-04 5:15 ` Rob Herring
2016-03-31 15:09 ` [PATCH v2 6/9] pinctrl: Add IRQ support to STM32 gpios Maxime Coquelin
2016-04-08 9:43 ` Linus Walleij [this message]
2016-04-19 9:04 ` Maxime Coquelin
2016-04-29 8:53 ` Linus Walleij
2016-04-29 8:55 ` Linus Walleij
2016-04-29 11:19 ` Maxime Coquelin
2016-04-30 11:32 ` Linus Walleij
2016-05-02 8:32 ` Maxime Coquelin
2016-03-31 15:09 ` [PATCH v2 7/9] ARM: dts: Add GPIO irq support to STM2F429 Maxime Coquelin
2016-03-31 15:09 ` [PATCH v2 8/9] ARM: dts: Declare push button as GPIO key on stm32f429 Disco board Maxime Coquelin
2016-03-31 15:09 ` [PATCH v2 9/9] ARM: config: Enable GPIO Key driver in stm32_defconfig Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYLPWNQZgdFHVwLOZv+rS=bdERM9St5b0hVHTd_+ZJMKg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=bruherrera@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).