From: Linus Walleij <linus.walleij@linaro.org>
To: Yann Gautier <yann.gautier@foss.st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Christophe Kerello <christophe.kerello@foss.st.com>,
Ludovic Barre <ludovic.barre@foss.st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Russell King <linux@armlinux.org.uk>, Marek Vasut <marex@denx.de>,
kernel@dh-electronics.com,
Manivannan Sadhasivam <mani@kernel.org>,
Grzegorz Szymaszek <gszymaszek@short.pl>
Subject: Re: [PATCH 1/3] dt-bindings: mmc: mmci: add a property to disable DMA LLI
Date: Mon, 14 Mar 2022 23:43:22 +0100 [thread overview]
Message-ID: <CACRpkdYQz+-im3n-r0_8RKL7so2bHS=aZobty4BbzixmPzms-Q@mail.gmail.com> (raw)
In-Reply-To: <20220304135134.47827-2-yann.gautier@foss.st.com>
"On Fri, Mar 4, 2022 at 2:52 PM Yann Gautier <yann.gautier@foss.st.com> wrote:
> On STMicroelectronics variant of PL18x, the DMA Linked Lists are supported
> starting from revision v2 of the peripheral. But it has limitations,
> as all the buffers should be aligned on block size (except the last one).
> But this cannot be guaranteed with SDIO. We should then have a property
> to disable the support of LLI.
>
> Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>
Actually I think this is present also on the ux500 variants. See:
commit 2253ed4b36dc876d1598c4dab5587e537ec68c34
"mmc: mmci: Support any block sizes for ux500v2 and qcom variant"
Spot the variant data "dma_power_of_2".
So whatever property you add
to the variant data (not in the device tree please) should
be added to the ux500 variants as well, it will *VERY* likely
have a problem with LLI elements not being a power of 2
as it is the ancestor of later STMicro variants.
It might actually be the reason for some annoying WiFi error
messages I have seen :/
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-03-14 22:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 13:51 [PATCH 0/3] mmc: mmci: stm32: updates for SDIO Yann Gautier
2022-03-04 13:51 ` [PATCH 1/3] dt-bindings: mmc: mmci: add a property to disable DMA LLI Yann Gautier
2022-03-08 10:57 ` Ulf Hansson
2022-03-10 15:59 ` Yann Gautier
2022-03-11 15:45 ` Ulf Hansson
2022-03-14 22:43 ` Linus Walleij [this message]
2022-03-15 8:26 ` Yann Gautier
2022-03-17 10:00 ` Ulf Hansson
2022-03-17 10:17 ` Yann Gautier
2022-03-17 10:28 ` Ulf Hansson
2022-03-25 20:12 ` Linus Walleij
2022-03-28 14:58 ` Yann Gautier
2022-03-29 15:31 ` Manivannan Sadhasivam
2022-03-29 16:00 ` Yann Gautier
2022-03-29 17:33 ` Manivannan Sadhasivam
2022-03-29 21:16 ` Linus Walleij
2022-03-30 10:25 ` Srinivas Kandagatla
2022-03-04 13:51 ` [PATCH 2/3] mmc: mmci: stm32: manage st,disable-dma-lli property Yann Gautier
2022-03-04 13:51 ` [PATCH 3/3] mmc: mmci: manage MMC_PM_KEEP_POWER per variant config Yann Gautier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYQz+-im3n-r0_8RKL7so2bHS=aZobty4BbzixmPzms-Q@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=christophe.kerello@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=gszymaszek@short.pl \
--cc=kernel@dh-electronics.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=ludovic.barre@foss.st.com \
--cc=mani@kernel.org \
--cc=marex@denx.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yann.gautier@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).