From: Yann Gautier <yann.gautier@foss.st.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Christophe Kerello <christophe.kerello@foss.st.com>,
Linus Walleij <linus.walleij@linaro.org>,
Ludovic Barre <ludovic.barre@foss.st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Russell King <linux@armlinux.org.uk>, Marek Vasut <marex@denx.de>,
<kernel@dh-electronics.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Grzegorz Szymaszek <gszymaszek@short.pl>
Subject: Re: [PATCH 1/3] dt-bindings: mmc: mmci: add a property to disable DMA LLI
Date: Thu, 10 Mar 2022 16:59:28 +0100 [thread overview]
Message-ID: <b465353f-9291-f159-ba0b-4cd9577fc676@foss.st.com> (raw)
In-Reply-To: <CAPDyKFq_TsBLjW2WxC-Fvu6qDs9MJ1=QPo9gOLRykJ5p2pJbGw@mail.gmail.com>
On 3/8/22 11:57, Ulf Hansson wrote:
> Hi Yann,
>
> On Fri, 4 Mar 2022 at 14:52, Yann Gautier <yann.gautier@foss.st.com> wrote:
>>
>> On STMicroelectronics variant of PL18x, the DMA Linked Lists are supported
>> starting from revision v2 of the peripheral. But it has limitations,
>> as all the buffers should be aligned on block size (except the last one).
>> But this cannot be guaranteed with SDIO. We should then have a property
>> to disable the support of LLI.
>
> Indeed, the buffer handling with SDIO is somewhat special, which also
> has been discussed several times on LKML before. In principle, we need
> the SDIO func drivers to respect buffer limitations that should be
> specified by the mmc host drivers. Quite similar to what we already
> have for block devices, like ->max_seg_size, ->max_seg, etc, that is
> set per mmc host.
>
> I realize that implementing something like the above requires bigger
> changes, which is why mmc host drivers instead validates the sglists
> and the elements. In some cases that means returning an error code and
> in others it could mean falling back to a non-DMA based I/O mode.
>
> For the stm32_sdmmc variant, it looks like the sglist validation is
> being managed in sdmmc_idma_validate_data() already. Can it be
> extended to cover this case too, rather than using a DT property?
>
> Kind regards
> Uffe
Hi Ulf,
OK, I'll check what can be done for this. Patches 1 and 2 can be
dropped, they will be reworked.
But patch 3 of this series could be taken, as not linked to LLI
management. Should I push it again alone, or could you review it directly?
Best regards,
Yann
>
>>
>> Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>
>> ---
>> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
>> index 1e69a5a42439..309a2c0426e5 100644
>> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
>> @@ -145,6 +145,11 @@ properties:
>> driver to sample the receive data (for example with a voltage switch
>> transceiver).
>>
>> + st,disable-dma-lli:
>> + $ref: /schemas/types.yaml#/definitions/flag
>> + description: ST Micro-specific property, disable DMA linked lists.
>> + It is used for SDIO.
>> +
>> st,cmd-gpios:
>> maxItems: 1
>> description:
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2022-03-10 16:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 13:51 [PATCH 0/3] mmc: mmci: stm32: updates for SDIO Yann Gautier
2022-03-04 13:51 ` [PATCH 1/3] dt-bindings: mmc: mmci: add a property to disable DMA LLI Yann Gautier
2022-03-08 10:57 ` Ulf Hansson
2022-03-10 15:59 ` Yann Gautier [this message]
2022-03-11 15:45 ` Ulf Hansson
2022-03-14 22:43 ` Linus Walleij
2022-03-15 8:26 ` Yann Gautier
2022-03-17 10:00 ` Ulf Hansson
2022-03-17 10:17 ` Yann Gautier
2022-03-17 10:28 ` Ulf Hansson
2022-03-25 20:12 ` Linus Walleij
2022-03-28 14:58 ` Yann Gautier
2022-03-29 15:31 ` Manivannan Sadhasivam
2022-03-29 16:00 ` Yann Gautier
2022-03-29 17:33 ` Manivannan Sadhasivam
2022-03-29 21:16 ` Linus Walleij
2022-03-30 10:25 ` Srinivas Kandagatla
2022-03-04 13:51 ` [PATCH 2/3] mmc: mmci: stm32: manage st,disable-dma-lli property Yann Gautier
2022-03-04 13:51 ` [PATCH 3/3] mmc: mmci: manage MMC_PM_KEEP_POWER per variant config Yann Gautier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b465353f-9291-f159-ba0b-4cd9577fc676@foss.st.com \
--to=yann.gautier@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=christophe.kerello@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=gszymaszek@short.pl \
--cc=kernel@dh-electronics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=ludovic.barre@foss.st.com \
--cc=mani@kernel.org \
--cc=marex@denx.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).