From: Linus Walleij <linus.walleij@linaro.org>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: Linux Input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Vincent Huang <vincent.huang@tw.synaptics.com>,
Nick Dyer <nick.dyer@itdev.co.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/7] Input: synaptics-rmi4: Add dribble and palm gesture parameters to devicetree
Date: Wed, 8 Jun 2016 09:39:14 +0200 [thread overview]
Message-ID: <CACRpkdYSJ4E1cQk0PPj=D2DMs1d+5J9oFAAi=kmZvF72t1RH6g@mail.gmail.com> (raw)
In-Reply-To: <1464979228-2497-1-git-send-email-aduggan@synaptics.com>
On Fri, Jun 3, 2016 at 8:40 PM, Andrew Duggan <aduggan@synaptics.com> wrote:
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
> +- syna,dribble: Control reporting of dribble packets. Values are 0 for
> + default, 1 for explicitly disable, 2 for explicitly enable.
> +- syna,palm_detect: Control reporting of the palm detect gesture. Values
> + are 0 for default, 1 for explicitly disable, 2 for
> + explicitly enable.
I think these belong in the device tree, but you should add four bool
props instead:
syna,dribble-disable;
syna,dribble-enable;
syna,palm-detect-disable;
syna,palm-detect-enable;
Those are way easier for the human authoring the device tree to
cope with than the opaque parameters.
Yours,
Linus Walleij
prev parent reply other threads:[~2016-06-08 7:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 18:40 [PATCH 3/7] Input: synaptics-rmi4: Add dribble and palm gesture parameters to devicetree Andrew Duggan
2016-06-03 18:57 ` Mark Rutland
2016-06-07 19:11 ` Andrew Duggan
2016-06-08 7:39 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYSJ4E1cQk0PPj=D2DMs1d+5J9oFAAi=kmZvF72t1RH6g@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick.dyer@itdev.co.uk \
--cc=vincent.huang@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).