* [PATCH v2] gpio: davinci: Assign first bank regs for unbanked case
@ 2017-11-10 11:13 Keerthy
2017-11-24 7:24 ` Keerthy
2017-11-30 14:42 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Keerthy @ 2017-11-10 11:13 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-gpio, linux-kernel, j-keerthy, t-kristo
As per the re-design assign the first bank regs for unbanked
irq case. This was missed out in the original patch.
Signed-off-by: Keerthy <j-keerthy@ti.com>
Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip")
---
Changes in v2:
* Fixed $Author
drivers/gpio/gpio-davinci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index f75d844..e4b3d7d 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -383,7 +383,7 @@ static int gpio_irq_type_unbanked(struct irq_data *data, unsigned trigger)
u32 mask;
d = (struct davinci_gpio_controller *)irq_data_get_irq_handler_data(data);
- g = (struct davinci_gpio_regs __iomem *)d->regs;
+ g = (struct davinci_gpio_regs __iomem *)d->regs[0];
mask = __gpio_mask(data->irq - d->base_irq);
if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gpio: davinci: Assign first bank regs for unbanked case
2017-11-10 11:13 [PATCH v2] gpio: davinci: Assign first bank regs for unbanked case Keerthy
@ 2017-11-24 7:24 ` Keerthy
2017-11-30 14:42 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Keerthy @ 2017-11-24 7:24 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-gpio, linux-kernel, t-kristo
On Friday 10 November 2017 04:43 PM, Keerthy wrote:
> As per the re-design assign the first bank regs for unbanked
> irq case. This was missed out in the original patch.
Linus,
A gentle ping.
- Keerthy
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip")
> ---
>
> Changes in v2:
>
> * Fixed $Author
>
> drivers/gpio/gpio-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index f75d844..e4b3d7d 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -383,7 +383,7 @@ static int gpio_irq_type_unbanked(struct irq_data *data, unsigned trigger)
> u32 mask;
>
> d = (struct davinci_gpio_controller *)irq_data_get_irq_handler_data(data);
> - g = (struct davinci_gpio_regs __iomem *)d->regs;
> + g = (struct davinci_gpio_regs __iomem *)d->regs[0];
> mask = __gpio_mask(data->irq - d->base_irq);
>
> if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gpio: davinci: Assign first bank regs for unbanked case
2017-11-10 11:13 [PATCH v2] gpio: davinci: Assign first bank regs for unbanked case Keerthy
2017-11-24 7:24 ` Keerthy
@ 2017-11-30 14:42 ` Linus Walleij
2017-12-01 4:40 ` Keerthy
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2017-11-30 14:42 UTC (permalink / raw)
To: Keerthy; +Cc: linux-gpio, linux-kernel, Tero Kristo
On Fri, Nov 10, 2017 at 12:13 PM, Keerthy <j-keerthy@ti.com> wrote:
> As per the re-design assign the first bank regs for unbanked
> irq case. This was missed out in the original patch.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip")
> ---
>
> Changes in v2:
>
> * Fixed $Author
Patch applied for fixes, sorry for eternal delay.
Keerthy, if you work on DaVinci, would you mind looking quickly at this
patch:
https://marc.info/?l=linux-input&m=151151651401442&w=2
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gpio: davinci: Assign first bank regs for unbanked case
2017-11-30 14:42 ` Linus Walleij
@ 2017-12-01 4:40 ` Keerthy
2017-12-01 5:29 ` Keerthy
0 siblings, 1 reply; 5+ messages in thread
From: Keerthy @ 2017-12-01 4:40 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, linux-kernel, Tero Kristo
On Thursday 30 November 2017 08:12 PM, Linus Walleij wrote:
> On Fri, Nov 10, 2017 at 12:13 PM, Keerthy <j-keerthy@ti.com> wrote:
>
>> As per the re-design assign the first bank regs for unbanked
>> irq case. This was missed out in the original patch.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip")
>> ---
>>
>> Changes in v2:
>>
>> * Fixed $Author
>
> Patch applied for fixes, sorry for eternal delay.
No issues and Thanks!
>
> Keerthy, if you work on DaVinci, would you mind looking quickly at this
> patch:
> https://marc.info/?l=linux-input&m=151151651401442&w=2
Sure. I will get back on this.
>
> Yours,
> Linus Walleij
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gpio: davinci: Assign first bank regs for unbanked case
2017-12-01 4:40 ` Keerthy
@ 2017-12-01 5:29 ` Keerthy
0 siblings, 0 replies; 5+ messages in thread
From: Keerthy @ 2017-12-01 5:29 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, linux-kernel, Tero Kristo
On Friday 01 December 2017 10:10 AM, Keerthy wrote:
>
>
> On Thursday 30 November 2017 08:12 PM, Linus Walleij wrote:
>> On Fri, Nov 10, 2017 at 12:13 PM, Keerthy <j-keerthy@ti.com> wrote:
>>
>>> As per the re-design assign the first bank regs for unbanked
>>> irq case. This was missed out in the original patch.
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip")
>>> ---
>>>
>>> Changes in v2:
>>>
>>> * Fixed $Author
>>
>> Patch applied for fixes, sorry for eternal delay.
>
> No issues and Thanks!
>
>>
>> Keerthy, if you work on DaVinci, would you mind looking quickly at this
>> patch:
>> https://marc.info/?l=linux-input&m=151151651401442&w=2
>
> Sure. I will get back on this.
Linus,
Could you please Cc nsekhar@ti.com who Maintains
arch/arm/mach-davinci/board-da850-evm.c
Also could you see Cc me as well on that patch?
Regards,
Keerthy
>
>>
>> Yours,
>> Linus Walleij
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-01 5:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-10 11:13 [PATCH v2] gpio: davinci: Assign first bank regs for unbanked case Keerthy
2017-11-24 7:24 ` Keerthy
2017-11-30 14:42 ` Linus Walleij
2017-12-01 4:40 ` Keerthy
2017-12-01 5:29 ` Keerthy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).