* [PATCH 0/2] pinctrl/nomadik/abx500: Adjustments for abx500_gpio_probe()
@ 2017-12-20 9:50 SF Markus Elfring
2017-12-20 9:51 ` [PATCH 1/2] pinctrl/nomadik/abx500: Delete an error message for a failed memory allocation in abx500_gpio_probe() SF Markus Elfring
2017-12-20 9:52 ` [PATCH 2/2] pinctrl/nomadik/abx500: Improve a size determination " SF Markus Elfring
0 siblings, 2 replies; 5+ messages in thread
From: SF Markus Elfring @ 2017-12-20 9:50 UTC (permalink / raw)
To: linux-gpio, linux-arm-kernel, Alessandro Rubini, Linus Walleij
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 20 Dec 2017 10:45:01 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/pinctrl/nomadik/pinctrl-abx500.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
--
2.15.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] pinctrl/nomadik/abx500: Delete an error message for a failed memory allocation in abx500_gpio_probe()
2017-12-20 9:50 [PATCH 0/2] pinctrl/nomadik/abx500: Adjustments for abx500_gpio_probe() SF Markus Elfring
@ 2017-12-20 9:51 ` SF Markus Elfring
2017-12-21 9:19 ` Linus Walleij
2017-12-20 9:52 ` [PATCH 2/2] pinctrl/nomadik/abx500: Improve a size determination " SF Markus Elfring
1 sibling, 1 reply; 5+ messages in thread
From: SF Markus Elfring @ 2017-12-20 9:51 UTC (permalink / raw)
To: linux-gpio, linux-arm-kernel, Alessandro Rubini, Linus Walleij
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 20 Dec 2017 10:12:56 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/nomadik/pinctrl-abx500.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nomadik/pinctrl-abx500.c
index b32c0d602024..feb030d1ea63 100644
--- a/drivers/pinctrl/nomadik/pinctrl-abx500.c
+++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c
@@ -1157,11 +1157,8 @@ static int abx500_gpio_probe(struct platform_device *pdev)
pct = devm_kzalloc(&pdev->dev, sizeof(struct abx500_pinctrl),
GFP_KERNEL);
- if (pct == NULL) {
- dev_err(&pdev->dev,
- "failed to allocate memory for pct\n");
+ if (!pct)
return -ENOMEM;
- }
pct->dev = &pdev->dev;
pct->parent = dev_get_drvdata(pdev->dev.parent);
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] pinctrl/nomadik/abx500: Improve a size determination in abx500_gpio_probe()
2017-12-20 9:50 [PATCH 0/2] pinctrl/nomadik/abx500: Adjustments for abx500_gpio_probe() SF Markus Elfring
2017-12-20 9:51 ` [PATCH 1/2] pinctrl/nomadik/abx500: Delete an error message for a failed memory allocation in abx500_gpio_probe() SF Markus Elfring
@ 2017-12-20 9:52 ` SF Markus Elfring
2017-12-21 9:20 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: SF Markus Elfring @ 2017-12-20 9:52 UTC (permalink / raw)
To: linux-gpio, linux-arm-kernel, Alessandro Rubini, Linus Walleij
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 20 Dec 2017 10:22:53 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/nomadik/pinctrl-abx500.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nomadik/pinctrl-abx500.c
index feb030d1ea63..7d00a5d864f5 100644
--- a/drivers/pinctrl/nomadik/pinctrl-abx500.c
+++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c
@@ -1155,8 +1155,7 @@ static int abx500_gpio_probe(struct platform_device *pdev)
return -ENODEV;
}
- pct = devm_kzalloc(&pdev->dev, sizeof(struct abx500_pinctrl),
- GFP_KERNEL);
+ pct = devm_kzalloc(&pdev->dev, sizeof(*pct), GFP_KERNEL);
if (!pct)
return -ENOMEM;
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] pinctrl/nomadik/abx500: Delete an error message for a failed memory allocation in abx500_gpio_probe()
2017-12-20 9:51 ` [PATCH 1/2] pinctrl/nomadik/abx500: Delete an error message for a failed memory allocation in abx500_gpio_probe() SF Markus Elfring
@ 2017-12-21 9:19 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2017-12-21 9:19 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-gpio, Linux ARM, Alessandro Rubini, LKML, kernel-janitors
On Wed, Dec 20, 2017 at 10:51 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 20 Dec 2017 10:12:56 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] pinctrl/nomadik/abx500: Improve a size determination in abx500_gpio_probe()
2017-12-20 9:52 ` [PATCH 2/2] pinctrl/nomadik/abx500: Improve a size determination " SF Markus Elfring
@ 2017-12-21 9:20 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2017-12-21 9:20 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-gpio, Linux ARM, Alessandro Rubini, LKML, kernel-janitors
On Wed, Dec 20, 2017 at 10:52 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 20 Dec 2017 10:22:53 +0100
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-21 9:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-20 9:50 [PATCH 0/2] pinctrl/nomadik/abx500: Adjustments for abx500_gpio_probe() SF Markus Elfring
2017-12-20 9:51 ` [PATCH 1/2] pinctrl/nomadik/abx500: Delete an error message for a failed memory allocation in abx500_gpio_probe() SF Markus Elfring
2017-12-21 9:19 ` Linus Walleij
2017-12-20 9:52 ` [PATCH 2/2] pinctrl/nomadik/abx500: Improve a size determination " SF Markus Elfring
2017-12-21 9:20 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).